ni-eminen / reactcomponentviewer Goto Github PK
View Code? Open in Web Editor NEWUI for React Component Viewer. Build React components without installing anything!
UI for React Component Viewer. Build React components without installing anything!
Cloned on 3rd of May commit f5b2eca.
Programs starts fine on the first try and all the tests pass.
The code is perfectly documented with docstrings with no missing functions. Pylinter gives only one warning.
The program seems to function fine, although it allows user to login without username or password. Everything else like adding or rendering components works well.
I had somewhat hard time combing through the code as I'm not really familiar with react or frontend development. The code seems at moments pretty verbose but that seems to be due to verbosity of tkinter library.
The program is split well into different files and classes with each handling clearly separate functionality of the program. I would however argue the index.py
still contains enough ui code to belong to ui
package.
The whole login with username and password seems to be client-side only, which makes it pretty useless in a practical sense (malicious user can bypass the code or just read the components table as it's not encrypted), but other than that the implementation seems sound with checking against the hash and using salt to strengthen against a brute force attack.
There is little bit of hardcoding/repetition with tkinter widget attributes. Especially argument bg='white'
can be seen multiple times in all of the ui files. Maybe the common colors and fonts could be defined in some kind of style config, much like CSS in HTML.
In the file add_component_screen.py
there is global variable POP
and as it's only referenced inside class AddComponentScreen
of a which there is only one instance of (?) it could be changed to be a member of AddComponentScreen
class.
There aren't that many tests currently, but as the application is mostly ui, most of the codebase falls outside of the testing coverage. The tests for the remaining code are well written, focused and self-descriptive.
Overall well written project that is easy to read and understand, and possibly expand.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.