nia-e/sdm845-abootctl

Utility to control boot slots on OnePlus SDM845 devices from mainline Linux

sdm845-abootctl's Issues

Check bitmap against real phones

SlotInfo struct is not guaranteed to be correctly formatted and bits may be misplaced. Ensure it is before actually using it by testing on actual devices.

Make `set_boot_partitions()` generic

Support other partitions, don't require that both boot partitions be written.

It would probably also be worth moving the write_inplace / flush out of the function so flushing can be handled by the caller.

Also, there is a bug, the partitition map keys are the partition number, not the name https://github.com/ai-b-z/sdm845-abootctl/blob/master/src/partitions.rs#L76

https://docs.rs/gpt/2.0.0/gpt/struct.GptDisk.html#method.partitions

MVP requirements

For this to be a reliable, useful tool there's a few things that I think we need:

Compatibility with Android bootctl

Whilst the API there isn't idea, it works exactly as intended, we should support exactly the same behaviour as Android, this avoids duplicating documentation and creating confusion for users. It ensures that at a bare minimum we can ensure the same functionality as Android.

Extra functionality is useful but non-essential.

Tests

It's important that we are SURE that we are implementing correct functionality, this tool could easily brick a device if it doesn't do exactly what it is meant to. We should have unit tests for all functions that mess with bits to ensure they work as intended (github actions, or gitlab CI).