after_rpx_connect or before_rpx_connect is not called on user model

[nicolasblanco]

after_rpx_connect or before_rpx_connect is not called on user model

[pacifists]

Well I supose that is a "feature" not a bug, but then the documentation should be improved.

Now it says: Some hooks are available to get the RPXNow user data objects before or after the connection.

After looking deeper into gem code I've found that those hooks are executed only when creating new user not on "every connection" to rpx, so either it should do what I believe says in the docs or the wording needs to be changed.

[nicolasblanco]

Thanks, you are right!
I will update this very soon by adding new callbacks.

[pacifists]

I've started pondering with this again and by trial and error found out that the callbacks that are shown in the docs don't work. Only if methods on_before_rpx_connect and on_after_rpx_connect are present in the model then they're called, but simple methods with no "on_" never got called. Also I've got invalid rpx when tried using after method. So just you know if you'll try to change/fix something

[nicolasblanco]

yep.
i've worked on this friday and i'll finish the next version monday.

[nicolasblanco]

OK. That should be fixed! Please test the latest version with the two new hooks (see in README).

[pacifists]

I've come around to my app that used rpx just now, but like a week ago I've found omniauth gem so won't be able to test if this works.
I've dropped rpx and went with pure devise + omniauth, because it's so much more better and gives all control I need in my app.