nicolassiver/nodebb-plugin-ns-spoiler

Spoiler. Ability to control visibility of the content in posts. Works better with Markdown syntax.

nodebb-plugin-ns-spoiler's Issues

Spoilers not opening when used with 1.12.1

As per the title.

Not sure if it's just isolated to me, mind looking into it, please?

Nodebb compatibility

Hey, it seems that plugin is not compatible with newest nodebb. I'm not sure if this can be fixed quickly though.

Spoiler issue

See photo: https://i.imgur.com/lgXGjl2.png

This has happened twice now. As you can see in the second spoiler, instead of the attached images showing, the text repeats itself. The images in the 3rd spoiler aren't the ones actually inserted; this is probably due to spoiler 2 bugging out.

You can see more here: https://saesrpg.uk/post/159291

Spoilers can break design of pages

Using multiple spoilers in a post on the persona theme breaks stuff. Edit buttons and other stuff not working anymore.

Button not workin

Hi i install plugin at 1.12.2 and not work when i press button :(

Can't get spoiler content in production env

https://github.com/NicolasSiver/nodebb-plugin-ns-spoiler/blob/master/plugin/controller.js
line 17-18

// Trigger parsing process, it will invoke `Controller.parsePost` through hooks
async.apply(nodebb.posts.parsePost),

this would not trigger parsing process when global.env === 'production', because cache was used in https://github.com/NodeBB/NodeBB/blob/45e412ed7c0a876da177a491c1f03f4623349936/src/posts/parse.js line18-21

if (postData.pid && cache.has(String(postData.pid))) {
	postData.content = cache.get(String(postData.pid));
	return callback(null, postData);
}

so you would never get the spoiler content.

Lists

If spoiler is used with lists, without additional space, it creates broken layout.

Does it work for 0.9.4 version?

I can't see the plugin listed in the ACP. So i would like to know if its compatible with 0.9.4 version?

Issue with multiple lists

We have discovered that more complex posts with multiple lists and spoilers can have a race condition. Where spoiler will move content around from one list under a spoiler to another list.

Example content is mentioned here: #13 (comment)

Images dont show up

Hi!

Images in spoiler dont show up. I would be grateful for help.

Nodebb version: v1.8.2

Link to Nodebb community topic: https://community.nodebb.org/topic/12246/fix-spoiler-plugin

Error in console:

spoiler.js:57 Uncaught TypeError: e.unloadImages is not a function
    at i.<anonymous> (spoiler.js:57)
    at i.onack (socket.io.js:2)
    at i.onpacket (socket.io.js:2)
    at i.<anonymous> (socket.io.js:2)
    at i.emit (socket.io.js:1)
    at i.ondecoded (socket.io.js:1)
    at a.<anonymous> (socket.io.js:2)
    at a.i.emit (socket.io.js:1)
    at a.add (socket.io.js:1)
    at i.ondata (socket.io.js:1)

(Enhancement) Add a screenshot!

Could you add a screenshot so we know what it looks like before installing?
It would be nice. :P

Doesn't work with v1.12.0

Unfortunately, this plugin doesn't work with NodeBB v1.12.0.

The only error that's given:

2019-03-25T19:04:32.319Z [4567/11403] - �[33mwarn�[39m: [plugins/load] The following plugins may not be compatible with your version of NodeBB. This may cause unintended behaviour or crashing. In the event of an unresponsive NodeBB caused by this plugin, run `./nodebb reset -p PLUGINNAME` to disable it.
�[33m  * �[39mnodebb-plugin-ns-spoiler

Spoilers having problems with lists

I tried to use lists with spoilers and that broke things.

:::

1. Item
2. Item 

:::

Expected behavior:

Everything between the spoiler tags being hidden

What actually happens:

List gets displayed, button below.

Support for NodeBB 1.13.x / 1.14.x ?

Hi there,

I am running a NodeBB on 1.13.3. When installing your plugin the plugin finder only gives me version 4.1.0, which does not work. I assume the latest doesn't show up due to package.json compatibility being ~1.12.0 (and that older version maybe didn't have the correct compatibility settings).

If this plugin is compatible with 1.13.x and/or 1.14.x I'd love to see an update in the package.json and a new npm release ❤️

Thanks a lot in advance.

Adding a double quote before spoiler doesn't let spoiler to open

I use [email protected] with NodeBB 1.15.5.
Generally everything works good. But once I add some text with double quotes, a spoiler located after such text stops to open.

Examples of NodeBB post for which spoiler doesn't open:

Text "text" text

:::

something

:::

Text "text

:::

something

:::

Example of NodeBB post for which spoiler works well:
Text text

:::

something

:::