Right click with control click doesn't work on mac with trackpad

[ewof]

Right click with control click doesn't work on mac with trackpad

[slook]

Unfortunately the 3.2.x branch will not be getting any more bug fixes now. Development is happening in 3.3.x wherein the issue you reported may already be fixed, or it may present differently since GTK 4 is now the default.

Please install Nicotine+ 3.3.0.dev6 to verify if the problem still exists or not, link:

https://github.com/nicotine-plus/nicotine-plus/blob/master/doc/TESTING.md#macos

[ewof]

bug is still there on 3.3.0.dev6

[slook]

Please can you try some Keyboard Shortcuts (press F1 for a list) that involve the Control/Command key and verify that they work as expected, or are they with the incorrect modifier key?

[ewof]

seams to be related to tabs, things like cmd + h for away and shift + cmd + d/c for disconnecting/connecting work but things like cmd + a or cmd + f in downloads tab don't

[slook]

I suspect that the cmd key modifier or mouse button keyval is being consumed by the Accelerator() class module.

nicotine-plus/pynicotine/gtkgui/widgets/accelerator.py

Line 27 in c03d08a

class Accelerator:

[mathiascode]

I suspect that the cmd key modifier or mouse button keyval is being consumed by the Accelerator() class module.

The problem is that the treeview shortcuts are provided by GTK, which no longer translates ctrl -> cmd in GTK 4.

We need to add the shortcuts like this (should probably override them in the TreeView class):

nicotine-plus/pynicotine/gtkgui/application.py

Lines 255 to 271 in 45bae5f

	# Built-in GTK shortcuts use Ctrl key on macOS, add shortcuts that use Command key
	for widget in (Gtk.Text, Gtk.TextView):
	for action_name, accelerator in (
	("cut-clipboard", "<Meta>x"),
	("copy-clipboard", "<Meta>c"),
	("paste-clipboard", "<Meta>v"),
	("selection.select-all", "<Meta>a"),
	("misc.insert-emoji", "<Meta>period"),
	("text.undo", "<Meta>z"),
	("text.redo", "<Shift><Meta>u")
	):
	widget.add_shortcut(
	Gtk.Shortcut(
	trigger=Gtk.ShortcutTrigger.parse_string(accelerator),
	action=Gtk.NamedAction(action_name=action_name),
	)
	)

@ewof I'm not sure if GTK supports control click. Could you try e.g. Gaphor, and see if it has the same issue? https://gaphor.org/en/

Does macOS support pressing the trackpad with two fingers to show context menus?

[ewof]

Does macOS support pressing the trackpad with two fingers to show context menus?

i don't think so, got the laptop like 2 weeks ago it's my first mac, i'm not able to use two fingers to show context menus

same issue on graphor yea, control click with trackpad doesn't work but right click with mouse works

[mathiascode]

i don't think so, got the laptop like 2 weeks ago it's my first mac, i'm not able to use two fingers to show context menus

You can change this behavior in the macOS touchpad settings.

As for adding control click to Nicotine+, should be fairly straightforward with our own context menus.

[mathiascode]

In any case, not a blocker for Nicotine+ 3.3.0, since there's a workaround.

[slook]

This seems like it would be ideal to fix it upstream and add it to #2014.