nielsmaerten/peppermint

Nature's most beautiful wallpapers, right in your Dropbox

peppermint's Issues

Lookup credits of an image

Users should be able to look up who originally uploaded an image to Reddit.
Eg, they should be able to find the original post and author

Memory limit exceeded

Might this be due to JPG files not being deleted from the temp folder? After all, all 'disk' writes are actually stored in memory. So we should clean up after ourselves when a function quits, bc the env may be reused but a new request

Batch adding image to interested users' lists

peppermint/src/eventhandlers/on-new-master-image.ts

Line 52 in ff18c6f

await FirebaseClient.GET_INSTANCE().addPostToUserList(post, user.id)

It is inefficient to execute a DB-call for every single user.
Instead, modify this so it only runs a single update-call on the entire users node.
This update should add the new items to respective users' lists.

Properties of a new image

When a new image is added to the Masterlist, a handler should:

• Get the width and height of the new image
• Store this information with the image (?)

Firebase.config() not available

peppermint/src/clients/firebase-client.ts

Line 10 in 8c62078

admin.initializeApp(functions.config().firebase)

Config () is not available at this point, when running on Cloud Functions.
Weirdly, it is available in the index.js file at the root of the functions folder...

Can I make it available here? Or do I need to grab the config at function init time, and store it somewhere so it can be used here?

Select multiple posts from firebase at once?

peppermint/src/eventhandlers/on-trigger-reddit-update.ts

Line 17 in 645ab97

if (!await firebase.getPost(topPosts[i])) {

Instead of fetching every post separately, can I select multiple posts at once, and do only 1 call?
To be investigated...

Save image to user's dropbox

When a new image is added to the personal list of a user, it triggers the onNewUserImage function, which should add the image to the dropbox of that user

Update README

Create a webpage

Create a webpage explaining what Peppermint does, and where users can connect their dropbox to the service

Redundant DB call

peppermint/src/agents/maintenance.ts

Line 117 in bd50c1b

const dropboxToken = await FirebaseClient.GET_INSTANCE().getUserToken(

This call to Firebase for the token is not necessary!
Thee token is already available in this.user

Requesting image size fails

Looks like whatever is passed into the function when getting the size for a new image, is not its url:

Stackdriver Error Reporting error detail

Error: You should provide an URI string or a "request" options object.
https://console.cloud.google.com/errors/1794925657192919263?time=P30D&project=peppermint-wallpapers

Add image to user's personal list

After querying for users interested in a new image, we add the image to the personal lists of those users

Database performance code smell

peppermint/src/eventhandlers/on-trigger-reddit-update.ts

Line 17 in 8c62078

if (!await firebase.getPost(topPosts[i])) {

I don't like this. It's gonna make approx 20 calls to firebase in rapid succession. Even with firebase, that's probably not good. It might be better to fetch the entire list, and compare in memory. But of course, the list gets larger as time goes on... Ideally, only 1 query is fired containing all new IDs, and the response contains those not already in the database. Then search happens entirely in firebase itself.

Set user preferences

Users should have a way of setting their preferred minimum width, height,...

Mock add user?

peppermint/src/eventhandlers/connect-user.ts

Line 27 in b5e9d5e

new User(response.access_token, undefined, undefined, response.account_id)

#22

Run maintenance on a user's dropbox

• Check when the dropbox was last maintained, if > maintenance interval, continue maintenance
• Remove all images that no longer meet the user's requirements* from the user's list
• Remove all images that are no longer in the user's list from their dropbox
• Update date last maintained

(*) Requirements can include: width, heigth, max-age, max-number-of-files (optional),...

Add CONTRIBUTING.md and Code of Conduct

Faster adding of new images from Reddit

Current behavior:

• Top posts are fetched from Reddit
• Masterlist is fetched from Firebase
• Function iterates over the posts, and each post that's not in the Masterlist is added to Firebase

Needless to say, this is not efficient...

Suggested behavior:

• Posts are fetched from Reddit
• All posts are sent to Firebase using a batch update call

This would result in a null operation for posts that are already in the Masterlist, it's the same data, so nothing changes.
For posts that are not already in there, this will result in new nodes being created.
Triggering in turn the onNewMasterImage function, which will fill in the remaining details.

Query interested users

After a new image has been added to the Masterlist, we query which users are interested in this image