nikialeksey/porflavor

PorFlavor - is the gradle plugin for extending android productFlavors

porflavor's Issues

Does not works with lower case flavor names

... something like this

    productFlavors {
        brand1 {
            dimension 'brand'
        }
        brand2 {
            dimension 'brand'
        }
        brand3 {
            dimension 'brand'
        }
        store {
            dimension 'version'
        }
        staging {
            dimension 'version'
        }
    }

and using title case flavor name break dependencies implementation flavor specific like that:

dependencies {
    storeImplementation ....
    stagingImplementation ....
}

move "apply plugin" on top of gradle file

actually if we do we receive this error

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* Where:
Build file '#####/app/build.gradle' line: 8

* What went wrong:
A problem occurred evaluating project ':app'.
> Failed to apply plugin [id 'com.nikialeksey.porflavor']
   > java.lang.NullPointerException (no error message)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring project ':app'.
> compileSdkVersion is not specified.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

* Get more help at https://help.gradle.org

CONFIGURE FAILED in 0s
Failed to apply plugin [id 'com.nikialeksey.porflavor']

default buildConfigField for non-specific combinations

In our app we currently have 6 productFlavors

productFlavors {
    create("local") {} // the first three are dimension `environment`
    create("staging") {}
    create("production") {}
    create("type1") {} // this and the following are dimension `app`
    create("type2") {}
    create("type3") {}
    create("type4") {}
 }

Then inside the porflavor block, we specify for only a few combinations some BuildConfigFields:

porflavor {
   create("localType1") { 
       buildConfigField("String", "CLIENT_ID", """"id"""")
    }
   create("stagingType1") { 
       buildConfigField("String", "CLIENT_ID", """"id"""")
    }
   create("stagingType2") { 
       buildConfigField("String", "CLIENT_ID", """"id"""")
    }
   create("stagingType3") { 
       buildConfigField("String", "CLIENT_ID", """"id"""")
    }
   create("productionType2") { 
       buildConfigField("String", "CLIENT_ID", """"id"""")
    }
}

But for some of the combinations possible, some of the buildConfigField are missing, and when selecting one of the lacking BuildVariants from Android Studio, or when running the generic ./gradlew build (which I'm trying to setup on CI, the builds fail as there is no BuildConfig.CLIENT_ID specified.

Should I specify all the BuildConfigField for every possible combination?

Add support for resValue fields

Currently the library only supports buildConfigFields, which are useful for runtime use-cases. It would be great to also support resValue fields, since those can be used directly inside the AndroidManifest at compile time.

http://dcow.io/android-gradle-plugin-docs/com/android/build/gradle/api/BaseVariant.html#resValue(java.lang.String,%20java.lang.String,%20java.lang.String)