parser fails to handle return(new Foo); syntax

[nikic]

parser fails to handle return(new Foo); syntax

[nikic]

Well, if that isn't embarrassing. The problem is the parenthesis around the new statement. Normally they are matched by the '(' expr ')' rule (and simply ignored), but in this case they cause a shift/reduce conflict with the (new Foo)->bar() syntax. I can't yet find a clean way to solve that conflict, but I'll keep trying :)

[chrisblizzard]

Awesome. Let me know if you figure it out.

(My apologies for not just giving you a patch but parsers aren't my strong suit.)

[chrisblizzard]

Any luck?

[nikic]

Sorry it took so long, I completely forgot about this. I fixed the issue in e16513a. Turned out to be easier than I expected :)

[chrisblizzard]

Woot - thanks so much! I'll pull a new version and see how it fares. Thanks!

[chrisblizzard]

OK, my testing seems to be working pretty well. I got tripped up by the changes to the constructor syntax to the parser, but other than that it seems to be working pretty well - thanks again!

[sebastianbergmann]

Just out of curiosity: what are you doing with PHP-Parser, @chrisblizzard?

[chrisblizzard]

Doing some analysis against code bases like WordPress and other frameworks to see what functions they use in the standard(ish) PHP modules. Mostly just looking at compatibility matrixes.