nikola-popov/slack-coinbase-app

Java app that integrates two well-known systems - Slack and Coinbase. Allowing you to make online cryptocurrency transactions easily within Slack using simple, intuitive and native for Slack UI.

slack-coinbase-app's Issues

Validate authorization response from coinbase

When a client makes a request for auth a unique STATE parameter should be send.
After a successful auth coinbase redirects back to the app with the same STATE.
Both the requests and response states should match.

Example reference: https://developers.coinbase.com/docs/wallet/coinbase-connect/security-best-practices#state-variable

Store user details in DB

io.slack.blockchain.processing.dialog.ConfigurationDialogProcessor should store user inputted information in a database. For this, an entity and a repository should be created.

The following things must be stored in the DB:

• store user inputted email
• store unique client and team id

Verifying requests from Slack

Validate the the incomming requests using the SIGNED SECRET (stored in application.properties).

As a reference see: https://api.slack.com/docs/verifying-requests-from-slack

Possible solutions: implement a web filter

Try to use jslack attachment model instead of the custom one

Try to reuse :

Attachment attachment = Attachment.builder().text("text").footer("footer").build();
List<Attachment> attachments = Arrays.asList(attachment);

instead of the custom created model and logic.

Configure Sonar to scan the project regularly

Sonnar is currently not scanning the project correctly. As you can see on the top right corner of https://sonarcloud.io/dashboard?id=Nikola-Popov_slack-coinbase-app the latest scan is performed on November 14, 2018, 10:06 PM but there should be more scans after this one.

• Changes to .travis.yml and sonar-project.properties files must be made in order to make the sonar work correctly.
• Validate that test Coverage percentage is displayed and calculated properly. Currently it is stuck at 0% (which could be another issue?)

Send cryptocurrency to another user

One must be able to send cryptocurrencies to other people identifying them by their already provided by them coinbase email.

io.slack.blockchain.coinbase.security.oauth.services.CoinbaseAuthorizationService can be used to acquire an Authorization token which should be send as a header when calling the coinbase api.