nikolalukic94/pl-rater

PL Rating App in Laravel

pl-rater's Issues

Fix mixed formatting

In looking through the repo it looks like there are a bunch of formatting inconsistencies (tabs vs spaces, alignments, comments, etc) Take a look at this or this.

Tweaks to File model

Couple suggestions for your File model:

1. Seems like your $fillable array is very large and would make more sense to delete it and go with $guarded = []; or explicitly set the properties instead of using the create() helper method
2. in notes() it should be referencing the Notes model, but the model should be changed to Note instead (then this File class would be fine)
3. in createFromRequest() there are a lot of duplicate keys (mailing_address_zip, agent_name, agent_phone_number, and email_address)
4. Seems like you could de-duplicate some work within the createFromRequest(), updateGeneralInfo() and updateFileRatingCharacteristics() methods. You can also use the tap() helper to update and return the saved model

Rename ContactUs model

Seems like this could be renamed from ContactUs to Contact and the database table name from contact_uses to contacts

Drop Email "model"

Right now this isn't acting as a model, so it doesn't need to be extending Illuminate\Database\Eloquent\Model. Also, since it's only method is being referenced once in the EmailController we aren't gaining anything by having this class.

I'd move the request handling and $properties back into the EmailController and delete the Email model class.

Create "approved" route group

It looks like you have a handful of approved middleware references. You could create a route group for just this middleware, then add all of those routes/sub-groups into the new approved group