nikosgram/gringotts

Gringotts is an item-based economy plugin for the Bukkit Minecraft server platform. Unlike earlier economy plugins, all currency value and money transactions are based on actual items in Minecraft, per default emeralds.

Hi, I'm Nikolaos, a software engineer based in Newcastle upon Tyne in the UK. My passion is developing software whilst analysing projects and making ongoing productivity improvements. Another passion of mine is creating gameplay content for Youtube and Trovo.

• 🔭 I’m currently working on Gringotts
• 🌱 I’m currently learning cryptography
• 😄 Pronouns: he/him

gringotts's Issues

bug - Tab-complete errors for /moneyadm

Hi, running the latest snapshot with Paper-149 and encountering an issue when I try and use the /moneyadm commands.

I can type /moneyadm rm or /moneyadm add just fine, but once I continue typing after add or rm I get this message in chat for every additional keystroke - "An internal error occurred while attempting to tab-complete this command." It just continues spamming the chat with this the more I type.

In my console when I get that chat message ingame, I get this error with every keystroke: https://pastebin.com/XcYvRPFx

Not sure how to fix this. It doesn't seem to affect the operation of the command, but fills the logs and I'm worried there might be something worse happening under the hood.

Thanks in advance for your help!

Add support for Lands

Add support for Lands

https://www.spigotmc.org/resources/lands-minecraft-land-claim-plugin-grief-prevention-protection-gui-management-wars-1-15-support.53313/

Towny Economy Issue

logs\latest.log : https://pastebin.com/nkzvsANh

I cannot claim a plot in towny, neither will tax be taken out - leading into my plot becoming unowned. This works otherwise perfectly with just vault, but the plugin is bugged out with compatibility issues with Towny at the moment unfortunately.

Track the overall economy of the server for bstats. https://bstats.org/plugin/bukkit/Gringotts

Nation vaults don't bold [Nation Vault] on creation

Using latest snapshot.

This is mostly a cosmetic thing, but Nation Vaults don't bold like other vaults once they're created.

Not a high priority as all other functions seem to work fine, but thought I would point it out.

Thanks!

/money pay typo

You currently have syntax showing /money pay account amount
but the right way to pay is actually /money pay amount account

This confuses players since its opposite

Latest Version

Thank you!

Barrel doesn't work [Issue]

usevault: container: true
Doesn't affect barrels.

Can't get a player's balance using Denizen

Hey, I got an error when trying to get a player's balance using the <player.money> tag in Denizen scripting plugin:

https://pastebin.com/dwQgsf3G

Gringotts in combination with UltimateShops Premium and Paper 1.14.3 does not seem to deposit emeralds in an offline players inventory / vault.

As the title details. The emeralds are simply voided.

Placeholders Error

Constant error, placeholders plugin author referred me to report it here.

PlaceholderAPI/PlaceholderAPI#308 (comment)

Town vaults lose balance on town rename, unable to create new vault

Hi, currently working with the latest snapshot of Gringotts and Towny. A player had created a town vault, but when they renamed their town their vault didn't change town name, and then the balance of gold which was in it disappeared. Further attempts to create new vaults with the updated name did not create.

Let me know if you need any more info - would be great to know what this is. Thanks!

Was getting this error in the console: Pastebin link

When I run any command it says "an internal error occurred when attempting to perform this command." What can i do to fix it?

Customize items as currency ?

Hello,

By only using a datapack plugin, we have managed to create a new item we want to use as a currency for the server. This is how the server recognises it:
minecraft:emerald{display:{Name:'{"text":"Rubis","italic":false}'},CustomModelData:1}

(CustomModelData:1) is the Ruby texture:

We can give it to ourselves without any problem. But we can't manage to make Gringotts recognise it as a material. Is it possible and how would you do it?

Factions money issue

Hi!, I am having this issue when I try to deposit money to my faction (/f money d) it says "Unable to transfer (x amount of emeralds) to your factions from You."

I am running spigot 1.8.8, last version of factions and Gringotts 2.11.1-SNAPSHOT... I dont know if it is an issue or I am doing something wrong lol, the plugin seems to be working fine on this version

Love this plugin btw..., just what I was looking for my factions server! Keep up the good work!

Track how many vault exists for bstats. https://bstats.org/plugin/bukkit/Gringotts

Updated Towny support required.

Hello,

As of 0.95.2.13 and onwards the TownyEconomyObject used in Gringott's is no longer available.

If you need help making the change on your end feel free to pop into our Discord or IRC and ping me.

Configurable tag name for the vault signs.

Example: [<name>]. Idea by mc_tech on spigot.org

Get Gringotts balances too slow

In Dynmap towny it updates the balances of all towny towns, and nations, however it gringotts ends up timing out and spam exceptions:

org.gestern.gringotts.GringottsException: java.util.concurrent.TimeoutException
	at org.gestern.gringotts.GringottsAccount.getTimeout(GringottsAccount.java:298) ~[?:?]
	at org.gestern.gringotts.GringottsAccount.getBalance(GringottsAccount.java:80) ~[?:?]
	at org.gestern.gringotts.api.impl.GringottsEco$ValidAccount.balance(GringottsEco.java:490) ~[?:?]
	at org.gestern.gringotts.api.impl.VaultConnector.getBalance(VaultConnector.java:76) ~[?:?]
	at com.palmergames.bukkit.towny.TownyEconomyHandler.getBalance(TownyEconomyHandler.java:260) ~[?:?]
	at com.palmergames.bukkit.towny.object.EconomyAccount.getHoldingBalance(EconomyAccount.java:174) ~[?:?]
	at com.palmergames.bukkit.towny.object.EconomyAccount.getHoldingFormattedBalance(EconomyAccount.java:199) ~[?:?]
	at org.dynmap.towny.DynmapTownyPlugin.formatInfoWindow(DynmapTownyPlugin.java:462) ~[?:?]
	at org.dynmap.towny.DynmapTownyPlugin.handleTown(DynmapTownyPlugin.java:584) ~[?:?]
	at org.dynmap.towny.DynmapTownyPlugin.updateTowns(DynmapTownyPlugin.java:808) ~[?:?]
	at org.dynmap.towny.DynmapTownyPlugin.access$000(DynmapTownyPlugin.java:52) ~[?:?]
	at org.dynmap.towny.DynmapTownyPlugin$TownyUpdate.run(DynmapTownyPlugin.java:300) ~[?:?]
	at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.15.2.jar:git-Paper-212]
	at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54) ~[patched_1.15.2.jar:git-Paper-212]
	at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.15.2.jar:git-Paper-212]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_242]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_242]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]
Caused by: java.util.concurrent.TimeoutException
	at java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1784) ~[?:1.8.0_242]
	at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1928) ~[?:1.8.0_242]
	at org.gestern.gringotts.GringottsAccount.getTimeout(GringottsAccount.java:296) ~[?:?]

Better support of UUID system

Money pay isn't working

Command /money pay ain't working. When players use the command to send money to other players, they both recieve message which tells that 0 money has been transfered, even tho the amount has been bigger. And it's not the message that's wrong, because there's really not any money going in either direction. Withdraw and deposit commands seem to work without any problems tho.

This bug appeared after updating the plugin to 2.11.1-SNAPSHOT. We use the latest Vault (1.7.2-b107). Our server in 1.14.3 version (Paper).

Ended chest vault not working/ add support for shulkerbox vaults

It won’t let me create a vault on an ended chest. I tried changing the name in the configuration file to add an underscore but it didn’t do anything either. There’s no error message when i type [vault] on it, simply nothing happens.
I’d also love to see support for shulkerboxs. It would be nice to not have to have a bunch of vaults, when i could put everything into one place with out there being a limit

Server "returns" command and doesn't do anything with it

When i put in a Gringotts related command e.g. "/money" it just returns "/money" in chat.
Also when I try to set up a vault (chest, sign above/on it) by writing "[vault]" in the first line, its doesn't do anything.
The Server is running Vault, ChestShop, Gringotts and EssentialsX.
The Server Log is not providing any Errors/Warnings.

Add options for automatic use of vaults.

I feel like the plugin could use the option in the config to disallow automatic deposits to the vault so that players need to manually deposit money every time that they earn it.

Multiple users per vault.

All commands do not work.Vaults do not function.

When using gringots(2.10 for minecraft 1.12) all commads just return the help info for that command-for example /money pay (player) (amount) just returns /money pay (player) (amount).
And vaults juts dont work.

Custom item texture by NBT Tag 'Item Texture'.

Idea by jeannen on spigot.org

Add support for Oglofus Protection Plugin.

Support metadata identification for items.

Idea by killrrkillrr on spigot.org

Newest release has conflict with uSkyBlock

Disabling Gringotts lets uSkyBlock run fine, but both plugins don't like each other for some reason.
Pastebin

Update bstats dependency to v1.5

Placeholders please

I am doing a GUI bank and so far all is working now I am a bit stuck as I can't find specific gringots placeholders.

one for the vault

and one for the inventory

The way I made it looks something like:

  - "Balance: %vault_eco_balance%"
  - "Inside Bank: "
  - "Inside Inventory: "

I need a placeholder that finds the quantity inside container or enderchest and one for the vault please.

Towny bank not taking money

i used to play on a server that used gringotts and towny together. i am trying to create a a server with both plugins as well. everything was working fine at first. it was registering gold as currency. i was able to purchase a "test town" on my server with the money, but when i try deposit money from my inventory to the town bank, it tells me i dont have enough. you might be thinking that im making a silly error but the town purchase worked perfectly. i even tried only depositing 1 gold to the bank and that didnt even work.

note:

1. when i type the deposit command, the gold in my inventory flashes/bobs up and down like its trying to take it but cant.
2. it will work if i create a vault for the town but i want the town to have a virtual bank/vault
3. the same error msg displays when the vault is physically full

World Guard incompatibility?

I'm unable to create any sort of world guard region that allows players to access their own chest and not others. I have created a bank where players can create a Gringotts vault but there's a major flaw, players can just steal from each other.

How do I setup World Guard region to properly allow access to their own chests and not others?

Support for FactionsUUID

Is it possible to add support for FactionsUUID

https://www.spigotmc.org/resources/factionsuuid.1035/

2.11.2-SNAPSHOT - won't load with Paper-133

Having an issue with the latest snapshot - it won't load in Paper 133. let me know if you need any more details!

[22:40:18] [Server thread/ERROR]: Could not load 'plugins/Gringotts-2.11.2-SNAPSHOT-rf40b38b.jar' in folder 'plugins'
org.bukkit.plugin.InvalidDescriptionException: awareness has wrong type
at org.bukkit.plugin.PluginDescriptionFile.loadMap(PluginDescriptionFile.java:1038) ~[patched_1.15.2.jar:git-Paper-133]
at org.bukkit.plugin.PluginDescriptionFile.(PluginDescriptionFile.java:240) ~[patched_1.15.2.jar:git-Paper-133]
at org.bukkit.plugin.java.JavaPluginLoader.getPluginDescription(JavaPluginLoader.java:164) ~[patched_1.15.2.jar:git-Paper-133]
at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:147) ~[patched_1.15.2.jar:git-Paper-133]
at org.bukkit.craftbukkit.v1_15_R1.CraftServer.loadPlugins(CraftServer.java:358) ~[patched_1.15.2.jar:git-Paper-133]
at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:234) ~[patched_1.15.2.jar:git-Paper-133]
at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:885) ~[patched_1.15.2.jar:git-Paper-133]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_211]
Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to org.bukkit.plugin.PluginAwareness
at org.bukkit.plugin.PluginDescriptionFile.loadMap(PluginDescriptionFile.java:1035) ~[patched_1.15.2.jar:git-Paper-133]
... 7 more

PlaceholderAPI Incompatibility

Hey again,

Been noticing this popping up every time one of my players checks their Gringotts balance - looks like an incompatibility with PlaceholderAPI (I'm running PlaceholderAPI 2.10.5). This spams the console:

Console Output: https://pastebin.com/v4rvVdm2

This has only started happening when I added the latest Gringotts release - it's possible it could be connected to the tab-complete fixes you pushed in that?

Let me know if I need to report this to the PlaceholderAPI dev instead. Thank you!

Adding new command, moneyadmin economy, that allows to admins can see the total economy of the server.

Gringotts 2.11.1-SNAPSHOT & QuickShop Reremake | 1.15 3.1.3.14 communication issue

Been using Gringotts for a while along with Vault & EssentialsX. Had to find a new shop plugin and cam across QuickShop.
After setting up a shop and try to sell an item, the following message come across on the backend:

[15:43:33] [Server thread/WARN]: java.lang.NoSuchFieldError: accountHolderFactory
[15:43:33] [Server thread/WARN]: at net.milkbowl.vault.economy.plugins.Economy_Gringotts.getBalance(Economy_Gringotts.java:136)
[15:43:33] [Server thread/WARN]: at net.milkbowl.vault.economy.AbstractEconomy.getBalance(AbstractEconomy.java:20)
[15:43:33] [Server thread/WARN]: at org.maxgamer.quickshop.Economy.Economy_Vault.getBalance(Economy_Vault.java:241)
[15:43:33] [Server thread/WARN]: at org.maxgamer.quickshop.Economy.Economy.getBalance(Economy.java:85)
[15:43:33] [Server thread/WARN]: at org.maxgamer.quickshop.Listeners.PlayerListener.onClick(PlayerListener.java:177)
[15:43:33] [Server thread/WARN]: at sun.reflect.GeneratedMethodAccessor64.invoke(Unknown Source)
[15:43:33] [Server thread/WARN]: at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
[15:43:33] [Server thread/WARN]: at java.lang.reflect.Method.invoke(Unknown Source)
[15:43:33] [Server thread/WARN]: at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:316)
[15:43:33] [Server thread/WARN]: at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
[15:43:33] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:529)
[15:43:33] [Server thread/WARN]: at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:514)
[15:43:33] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_15_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:442)
[15:43:33] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_15_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:409)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.PlayerInteractManager.a(PlayerInteractManager.java:137)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.PlayerConnection.a(PlayerConnection.java:1197)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.PacketPlayInBlockDig.a(SourceFile:40)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.PacketPlayInBlockDig.a(SourceFile:10)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:19)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.TickTask.run(SourceFile:18)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeTask(SourceFile:144)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeNext(SourceFile:118)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.MinecraftServer.aZ(MinecraftServer.java:917)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.MinecraftServer.executeNext(MinecraftServer.java:910)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.awaitTasks(SourceFile:127)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.MinecraftServer.sleepForTick(MinecraftServer.java:894)
[15:43:33] [Server thread/WARN]: at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:827)
[15:43:33] [Server thread/WARN]: at java.lang.Thread.run(Unknown Source)
[15:43:33] [Server thread/WARN]: This seems not QuickShop fault, you should contact with your economy plugin author. (Gringotts)�[m

Any ideas

Support for CustomItems

[Tracking] Please add support for CustomItems to be used as materials in Gringotts.

CustomItems API Reference: https://github.com/jojodmo/CustomItems/wiki/Developer-API
CustomItems API Class: https://github.com/jojodmo/CustomItems/blob/master/API/CustomItemsAPI.java

Thank you!

Vault sign not working

Hello, i've tried to create an [vault] sign but it give me an error. I've tried with versions 2.9 to 2.11.2-SNAPSHOT-rf77e523.

[15:23:17 ERROR]: Could not pass event SignChangeEvent to Gringotts v2.11.1-SNAPSHOT java.lang.NoSuchMethodError: org.bukkit.block.Block.getBlockData()Lorg/bukkit/block/data/BlockData; at org.gestern.gringotts.Util.chestBlock(Util.java:99) ~[?:?] at org.gestern.gringotts.event.AccountListener.onSignChange(AccountListener.java:58) ~[?:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor1.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:61) ~[EventExecutor.class:11643ae] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:66) ~[RegisteredListener.class:11643ae] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:484) [SimplePluginManager.class:11643ae] at net.minecraft.network.NetHandlerPlayServer.func_147343_a(NetHandlerPlayServer.java:2375) [pa.class:?] at net.minecraft.network.play.client.CPacketUpdateSign.func_148833_a(SourceFile:44) [lx.class:?] at net.minecraft.network.play.client.CPacketUpdateSign.func_148833_a(SourceFile:10) [lx.class:?] at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) [hv$1.class:?] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_242] at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_242] at net.minecraft.util.Util.func_181617_a(SourceFile:46) [h.class:?] at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:848) [MinecraftServer.class:?] at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:466) [nz.class:?] at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:786) [MinecraftServer.class:?] at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:630) [MinecraftServer.class:?] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242]

I've seen that it's an old issue but i haven't find a solution...

Update support of WorldGuard and WorldEdit to their latest version

Disable Crafting - Option [suggestion]

This option would dissallow players to craft/smelt items which are currencies <- but not by material but whole item's meta.
So eg. if the material has its displayname check also this and allow crafting from standard materials.

Trouble with documentation

Trying to make sure I'm not having a sell caused issue, but the resources to check seem to be broken on github. Referring to the

"Commands

See Usage."

On the frontpage directing to nowhere. As well as there is no wiki page to go to in the link either.

"Problems? Questions?

Have a look at the Wiki. You're welcome to improve it, too!"

That being said, I am currently experiencing an issue I don't understand, when my players are trying to send each other money. And they have emeralds in a vault or even in hand, they can't seem to pay. Every time they enter an amount to send someone it seem to change it to 0

For example using /money pay (quantity) (user)
the server returns "Sent 0 emeralds" every time. No money is deducted from the players vault or inventory. And the recipient gets no emeralds either. Super bizarre, thankfully my players have been working around it and doing in person transactions. But I'm sure this would make things easier if we could pinpoint why players can't send each other money

Add statistics.csv file for the economy progress of your server.

Gringotts Performance?

Gringotts::Task: org.gestern.gringotts.GringottsAccount$$Lambda$3637/723005830 (Single)count(774) total(13.68% 3.434s, 28.74% of tick)

This is using the latest pre-release version and on Paper 1.15.2

Update plugin.yml so can support soft dependencies

/money pay typo

You currently have syntax showing /money pay
but the right way to pay is actually /money pay

This confuses players since its opposite

Latest Version

Add support for tab complete command system

Towny / Economy issue - Says cannot afford

THIS is a crosspost with - TownyAdvanced/Towny#3870
Is anyone else having an issue of setting a plot type with it saying "You can't afford this"

I'm using Gringotts with Vault.

The weird part is that.. everything else in the towny economy works.

[NO ERRORS ON CONSOLE]
1.15.2

--

Gringotts Version 2.11.2
Towny latest

Gringotts disables itself without Towny installed

Running latest snapshot with Paper-193. I've previously run it with a towny server, now I've removed Towny. On server load, Gringotts disables itself saying there is something missing related to Towny. Here's the error from my log:

[18:29:31] [Server thread/ERROR]: [org.bukkit.craftbukkit.v1_15_R1.CraftServer] com/palmergames/bukkit/towny/exceptions/NotRegisteredException initializing Gringotts v2.11.2-SNAPSHOT (Is it up to date?) java.lang.NoClassDefFoundError: com/palmergames/bukkit/towny/exceptions/NotRegisteredException at org.gestern.gringotts.Gringotts.onLoad(Gringotts.java:181) ~[?:?] at org.bukkit.craftbukkit.v1_15_R1.CraftServer.loadPlugins(CraftServer.java:363) ~[patched_1.15.2.jar:git-Paper-193] at net.minecraft.server.v1_15_R1.DedicatedServer.init(DedicatedServer.java:234) ~[patched_1.15.2.jar:git-Paper-193] at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:908) ~[patched_1.15.2.jar:git-Paper-193] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_211] Caused by: java.lang.ClassNotFoundException: com.palmergames.bukkit.towny.exceptions.NotRegisteredException at java.net.URLClassLoader.findClass(URLClassLoader.java:382) ~[?:1.8.0_211] at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:171) ~[patched_1.15.2.jar:git-Paper-193] at org.bukkit.plugin.java.PluginClassLoader.findClass(PluginClassLoader.java:100) ~[patched_1.15.2.jar:git-Paper-193] at java.lang.ClassLoader.loadClass(ClassLoader.java:424) ~[?:1.8.0_211] at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ~[?:1.8.0_211] ... 5 more

Will try deleting my database and reloading.