nikosgram/gringotts-towny

Gringotts-Towny allows the creation of Gringotts vaults and account for Towny's nations and towns.

gringotts-towny's Issues

Plugin is not installing

Gringotts, Towny and Vault plugins all work as expected, but gringotts_towny refuses to install. MC version is 1.19.4 and all plugins are at their most up-to-date versions.

This is the error coming up on dashboard when starting the server:

[modernpluginloadingstrategy] could not load plugin 'gringotts-towny-2.12.4-snapshot (2).jar' in folder 'plugins' org.bukkit.plugin.invalidpluginexception: java.lang.noclassdeffounderror: org/gestern/gringotts/api/dependency/dependency at io.papermc.paper.plugin.provider.type.spigot.spigotpluginprovider.createinstance(spigotpluginprovider.java:127) ~[paper-1.19.4.jar:git-paper-514] at io.papermc.paper.plugin.provider.type.spigot.spigotpluginprovider.createinstance(spigotpluginprovider.java:35) ~[paper-1.19.4.jar:git-paper-514] at io.papermc.paper.plugin.entrypoint.strategy.modernpluginloadingstrategy.loadproviders(modernpluginloadingstrategy.java:150) ~[paper-1.19.4.jar:git-paper-514] at io.papermc.paper.plugin.storage.simpleproviderstorage.enter(simpleproviderstorage.java:35) ~[paper-1.19.4.jar:git-paper-514] at io.papermc.paper.plugin.entrypoint.launchentrypointhandler.enter(launchentrypointhandler.java:36) ~[paper-1.19.4.jar:git-paper-514] at org.bukkit.craftbukkit.v1_19_r3.craftserver.loadplugins(craftserver.java:423) ~[paper-1.19.4.jar:git-paper-514] at net.minecraft.server.dedicated.dedicatedserver.initserver(dedicatedserver.java:273) ~[paper-1.19.4.jar:git-paper-514] at net.minecraft.server.minecraftserver.runserver(minecraftserver.java:1104) ~[paper-1.19.4.jar:git-paper-514] at net.minecraft.server.minecraftserver.lambda$spin$0(minecraftserver.java:320) ~[paper-1.19.4.jar:git-paper-514] at java.lang.thread.run(thread.java:833) ~[?:?]

Towny Vault

For some reason the Towny Vault doesn't work. I've placed the sign all over the chest with just [town vault] and i've also tried [towny vault]. Neither seem to work at all, However the normal [vault] does work.

Unusable since 1.12.5

Towny does not retrieve the correct amount a town owns from Gringotts.

Ex: 5000 Coins are in the vault of the town Berlin
If you do any Towny action that requires the town to have money it gets blocked and says it would be bankrupt. But when I run /mad balance town:Berlin it outputs the correct amount.

Same goes for /town Berlin which shows Bank: 0 in their stats.

Plugins

Paper Plugins: (2):

• BKCommonLib
• EconomyShopGUI-Premium

Bukkit Plugins: (67):

• AppleCoreSpigot
• Chunky
• Citizens
• CitizensGUI
• ClientDetector
• CrossplatForms
• dDiscordBot
• Denizen
• Depenizen
• DiscordSRV
• DropEdit2
• dynmap
• Dynmap-Towny
• Dynmap-WorldGuard
• Essentials
• EssentialsChat
• EssentialsGeoIP
• EssentialsSpawn
• ExtraContexts
• FallingSnow
• floodgate
• GeyserHacks
• Gringotts
• GringottsTowny
• ImageFrame
• InteractionVisualizer
• InteractiveChat
• InteractiveChatDiscordSrvAddon
• JShader
• LuckPerms
• MultiLang
• Multiverse-Core
• Multiverse-NetherPortals
• Multiverse-Portals
• Multiverse-SignPortals
• NBTAPI
• Pl-Hide-Pro
• PlaceholderAPI
• PowerBoard
• ProtocolLib
• PurpurExtras
• qsaddon-discordsrv
• qsaddon-discount
• qsaddon-displaycontrol
• qscompat-towny
• qscompat-worldedit
• qscompat-worldguard
• qssuite-limited
• QuickShop-Hikari
• RocketPlaceholders
• SiegeWar
• spark
• StreamingDrops
• TCHangRail
• Themis
• Towny
• TownyCamps
• TownyCaptureSites
• TownyHistories
• TownyMenus
• TownyResources
• TownyWayPointTravel
• Train_Carts
• Vault
• WorldEdit
• WorldGuard
• WorldGuard-Towny

/plugins/Gringotts/config.yml

# for details on configuration, see https://github.com/MinecraftWars/Gringotts/blob/master/doc/configuration.md

# supported languages: "custom" (default, english), "de" (german), "fr" (french), and "pt-BR" (brazilian portuguese).
language: de

# regex that create a vault if matches with a sign
# subpattern 1 denotes the type of the vault.
vault_pattern: '[^\[]*\[(\w*) ?vault\]'

# If this is set to true, when the user receives an amount of money
# exceeding the inventory capacity, drop items that didn't fit.
drop-overflowing-item: false

# currency name and value config
currency:
  # currency name to use in messages
  name:
    singular: Fuchstaler
    plural: Fuchstaler

  # number of decimal digits supported by currency value (0 for whole numbers only)
  digits: 2

  # Display account balances with individual denomination names
  named-denominations: true

  # value of individual denominations. default: emerald: 1, emerald block: 9
  denominations:
    - material: iron_nugget
      value: 1
      unit-name: "&f&r"
      unit-name-plural: "&f&r"
      displayname: "&r&7&lEiserner Fuchstaler"
      damage: 13
      custom_model_data: 10
      lore:
        - "&f&lWert: &7&l1 Fuchstaler"
        - "&c&lNICHT CRAFTEN"
    - material: gold_nugget
      value: 100
      unit-name: "&f&r"
      unit-name-plural: "&f&r"
      displayname: "&r&l&6Golderner Fuchstaler"
      damage: 4
      custom_model_data: 10
      lore:
        - "&f&lWert: &7&l100 Fuchstaler"
        - "&c&lNICHT CRAFTEN"
    - material: emerald
      value: 1000
      unit-name: "&f&r"
      unit-name-plural: "&f&r"
      displayname: "&r&l&2Grüner Fuchstaler"
      damage: 11
      custom_model_data: 10
      lore:
        - "&f&lWert: &7&l1000 Fuchstaler"
        - "&c&lNICHT CRAFTEN"
    - material: copper_ingot
      value: 0.01
      unit-name: "&f&r"
      unit-name-plural: "&f&r"
      displayname: "&r&l&cKupferner Fuchstaler"
      damage: 11
      custom_model_data: 10
      lore:
        - "&f&lWert: &7&l0,01 Fuchstaler"
        - "&c&lNICHT CRAFTEN"

# tax on /money pay transactions
transactiontax:
  flat: 0.0
  rate: 0.0

# balance to start an account with (purely virtual)
startingbalance:
  player: 500

# globally (dis)allow use of vault types
usevault:
  container: true
  enderchest: true
  # if true, denomination items located in shulker boxes, in the above enabled inventories, will be included to the denomination finding process
  include-shulker-boxes: true

# whether money/balance commands show vault and inventory balance separately
balance:
  show-vault: true
  show-inventory: true
  show-enderchest: true

/plugins/GringottsTowny/config.yml

# supported languages: "custom" (default, english), "de" (german), "fr" (french), and "pt-BR" (brazilian portuguese).
language: de

# changes the required sign name for the creation of town/nation vaults
# Example: [town vault]
town_sign_vault_name: 'town'
nation_sign_vault_name: 'nation'

# Prevents players from creating a vault outside a town if set to true
vaults_only_in_towns: false

# Maximum number of vaults a town can own, set to -1 for infinite number of vaults
max_town_vaults: -1
# Maximum number of vaults a nation can own, set to -1 for infinite number of vaults
max_nation_vaults: -1

# balance to start an account with (purely virtual)
town_start_balance: 1500
nation_start_balance: 15000

NOTE

I am currently using 1.12.4 together with gringotts 1.12.5 because of this issue. Which also forced me to enable the legacy plugin loading order or GringottsTowny would be disabled.

Using 1.12.5 is also not perfect as described here:

• nikosgram/gringotts#161

Gringotts-Towny takes my gold but doesnt depoist it with /t depoist

2022-10-16.22-42-12.mp4

[Plugin Incompatible] Quickshop-Hikari

What is the problem?

When Mayors or Kings create Nation or Town shops with Ghost-chu/QuickShop-Hikari nothing can be bought or sold there and only an error message appears:

Screenshot

Translated:

Sorry,but an internal Error happened while processing the transaction. The transaction was cancelled.
Please contact the Server Admin if this keeps happening.

Also the following Error appears in the console:

[15:56:40 ERROR]: [QuickShop-Hikari] EconomyTransaction Failed, last error: Failed to deposit 500.0 to player f9b4d706-b688-3636-ace1-af8f07dca545 account. LastError: Gringotts: FAILURE - Unbekannter Fehler.

Besides this when enabling taxes-to-town it does not work which I think is probably the same cause like #4, though I'm not sure.

Expected Behavior

Should be obvious that it makes the transaction successfully without giving out any errors.

Unrelated

Personal Note

It's still a great plugin! Keep doing the good work! 👍🏻

Support for 1.18.2?

When running the plugin it /seems/ to work fine, but i don't think any transactions can occur since it throws this error in my server console.

[30.01 02:37:14] [Server] [INFO] LuckiestPup issued server command: /town claim [30.01 02:37:14] [Server] [WARN] [Towny]: Plugin Towny v0.100.0.20 generated an exception while executing task 14548 [30.01 02:37:14] [Server] java.lang.IllegalStateExceptionCalculateStartBalanceEvent cannot be triggered asynchronously from another thread. [30.01 02:37:14] [Server] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:572) ~[arclight-1.18.2-1.0.10-033f7507.jar%2372!/:arclight-1.18.2-1.0.10-033f7507] [30.01 02:37:14] [Server] at org.gestern.gringotts.data.EBeanDAO.storeAccount(EBeanDAO.java:128) ~[?:?] [30.01 02:37:14] [Server] at org.gestern.gringotts.Accounting.getAccount(Accounting.java:23) ~[?:?] [30.01 02:37:14] [Server] at org.gestern.gringotts.api.impl.GringottsEco.account(GringottsEco.java:42) ~[?:?] [30.01 02:37:14] [Server] at org.gestern.gringotts.api.impl.VaultConnector.hasAccount(VaultConnector.java:71) ~[?:?] [30.01 02:37:14] [Server] at com.palmergames.bukkit.towny.object.economy.adapter.VaultEconomyAdapter.hasAccount(VaultEconomyAdapter.java:28) ~[?:?] [30.01 02:37:14] [Server] at com.palmergames.bukkit.towny.TownyEconomyHandler.checkNewAccount(TownyEconomyHandler.java:324) ~[?:?] [30.01 02:37:14] [Server] at com.palmergames.bukkit.towny.TownyEconomyHandler.getBalance(TownyEconomyHandler.java:196) ~[?:?] [30.01 02:37:14] [Server] at com.palmergames.bukkit.towny.TownyEconomyHandler.hasEnough(TownyEconomyHandler.java:209) ~[?:?] [30.01 02:37:14] [Server] at com.palmergames.bukkit.towny.object.economy.Account.canPayFromHoldings(Account.java:198) ~[?:?] [30.01 02:37:14] [Server] at com.palmergames.bukkit.towny.object.economy.BankAccount.canPayFromHoldings(BankAccount.java:91) ~[?:?] [30.01 02:37:14] [Server] at com.palmergames.bukkit.towny.command.TownCommand.lambda$parseTownClaimCommand$24(TownCommand.java:3617) ~[?:?] [30.01 02:37:14] [Server] at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftTask.run(CraftTask.java:82) ~[arclight-1.18.2-1.0.10-033f7507.jar%2372!/:arclight-1.18.2-1.0.10-033f7507] [30.01 02:37:14] [Server] at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54) [arclight-1.18.2-1.0.10-033f7507.jar%2372!/:arclight-1.18.2-1.0.10-033f7507] [30.01 02:37:14] [Server] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?] [30.01 02:37:14] [Server] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?] [30.01 02:37:14] [Server] at java.lang.Thread.run(Thread.java:833) [?:?]

Error when loading plugin

[19:37:08] [Server thread/ERROR]: [ModernPluginLoadingStrategy] Could not load plugin 'gringotts-towny-2.12.4-SNAPSHOT.jar' in folder 'plugins'
org.bukkit.plugin.InvalidPluginException: java.lang.NoClassDefFoundError: org/gestern/gringotts/api/dependency/Dependency
at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:127) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:35) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
at io.papermc.paper.plugin.entrypoint.strategy.ModernPluginLoadingStrategy.loadProviders(ModernPluginLoadingStrategy.java:150) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:35) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
at io.papermc.paper.plugin.entrypoint.LaunchEntryPointHandler.enter(LaunchEntryPointHandler.java:36) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
at org.bukkit.craftbukkit.v1_19_R2.CraftServer.loadPlugins(CraftServer.java:428) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:275) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1103) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:318) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.NoClassDefFoundError: org/gestern/gringotts/api/dependency/Dependency
at java.lang.Class.forName0(Native Method) ~[?:?]
at java.lang.Class.forName(Class.java:467) ~[?:?]
at org.bukkit.plugin.java.PluginClassLoader.(PluginClassLoader.java:78) ~[pufferfish-api-1.19.3-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:123) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
... 9 more
Caused by: java.lang.ClassNotFoundException: org.gestern.gringotts.api.dependency.Dependency
at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:185) ~[pufferfish-api-1.19.3-R0.1-SNAPSHOT.jar:?]
at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:152) ~[pufferfish-api-1.19.3-R0.1-SNAPSHOT.jar:?]
at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
at java.lang.Class.forName0(Native Method) ~[?:?]
at java.lang.Class.forName(Class.java:467) ~[?:?]
at org.bukkit.plugin.java.PluginClassLoader.(PluginClassLoader.java:78) ~[pufferfish-api-1.19.3-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.provider.type.spigot.SpigotPluginProvider.createInstance(SpigotPluginProvider.java:123) ~[pufferfish-1.19.3.jar:git-Pufferfish-61]
... 9 more