nimiq/network

network

network's Issues

Add caching of unrelayed transactions

See nimiq/hub#368

Warn on wrongly set system clock

If the user's system clock is wrongly set, blocks can be rejected and the consensus fails to be established.
The miner ui detects this error and shows a warning.
Similarly, the network iframe should fire an event that then get's handled by the Network client or Safe + Hub to display a warning.
The code used in the miner to detect a misconfigured system clock on consensus-established and peers-changed events is as follows:

    _checkComputerClock() {
        // if computer clock deviates too much from network time show a warning. To recover from this state, user has to
        // reload as the netword time offset does not get recalculated.
        if (this.$.network.peerCount < 3 // ask at least 3 peers for their time
            || Math.abs(this.$.network.time.now() - Date.now()) < Nimiq.Block.TIMESTAMP_DRIFT_MAX * 1000) return;
        this.ui.clockMisconfigured();
        this.stopMining();
    }

I consider this quite an important issue (and therefore labeled it as bug) as it prevents the user from doing anything meaningful in the Safe / Hub without giving him any clue.

Cross-tab singleton connection

Add some communication layer between network iFrames that enables us to use the same NanoApi instance for all open tabs.

TBD: Configuration

It would be nice if one deployment of this service would suffice to allow multiple CDNs, networks... in short: config as needed by the user of networkClient.

Suggestions:

• Introduce config files and own entry point for each config
• OR pass config via url parameters

Problems to consider: core API might change for different versions.

sendTrasaction function signature for serializedTx

I think the sendTransaction method can also be invoked with a serialized transaction, right?
This is currenlty not reflected in the function signature / type of sendTransaction.