Giter Site home page Giter Site logo

Comments (10)

chaehb avatar chaehb commented on May 24, 2024

I have struggled the same issue after erlang/otp 17.1.

from ranch.

essen avatar essen commented on May 24, 2024

If the listening socket got closed, we need to reopen it, therefore we crash here so the error bubbles up the supervision tree until the code that reopens the socket.

The relevant mailing list discussion can be found at http://erlang.org/pipermail/erlang-questions/2014-October/081183.html

This code should not be triggered on shutdown as these processes are brutally killed.

The issue comes from the application start/stop order. If you make Ranch depend on SSL, everything works correctly. What I am unsure of is what has changed that makes code that worked before 17.1 to suddenly stop working, though.

from ranch.

vicbaz avatar vicbaz commented on May 24, 2024

Thank you for the clarification. I think this issue can be closed.

from ranch.

essen avatar essen commented on May 24, 2024

I will keep it open for now as I need to investigate further, so this will be my reminder. Thanks for the report!

from ranch.

MarkNijhof avatar MarkNijhof commented on May 24, 2024

Hi @essen ,
How do I make Ranch depend on SSL to it prevents the crash on stop?

from ranch.

vicbaz avatar vicbaz commented on May 24, 2024

sed is your friend.

I do this:

include erlang.mk

deps::
    sed -i 's/\(stdlib\)$$/\1,\n\t\tssl/' deps/ranch/ebin/ranch.app

from ranch.

MarkNijhof avatar MarkNijhof commented on May 24, 2024

Awesome, thanks for that tip

from ranch.

justnoxx avatar justnoxx commented on May 24, 2024

Hi, after erlang upgrade to r18 I have this issue again. Proposed solution with sed has no effect.

from ranch.

justnoxx avatar justnoxx commented on May 24, 2024

Fixed sed command:

sed -i 's/\(stdlib\)/\1,\t\tssl/' deps/ranch/ebin/ranch.app

from ranch.

essen avatar essen commented on May 24, 2024

So this is fixed in my local copy. Push later and will be in 1.3.0. Closing, thanks!

from ranch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.