ninesstack/sidecar

Gossip-based service discovery. Docker native, but supports non-container discovery, too.

sidecar's Issues

Docker image gonitro/envoyproxy misses tag "latest"

Hi.

Regarding the section "Envoy Proxy Support" of the README, I cannot find the tag latest on hub.docker.com. These are the ones available:

1.6.0-1eeb947
1.6.0-b977e7e
1.6.0-d14e841
1.7.0-084b5d6-tracing
1.7.0-27960f3
1.7.0-27960f3-tracing

Trying the command in the README, this is the error:

docker run -i -t --net host --cap-add NET_ADMIN gonitro/envoyproxy:latest
Unable to find image 'gonitro/envoyproxy:latest' locally
docker: Error response from daemon: manifest for gonitro/envoyproxy:latest not found.

gossip protocol port 7946

Hi

Just tried sidecar on a docker swarm cluster, but it failed because it's trying to use port 7946, the same used by swarm cluster.

Anything I can do to run both?

Improvment: recognize docker service labels

Hi.

Sidecar seems to not recognize docker service labels, but only container labels. Not really an issue, but would be nice to support service labels too

Notes on docker swarm

Hey.

I'm trying to figure out if I can/how I can use sidecar with docker swarm

I created a cluster (single host) with 4 services:

• portainer agent
• portainer server
• sidecar
• nginx

Portainer server bind port 9000
nginx bind port 80 and 443

All the services are on the ingress network for two reason:

• first is the design I want to use (all in the ingress network except for envoy binded to the host network)
• second because a limitation of docker (I suppose, do not dig too much in it) where I cannot create a service bound to both ingress and host network

Expected result:

• sidecar recognizes 3 containers, two of them with ports bound
• health check for nginx works

Desiderata:

• sidecar recognizes the containers with the right ports also if the ports are not bound but only exposed or defined by ServicePort var (in this way I can have all the services without ports bound to host to avoid to handle overlapping ports). This is similar to rancher lb where an haproxy container bind to 80 and 443 and forward the requests to the different backend cointainers and none of them has ports bind)

Actual result:

• sidecar cannot retrieve service ports
• if I use this label for checking the service HealthCheckArgs="http://{{ host }}:{{ tcp 80 }}/", host variable retrieves a different IP from the one assigned (in this case it tries to check the service on IP 10.255.0.5 but the service is on IP 10.255.0.10). you can see that in the log below time="2018-09-12T19:29:39Z" level=info msg="Adding health check: HttpGet (ID: 59844989cd37), Args: http://10.255.0.5:-1/",

I could have misunderstood sidecar architecture/swarm functionalities so this probably is not a bug :)

Here are sidecar debug logs

time="2018-09-12T19:29:38Z" level=info msg="Sidecar ------------------------------------------",
time="2018-09-12T19:29:38Z" level=info msg="  * Sidecar:",
time="2018-09-12T19:29:38Z" level=info msg="    * ExcludeIPs: [192.168.168.168]",
time="2018-09-12T19:29:38Z" level=info msg="    * Discovery: [docker]",
time="2018-09-12T19:29:38Z" level=info msg="    * StatsAddr: ",
time="2018-09-12T19:29:38Z" level=info msg="    * PushPullInterval: 20s",
time="2018-09-12T19:29:38Z" level=info msg="    * GossipMessages: 15",
time="2018-09-12T19:29:38Z" level=info msg="    * LoggingFormat: ",
time="2018-09-12T19:29:38Z" level=info msg="    * LoggingLevel: debug",
time="2018-09-12T19:29:38Z" level=info msg="    * DefaultCheckEndpoint: /version",
time="2018-09-12T19:29:38Z" level=info msg="    * Seeds: [127.0.0.1]",
time="2018-09-12T19:29:38Z" level=info msg="    * ClusterName: syshell",
time="2018-09-12T19:29:38Z" level=info msg="    * AdvertiseIP: ",
time="2018-09-12T19:29:38Z" level=info msg="    * BindPort: 7950",
time="2018-09-12T19:29:38Z" level=info msg="  * DockerDiscovery:",
time="2018-09-12T19:29:38Z" level=info msg="    * DockerURL: unix:///var/run/docker.sock",
time="2018-09-12T19:29:38Z" level=info msg="  * StaticDiscovery:",
time="2018-09-12T19:29:38Z" level=info msg="    * ConfigFile: static.json",
time="2018-09-12T19:29:38Z" level=info msg="  * Services:",
time="2018-09-12T19:29:38Z" level=info msg="    * NameMatch: ",
time="2018-09-12T19:29:38Z" level=info msg="    * ServiceNamer: docker_label",
time="2018-09-12T19:29:38Z" level=info msg="    * NameLabel: ServiceName",
time="2018-09-12T19:29:38Z" level=info msg="  * HAproxy:",
time="2018-09-12T19:29:38Z" level=info msg="    * ReloadCmd: ",
time="2018-09-12T19:29:38Z" level=info msg="    * VerifyCmd: ",
time="2018-09-12T19:29:38Z" level=info msg="    * BindIP: 192.168.168.168",
time="2018-09-12T19:29:38Z" level=info msg="    * TemplateFile: views/haproxy.cfg",
time="2018-09-12T19:29:38Z" level=info msg="    * ConfigFile: /etc/haproxy.cfg",
time="2018-09-12T19:29:38Z" level=info msg="    * PidFile: /var/run/haproxy.pid",
time="2018-09-12T19:29:38Z" level=info msg="    * Disable: false",
time="2018-09-12T19:29:38Z" level=info msg="    * User: haproxy",
time="2018-09-12T19:29:38Z" level=info msg="    * Group: haproxy",
time="2018-09-12T19:29:38Z" level=info msg="    * UseHostnames: false",
time="2018-09-12T19:29:38Z" level=info msg="  * Listeners:",
time="2018-09-12T19:29:38Z" level=info msg="    * Urls: []",
time="2018-09-12T19:29:38Z" level=info msg=--------------------------------------------------,
time="2018-09-12T19:29:38Z" level=debug msg="NodeMeta(): 512",
time="2018-09-12T19:29:38Z" level=debug msg="NotifyJoin(): c0ab1194b32f {\"ClusterName\":\"syshell\",\"State\":\"Running\"}",
time="2018-09-12T19:29:38Z" level=debug msg="memberlist: Initiating push/pull sync with: 127.0.0.1:7950",
time="2018-09-12T19:29:38Z" level=debug msg="LocalState(): %!b(bool=true)",
time="2018-09-12T19:29:38Z" level=debug msg="memberlist: Stream connection from=127.0.0.1:56876",
time="2018-09-12T19:29:38Z" level=debug msg="LocalState(): %!b(bool=true)",
time="2018-09-12T19:29:38Z" level=debug msg="MergeRemoteState(): {\"Servers\":{},\"LastChanged\":\"1970-01-01T00:00:00Z\",\"ClusterName\":\"\",\"Hostname\":\"c0ab1194b32f\"} true",
time="2018-09-12T19:29:38Z" level=debug msg="Merging state: Services ------------------------------\n",
time="2018-09-12T19:29:38Z" level=debug msg="MergeRemoteState(): {\"Servers\":{},\"LastChanged\":\"1970-01-01T00:00:00Z\",\"ClusterName\":\"\",\"Hostname\":\"c0ab1194b32f\"} true",
time="2018-09-12T19:29:38Z" level=debug msg="Merging state: Services ------------------------------\n",
time="2018-09-12T19:29:38Z" level=info msg="Setting up signal handlers",
time="2018-09-12T19:29:38Z" level=debug msg="Member: c0ab1194b32f 10.255.0.5",
time="2018-09-12T19:29:38Z" level=debug msg="Meta: {\"ClusterName\":\"syshell\",\"State\":\"Running\"}",
time="2018-09-12T19:29:38Z" level=debug msg="AddListener(): added HAproxy, new count 1",
time="2018-09-12T19:29:38Z" level=debug msg="Services ------------------------------\n\nCluster Hosts -------------------------\n    c0ab1194b32f\n---------------------------------------",
time="2018-09-12T19:29:38Z" level=debug msg="Event: &docker.APIEvents{Action:\"start\", Type:\"container\", Actor:docker.APIActor{ID:\"c0ab1194b32f60b2e73c0dfdda666cd10d6ad7aac490c7e3d5a19c3e2f108b33\", Attributes:map[string]string{\"com.docker.swarm.service.name\":\"sidecar\", \"image\":\"gonitro/sidecar:f56be36@sha256:195709bed8256d705f6c0143826401c0c3620bfb580873ddc19c82c77c6c9e40\", \"com.docker.swarm.service.id\":\"2za4vy219t6lhb0xaex305no3\", \"com.docker.swarm.task\":\"\", \"com.docker.swarm.task.id\":\"1yfl8rrxwbxordriacufb3m86\", \"com.docker.swarm.task.name\":\"sidecar.1.1yfl8rrxwbxordriacufb3m86\", \"name\":\"sidecar.1.1yfl8rrxwbxordriacufb3m86\", \"SidecarDiscover\":\"false\", \"com.docker.swarm.node.id\":\"lp7uebppc477us10ec3fkxo82\"}}, Status:\"start\", ID:\"c0ab1194b32f60b2e73c0dfdda666cd10d6ad7aac490c7e3d5a19c3e2f108b33\", From:\"gonitro/sidecar:f56be36@sha256:195709bed8256d705f6c0143826401c0c3620bfb580873ddc19c82c77c6c9e40\", Time:1536780578, TimeNano:1536780578497886751}\n",
time="2018-09-12T19:29:38Z" level=debug msg="GetBroadcasts(): 3 1263",
time="2018-09-12T19:29:38Z" level=debug msg="GetBroadcasts(): 3 1263",
time="2018-09-12T19:29:38Z" level=debug msg="GetBroadcasts(): 3 1263",
time="2018-09-12T19:29:38Z" level=debug msg="GetBroadcasts(): 3 1263",
time="2018-09-12T19:29:38Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:38Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:39Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:39Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:39Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:39Z" level=debug msg="Found container with no 'ServiceName' label: 59844989cd37932f999f8e5085c0d77b37813698212b005daed5c1b8c6bcca01 (/nginx.1.nsocaf2zihu8vq7d6ajkg5n1r), returning 'nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3'",
time="2018-09-12T19:29:39Z" level=debug msg="Found container with no 'ServiceName' label: b6932c9d02ab3abea93488d2ef53dcaae6cafaf73236946db9451f74e8714eac (/portainer_portainer.1.ssku2iw886ilhq4d7btlvuulk), returning 'portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910'",
time="2018-09-12T19:29:39Z" level=debug msg="Found container with no 'ServiceName' label: d8fd8f63de007c2756f0a271b01ac84deaa6ca84e7a9fc4f8f4c46112fe9a482 (/portainer_agent.lp7uebppc477us10ec3fkxo82.af26lbc28lryaut4d7hvxx7gv), returning 'portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be'",
time="2018-09-12T19:29:39Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:39Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:39Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:39Z" level=warning msg="Unable to find ServicePort 80 for service 59844989cd37",
time="2018-09-12T19:29:39Z" level=info msg="Adding health check: HttpGet (ID: 59844989cd37), Args: http://10.255.0.5:-1/",
time="2018-09-12T19:29:39Z" level=warning msg="Adding check for service portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910 (id: b6932c9d02ab) failed. Got check type: , check args: .",
time="2018-09-12T19:29:39Z" level=warning msg="Using default check for service portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910 (id: b6932c9d02ab).",
time="2018-09-12T19:29:39Z" level=info msg="Adding health check:  (ID: b6932c9d02ab), Args: ",
time="2018-09-12T19:29:39Z" level=warning msg="Adding check for service portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be (id: d8fd8f63de00) failed. Got check type: , check args: .",
time="2018-09-12T19:29:39Z" level=warning msg="Using default check for service portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be (id: d8fd8f63de00).",
time="2018-09-12T19:29:39Z" level=info msg="Adding health check:  (ID: d8fd8f63de00), Args: ",
time="2018-09-12T19:29:40Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:40Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:40Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:40Z" level=debug msg="Notifying listeners of change at 2018-09-12 19:29:39.503168671 +0000 UTC",
time="2018-09-12T19:29:40Z" level=debug msg="Notifying listeners of change at 2018-09-12 19:29:39.503230986 +0000 UTC",
time="2018-09-12T19:29:40Z" level=debug msg="Notifying listeners of change at 2018-09-12 19:29:39.503259669 +0000 UTC",
time="2018-09-12T19:29:40Z" level=info msg="State change event from c0ab1194b32f",
time="2018-09-12T19:29:40Z" level=debug msg="Member: c0ab1194b32f 10.255.0.5",
time="2018-09-12T19:29:40Z" level=debug msg="Meta: {\"ClusterName\":\"syshell\",\"State\":\"Running\"}",
time="2018-09-12T19:29:40Z" level=debug msg="Found container with no 'ServiceName' label: 59844989cd37932f999f8e5085c0d77b37813698212b005daed5c1b8c6bcca01 (/nginx.1.nsocaf2zihu8vq7d6ajkg5n1r), returning 'nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3'",
time="2018-09-12T19:29:40Z" level=debug msg="Found container with no 'ServiceName' label: b6932c9d02ab3abea93488d2ef53dcaae6cafaf73236946db9451f74e8714eac (/portainer_portainer.1.ssku2iw886ilhq4d7btlvuulk), returning 'portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910'",
time="2018-09-12T19:29:40Z" level=debug msg="Found container with no 'ServiceName' label: d8fd8f63de007c2756f0a271b01ac84deaa6ca84e7a9fc4f8f4c46112fe9a482 (/portainer_agent.lp7uebppc477us10ec3fkxo82.af26lbc28lryaut4d7hvxx7gv), returning 'portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be'",
time="2018-09-12T19:29:40Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:40Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:40Z" level=debug msg="Starting to broadcast",
time="2018-09-12T19:29:40Z" level=debug msg="Completing broadcast",
time="2018-09-12T19:29:40Z" level=debug msg="Services ------------------------------\n  c0ab1194b32f: (1.0 sec ago)\n      59844989cd37 nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3                 nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3  1.0 sec ago     Unhealthy\n      d8fd8f63de00 portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be                 portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be  1.0 sec ago     Alive    \n      b6932c9d02ab portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910                 portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910  1.0 sec ago     Alive    \n\n\nCluster Hosts -------------------------\n    c0ab1194b32f\n---------------------------------------",
time="2018-09-12T19:29:40Z" level=info msg="State change event from c0ab1194b32f",
time="2018-09-12T19:29:40Z" level=info msg="State change event from c0ab1194b32f",
time="2018-09-12T19:29:40Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:41Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:41Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:41Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:41Z" level=debug msg="Running checks",
time="2018-09-12T19:29:41Z" level=debug msg="Error executing check, status UNKNOWN: (id 59844989cd37)",
time="2018-09-12T19:29:41Z" level=debug msg="Found container with no 'ServiceName' label: 59844989cd37932f999f8e5085c0d77b37813698212b005daed5c1b8c6bcca01 (/nginx.1.nsocaf2zihu8vq7d6ajkg5n1r), returning 'nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3'",
time="2018-09-12T19:29:41Z" level=debug msg="Found container with no 'ServiceName' label: b6932c9d02ab3abea93488d2ef53dcaae6cafaf73236946db9451f74e8714eac (/portainer_portainer.1.ssku2iw886ilhq4d7btlvuulk), returning 'portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910'",
time="2018-09-12T19:29:41Z" level=debug msg="Found container with no 'ServiceName' label: d8fd8f63de007c2756f0a271b01ac84deaa6ca84e7a9fc4f8f4c46112fe9a482 (/portainer_agent.lp7uebppc477us10ec3fkxo82.af26lbc28lryaut4d7hvxx7gv), returning 'portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be'",
time="2018-09-12T19:29:41Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:41Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:41Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:41Z" level=debug msg="Sending broadcast 3 msgs 353 1st length",
time="2018-09-12T19:29:41Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:42Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:42Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:42Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:42Z" level=debug msg="Found container with no 'ServiceName' label: 59844989cd37932f999f8e5085c0d77b37813698212b005daed5c1b8c6bcca01 (/nginx.1.nsocaf2zihu8vq7d6ajkg5n1r), returning 'nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3'",
time="2018-09-12T19:29:42Z" level=debug msg="Found container with no 'ServiceName' label: b6932c9d02ab3abea93488d2ef53dcaae6cafaf73236946db9451f74e8714eac (/portainer_portainer.1.ssku2iw886ilhq4d7btlvuulk), returning 'portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910'",
time="2018-09-12T19:29:42Z" level=debug msg="Found container with no 'ServiceName' label: d8fd8f63de007c2756f0a271b01ac84deaa6ca84e7a9fc4f8f4c46112fe9a482 (/portainer_agent.lp7uebppc477us10ec3fkxo82.af26lbc28lryaut4d7hvxx7gv), returning 'portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be'",
time="2018-09-12T19:29:42Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:42Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:42Z" level=debug msg="Member: c0ab1194b32f 10.255.0.5",
time="2018-09-12T19:29:42Z" level=debug msg="Meta: {\"ClusterName\":\"syshell\",\"State\":\"Running\"}",
time="2018-09-12T19:29:42Z" level=debug msg="Services ------------------------------\n  c0ab1194b32f: (1.0 sec ago)\n      59844989cd37 nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3                 nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3  1.0 sec ago     Unhealthy\n      d8fd8f63de00 portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be                 portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be  1.0 sec ago     Alive    \n      b6932c9d02ab portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910                 portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910  1.0 sec ago     Alive    \n\n\nCluster Hosts -------------------------\n    c0ab1194b32f\n---------------------------------------",
time="2018-09-12T19:29:42Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:42Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:43Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:43Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:43Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:43Z" level=debug msg="Found container with no 'ServiceName' label: 59844989cd37932f999f8e5085c0d77b37813698212b005daed5c1b8c6bcca01 (/nginx.1.nsocaf2zihu8vq7d6ajkg5n1r), returning 'nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3'",
time="2018-09-12T19:29:43Z" level=debug msg="Found container with no 'ServiceName' label: b6932c9d02ab3abea93488d2ef53dcaae6cafaf73236946db9451f74e8714eac (/portainer_portainer.1.ssku2iw886ilhq4d7btlvuulk), returning 'portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910'",
time="2018-09-12T19:29:43Z" level=debug msg="Found container with no 'ServiceName' label: d8fd8f63de007c2756f0a271b01ac84deaa6ca84e7a9fc4f8f4c46112fe9a482 (/portainer_agent.lp7uebppc477us10ec3fkxo82.af26lbc28lryaut4d7hvxx7gv), returning 'portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be'",
time="2018-09-12T19:29:43Z" level=debug msg="Event: &docker.APIEvents{Action:\"update\", Type:\"service\", Actor:docker.APIActor{ID:\"2za4vy219t6lhb0xaex305no3\", Attributes:map[string]string{\"updatestate.old\":\"updating\", \"name\":\"sidecar\", \"updatestate.new\":\"completed\"}}, Status:\"service:update\", ID:\"2za4vy219t6lhb0xaex305no3\", From:\"\", Time:1536780583, TimeNano:1536780583628683303}\n",
time="2018-09-12T19:29:43Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:43Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:43Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:44Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:44Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:44Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:44Z" level=debug msg="Running checks",
time="2018-09-12T19:29:44Z" level=debug msg="Error executing check, status UNKNOWN: (id 59844989cd37)",
time="2018-09-12T19:29:44Z" level=debug msg="Found container with no 'ServiceName' label: 59844989cd37932f999f8e5085c0d77b37813698212b005daed5c1b8c6bcca01 (/nginx.1.nsocaf2zihu8vq7d6ajkg5n1r), returning 'nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3'",
time="2018-09-12T19:29:44Z" level=debug msg="Found container with no 'ServiceName' label: b6932c9d02ab3abea93488d2ef53dcaae6cafaf73236946db9451f74e8714eac (/portainer_portainer.1.ssku2iw886ilhq4d7btlvuulk), returning 'portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910'",
time="2018-09-12T19:29:44Z" level=debug msg="Found container with no 'ServiceName' label: d8fd8f63de007c2756f0a271b01ac84deaa6ca84e7a9fc4f8f4c46112fe9a482 (/portainer_agent.lp7uebppc477us10ec3fkxo82.af26lbc28lryaut4d7hvxx7gv), returning 'portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be'",
time="2018-09-12T19:29:44Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:44Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:44Z" level=debug msg="Member: c0ab1194b32f 10.255.0.5",
time="2018-09-12T19:29:44Z" level=debug msg="Meta: {\"ClusterName\":\"syshell\",\"State\":\"Running\"}",
time="2018-09-12T19:29:44Z" level=debug msg="Services ------------------------------\n  c0ab1194b32f: (1.0 sec ago)\n      59844989cd37 nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3                 nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3  1.0 sec ago     Unhealthy\n      d8fd8f63de00 portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be                 portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be  1.0 sec ago     Alive    \n      b6932c9d02ab portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910                 portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910  1.0 sec ago     Alive    \n\n\nCluster Hosts -------------------------\n    c0ab1194b32f\n---------------------------------------",
time="2018-09-12T19:29:44Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:44Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:45Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:45Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:45Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:45Z" level=debug msg="Found container with no 'ServiceName' label: 59844989cd37932f999f8e5085c0d77b37813698212b005daed5c1b8c6bcca01 (/nginx.1.nsocaf2zihu8vq7d6ajkg5n1r), returning 'nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3'",
time="2018-09-12T19:29:45Z" level=debug msg="Found container with no 'ServiceName' label: b6932c9d02ab3abea93488d2ef53dcaae6cafaf73236946db9451f74e8714eac (/portainer_portainer.1.ssku2iw886ilhq4d7btlvuulk), returning 'portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910'",
time="2018-09-12T19:29:45Z" level=debug msg="Found container with no 'ServiceName' label: d8fd8f63de007c2756f0a271b01ac84deaa6ca84e7a9fc4f8f4c46112fe9a482 (/portainer_agent.lp7uebppc477us10ec3fkxo82.af26lbc28lryaut4d7hvxx7gv), returning 'portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be'",
time="2018-09-12T19:29:45Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:45Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:45Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:46Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:46Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:46Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:46Z" level=debug msg="Found container with no 'ServiceName' label: 59844989cd37932f999f8e5085c0d77b37813698212b005daed5c1b8c6bcca01 (/nginx.1.nsocaf2zihu8vq7d6ajkg5n1r), returning 'nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3'",
time="2018-09-12T19:29:46Z" level=debug msg="Found container with no 'ServiceName' label: b6932c9d02ab3abea93488d2ef53dcaae6cafaf73236946db9451f74e8714eac (/portainer_portainer.1.ssku2iw886ilhq4d7btlvuulk), returning 'portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910'",
time="2018-09-12T19:29:46Z" level=debug msg="Found container with no 'ServiceName' label: d8fd8f63de007c2756f0a271b01ac84deaa6ca84e7a9fc4f8f4c46112fe9a482 (/portainer_agent.lp7uebppc477us10ec3fkxo82.af26lbc28lryaut4d7hvxx7gv), returning 'portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be'",
time="2018-09-12T19:29:46Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:46Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:46Z" level=debug msg="Member: c0ab1194b32f 10.255.0.5",
time="2018-09-12T19:29:46Z" level=debug msg="Meta: {\"ClusterName\":\"syshell\",\"State\":\"Running\"}",
time="2018-09-12T19:29:46Z" level=debug msg="Services ------------------------------\n  c0ab1194b32f: (1.0 sec ago)\n      59844989cd37 nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3                 nginx:latest@sha256:24a0c4b4a4c0eb97a1aabb8e29f18e917d05abfe1b7a7c07857230879ce7d3d3  1.0 sec ago     Unhealthy\n      d8fd8f63de00 portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be                 portainer/agent:latest@sha256:468f58ed0ae81cdae7dd377d813efbce6011709d1fe3b539f515d2e0623c40be  1.0 sec ago     Alive    \n      b6932c9d02ab portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910                 portainer/portainer:latest@sha256:ab096b92ed177b47adfa8a9a99e304d36596efa557b9627c066cee164cc39910  1.0 sec ago     Alive    \n\n\nCluster Hosts -------------------------\n    c0ab1194b32f\n---------------------------------------",
time="2018-09-12T19:29:46Z" level=debug msg="GetBroadcasts(): 3 1398",
time="2018-09-12T19:29:46Z" level=debug msg="Note: Not enough space to fit any messages or message was nil",
time="2018-09-12T19:29:47Z" level=debug msg="GetBroadcasts(): 3 1398",

Vulnerabilities in ui/package.json

sidecar/ui> npm audit
[...]
51 vulnerabilities (4 low, 19 moderate, 21 high, 7 critical)

There is no lockfile!

@relistan you mentioned the project is maintained here newrelic#54 (comment), so I would expect it not to have critical vulnerabilities, even if those are probably just exposed at build time!

web app call xhr call to port 3212

Hi

I saw that Sidecar webapp after calling services.json on port 7777 try to retrieve the following URL:
http://:3212/;csv;norefresh

but that port is not open on the host where Sidecar is running

ServicePort defined but no ports in services.json

Hi

I add ServicePort and ServiceName labels to a container, but if I look at services.json, ports array is empty (both run as docker services)

Sidecar inspect

[
    {
        "ID": "7h1942z9ka4rnu7lqeiu5hptr",
        "Version": {
            "Index": 67577
        },
        "CreatedAt": "2018-09-09T19:10:59.240514256Z",
        "UpdatedAt": "2018-09-09T20:28:15.048590598Z",
        "Spec": {
            "Name": "sidecar",
            "Labels": {
                "SidecarDiscover": "false"
            },
            "TaskTemplate": {
                "ContainerSpec": {
                    "Image": "gonitro/sidecar:f56be36@sha256:195709bed8256d705f6c0143826401c0c3620bfb580873ddc19c82c77c6c9e40",
                    "Labels": {
                        "SidecarDiscover": "false"
                    },
                    "Env": [
                        "SIDECAR_BIND_PORT=7950",
                        "SIDECAR_SEEDS=127.0.0.1",
                        "SIDECAR_CLUSTER_NAME=dummy",
                        "HAPROXY_DISABLE=true",
                        "SIDECAR_LOGGING_LEVEL=debug"
                    ],
                    "Mounts": [
                        {
                            "Type": "bind",
                            "Source": "/var/run/docker.sock",
                            "Target": "/var/run/docker.sock"
                        }
                    ],
                    "StopGracePeriod": 10000000000,
                    "DNSConfig": {},
                    "Isolation": "default"
                },
                "Resources": {
                    "Limits": {},
                    "Reservations": {}
                },
                "RestartPolicy": {
                    "Condition": "any",
                    "Delay": 5000000000,
                    "MaxAttempts": 0,
                    "Window": 0
                },
                "Placement": {},
                "ForceUpdate": 5,
                "Runtime": "container"
            },
            "Mode": {
                "Replicated": {
                    "Replicas": 1
                }
            },
            "UpdateConfig": {
                "Parallelism": 1,
                "FailureAction": "pause",
                "Monitor": 5000000000,
                "MaxFailureRatio": 0,
                "Order": "stop-first"
            },
            "RollbackConfig": {
                "Parallelism": 1,
                "FailureAction": "pause",
                "Monitor": 5000000000,
                "MaxFailureRatio": 0,
                "Order": "stop-first"
            },
            "Networks": [
                {
                    "Target": "xi51w26iawdz7g1dc7yius6z0" <--- Host network
                }
            ],
            "EndpointSpec": {
                "Mode": "vip"
            }
        },
        "Endpoint": {
            "Spec": {
                "Mode": "vip"
            },
            "VirtualIPs": [
                {
                    "NetworkID": "xi51w26iawdz7g1dc7yius6z0"
                }
            ]
        },
        "UpdateStatus": {
            "State": "completed",
            "StartedAt": "2018-09-09T20:28:05.958923045Z",
            "CompletedAt": "2018-09-09T20:28:15.048560697Z",
            "Message": "update completed"
        }
    }
]

Labels in target container

"Labels": {
                "ServiceName": "wonderful-container",
                "ServicePort_80": "80",

Section of services.json

"wonderful-container": [
      {
        "ID": "a2b92d342697",
        "Name": "wonderful-container",
        "Image": "wonderful-container:latest@sha256:d8a4ce53bca03229e281675413661ebb24359f28c869a748d546c020f6d0b411",
        "Created": "2018-09-09T19:59:59Z",
        "Hostname": "my-host",
        "Ports": [],
        "Updated": "2018-09-09T20:39:42.360835566Z",
        "ProxyMode": "http",
        "Status": 0
      }
    ]

How can fix it?

error with container checks

Hi.

Trying sidecar another issue raised. Don't know if something I misunderstood, but it's not simple to search on the web for the type of error:

time="2018-09-09T19:11:22Z" level=warning msg="Adding check for service mysql:5.7@sha256:1d8f471c7e2929ee1e2bfbc1d16fc8afccd2e070afed24805487e726ce601a6d (id: 574d6ce4048a) failed. Got check type: , check args: ." 

web app Error: Argument 1 of FileReader.readAsText does not implement interface Blob

When I load for the first time the web interface, the page is like this picture:

After about 4/5 minutes it display the services discovered.

In the browser console (both Firefox and Chrome) I can find this error:

Error: Argument 1 of FileReader.readAsText does not implement interface Blob.
s/this._readChunk@http://arkham.syshell.net:7777/ui/bower_components/papaparse/papaparse.min.js:6:5519
s/this._nextChunk@http://arkham.syshell.net:7777/ui/bower_components/papaparse/papaparse.min.js:6:5328
s/this.stream@http://arkham.syshell.net:7777/ui/bower_components/papaparse/papaparse.min.js:6:5204
t@http://arkham.syshell.net:7777/ui/bower_components/papaparse/papaparse.min.js:6:465
updateData@http://arkham.syshell.net:7777/ui/services/services.js:125:13
@http://arkham.syshell.net:7777/ui/services/services.js:159:4
processQueue@http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:16696:28
scheduleProcessQueue/<@http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:16712:27
$eval@http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:17994:16
$digest@http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:17808:15
$apply@http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:18102:13
done@http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:12082:36
completeRequest@http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:12291:7
requestError@http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:12229:9
 3 angular.js:14199:18
	consoleLog/< http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:14199:18
	$ExceptionHandlerProvider/this.$get</< http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:10707:7
	processQueue http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:16704:9
	scheduleProcessQueue/< http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:16712:27
	$eval http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:17994:16
	$digest http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:17808:15
	$apply http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:18102:13
	done http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:12082:36
	completeRequest http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:12291:7
	requestError http://arkham.syshell.net:7777/ui/bower_components/angular/angular.js:12229:9

Use the correct zero value for `time.Time` throughout the codebase

The correct zero value for time.Time is time.Time{} instead of time.Unix(0, 0). Using the latter can cause hard to find bugs since func (Time) IsZero() would return false when called on time.Unix(0, 0). Details here: https://stackoverflow.com/questions/23051973/what-is-the-zero-value-for-time-time-in-go