ninjinkun/njkscrollfullscreen

Scroll to full screen like Facebook app

njkscrollfullscreen's Issues

self.navigationController.toolbar addSubview

When I add a view with Constraint upon toolbar,it cannot hide and show along with the toolbar;Can you give me some tips? Thanks!

custom titleview

Currently custom title view for uinavigationbar is not supported for the fading effect.

Autolayout

Hi,
i try to use it on uitableview inside uiviewcontroller with auto layout it's didn't work any advice for this case please

NJKScrollFullScreen bottom boundary is wrong?

My Problem is: I set contentInset of my scrollView instance and isOverBottomBoundary never become true.

NJKScrollDirection currentScrollDirection = detectScrollDirection(currentOffsetY, _previousOffsetY);
CGFloat topBoundary = -scrollView.contentInset.top;
CGFloat bottomBoundary = scrollView.contentSize.height + scrollView.contentInset.bottom;

Do I need to consider the height of ScrollView?

uitableview delegate methods

uitableview delegate methods are not getting called after setting tableview delegate to scroll proxy.

e.g.

• (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath;

In the demo project after calling

[self.tableView reloadData];

I thought that there is something wrong with method forwarding implementation.

But by calling

        [((UITableViewController <UITableViewDelegate>*)(self.tableView.delegate)) tableView:self.tableView heightForHeaderInSection:0];

instead of reloading tableview that method is forwarded correctly. Hence i can confirm that method forwarding is working.

It might be that uitableview has it's own delegate check mechanism internally and ignores to call delegate methods with current implementation. It sees an object conforming to UIScrollViewDelegate but not UITableViewDelegate.

Custom font removed?

I use a custom font in my nav bar - [[UINavigationBar appearance] setTitleTextAttributes:navTitleAttributes];.

The font seems to be reset to the default when the nav bar comes back.

NJKScrollFullScreen is written to NJKScrollFullSreen in README.md

I find a spelling mistake: NJKScrollFullScreen is written to NJKScrollFullSreen!

Your code has a bug when add a section view to tableView

Add this code to your viewController

• (CGFloat)tableView:(UITableView *)tableView heightForHeaderInSection:(NSInteger)section{
  return 50;
  }
• (UIView *)tableView:(UITableView *)tableView viewForHeaderInSection:(NSInteger)section{
  UIView *view = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 360, 50)];
  view.backgroundColor = [UIColor redColor];
  return view;
  }
  You will find the bug,I hope you can fix it! thanks
  

TabBar animation is broken

UIViewController+NJKFullScreenSupport.m

showTabBar, hideTabBar, and moveTabBar all call setToolbarOriginY which is presumably a copy & paste error since they should be calling setTabBarOriginY.

NavBar Buttons & Color broken after Rotation

Hi,

just tested the last official commit made on the main branch 4 days ago.

The same problems for the NavBar after device rotation exists.

1st Problem

Steps to reproduce:

• Use a common UINavigationBar with UIBarButtonItems
• Scroll down, so the NavBar is hidden
• Rotate the device to landscape

Expected:
Seeing the UINavigationBar and it's UIBarButtonItems again

Result:
NavBar is visible again (as wanted), but the UIBarButtonItems are hidden.

2nd Problem

Steps to reproduce:

• Same as above
• Additionally: Try to scroll up

Result:
The UIBarButtonItems appear again. But their color changed to yellow instead of white (white is expected and previously set). Like mentioned here before: #8 (comment)

Related Code:
In UIViewController+NJKFullScreenSupport.m, in (void)setNavigationBarOriginY:(CGFloat)y animated:(BOOL)animated.

Commenting out setting the tintColor removes the Yellow coloring after the button return. The 1st problem seems to be related to view.alpha restoration. You are restoring the Bar's alpha but not of the Buttons..

for (UIView *view in self.navigationController.navigationBar.subviews) {
            index++;
            if (index == 1 || view.hidden || view.alpha <= 0.0f) continue; // this logic is somehow broken
            view.alpha = alpha;
        }
        if (NJK_IS_RUNNING_IOS7) { // following leads to yellow buttons
            // fade bar buttons
            UIColor *tintColor = self.navigationController.navigationBar.tintColor;
            if (tintColor) {
                CGFloat *components = (CGFloat *)CGColorGetComponents(tintColor.CGColor);
                self.navigationController.navigationBar.tintColor = [UIColor colorWithRed:components[0] green:components[1] blue:components[2] alpha:alpha];
            }
        }

Cheers,
Frederik

TabBar and NavBar stuck on move animation

iOS SDK 8.1
iPhone 5