Giter Site home page Giter Site logo

waydroid-magisk's Introduction

Waydroid Magisk

Kitsune Mask manager for Waydroid.

Installing Magisk on Waydroid

Requirements

  • waydroid
  • make
  • git

Installation

From PPA

  1. curl -s --compressed "https://nitanmarcel.github.io/waydroid-magisk/waydroid_magisk.gpg" | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/waydroid_magisk.gpg > /dev/null
  2. sudo curl -s --compressed -o /etc/apt/sources.list.d/waydroid_magisk.list https://nitanmarcel.github.io/waydroid-magisk/waydroid_magisk.list
  3. sudo apt update
  4. sudo apt install waydroid-magisk
  5. run sudo waydroid_magisk install to install Magisk
  • waydroid-magisk can also be used as a manager. If you want to use Kitsune Mask Manager instead use the install command with --manager argument.
  1. start waydroid and run sudo waydroid_magisk setup to trigger first time setup.
  2. To avoid any issues it's important to read FAQ before using Kitsune Mask on waydroid.

From GitHub

  1. git clone https://github.com/nitanmarcel/waydroid-magisk-installer/
  2. run sudo make install USE_SYSTEMD=1
  • If using upstart (e.g Ubuntu Touch 16.04)
  • run sudo make install USE_UPSTART=1
  1. run sudo waydroid_magisk install to install Magisk
  • waydroid-magisk can also be used as a manager. If you want to use Kitsune Mask Manager instead use the install command with --manager argument.
  • Ubuntu Touch requires setting an working directory in /home/phablet
  • sudo waydroid_magisk install --tmpdir /home/phablet/magisk_waydroid
  1. start waydroid and run sudo waydroid_magisk setup to trigger first time setup.
  2. enable ota survival service
  • For systemd sudo systemctl enable --now waydroid_magisk_ota.service
  • For upstart sudo start waydroid_magisk_ota.service
  1. To avoid any issues it's important to read FAQ before using Kitsune Mask on waydroid.

Usage

  • a detailed list of all the available commands can be found in API.md

FAQ

What does work?

  • root
  • zygisk
  • modules
  • updates
  • ota updates survival (Starting with waydroid 1.4.0)

Waydroid won't start

Note that Waydroid may take longer to boot due to Magisk being set up.

No internet connection

Try restarting Waydroid using either systemd or init (depending on your system).

Magisk modules not working or not showing as installed

Currently, modules only work with Kitsune Mask Canary. Download and install the apk in Waydroid, and update by following the instructions in the "Updating" section below.

Kitsune Mask fails to patch SELinux policy.

  • Use waydroid_magisk to update and setup Magisk.

Updating

  • Using Kitsune Mask to install Magisk directly into the system partition.
  • Using waydroid_magisk install --update.

Does Zygisk work?

Zygisk only works with Kitsune Mask Canary which gets installed by default.

I've enabled Zygisk in Kitsune Mask Stable!!

  • Run waydroid_magisk zygisk disable - to disable zygisk.

How is this different from other scripts?

magisk_waydroid is a Kitsune Mask manager, bringing all the features from Kitsune Mask manager in your command line.

What is Kitsune Mask?

Kitsune Mask is a fork of the official Magisk Manager with the old Magisk Hide feature re-added and other new features. You can find a list of differences between Kitsune Mask and official Magisk here.

Arch Linux

On arch based distributions, linux-xanmod-anbox with linux-xanmod-anbox-headers (needs psi=1 in cmdline) from chaotic AUR is recommended, otherwise Kitsune Mask might not work properly.

Ubuntu Touch

waydroid-magisk is developed to be compatible with almost every Linux OS, including Ubuntu Touch. But a few issues can still occur such as (workarounds included).

  • Readonly filesystem/No space left
    • sudo waydroid_magisk install --tmpdir /home/phablet/magisk
  • Failed to re-execute lxc-attach via memory file descriptor
    • Use waydroid_magisk via adb
    • or enable ssh android-gadget-service enable ssh and ssh to localhost (ssh localhost)
  • CANNOT LINK EXECUTABLE "service": "/system/lib/libcutils.so" is 32-bit instead of 64-bit
    • sudo env LD_LIBRARY_PATH=/android/system/lib64/ waydroid_magisk {command failing here}

Credits

waydroid-magisk's People

Contributors

nitanmarcel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

waydroid-magisk's Issues

error upon running make install USE_SYSTEMD=1

i have the waydroid installed and working from the AUR, I wanted to root that.

git cloned this repo
cd
sudo make install USE_SYSTEMD=1

i get this error:
if [ -f /sys/fs/selinux/enforce ]; then
echo "Magisk Delta is not compatible with SELinux on Waydroid.";
exit 1;
fi
install -d /usr/bin
install -m 755 waydroid_magisk.py /usr/bin/waydroid_magisk
if [ 1 = 1 ]; then
install -d /usr/lib/systemd/system;
cp waydroid_magisk_ota.service /usr/lib/systemd/system;
fi
if [ 0 = 1 ]; then
install -d /etc/init;
cp waydroid_magisk_ota.conf /etc/init;
fi

Error while installing magisk

Describe the bug
when running sudo waydroid_magisk install or sudo waydroid_magisk install --update, following error occurs:

Traceback (most recent call last):
  File "/usr/lib/python3.11/urllib/request.py", line 1348, in do_open
    h.request(req.get_method(), req.selector, req.data, headers,
  File "/usr/lib/python3.11/http/client.py", line 1283, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "/usr/lib/python3.11/http/client.py", line 1329, in _send_request
    self.endheaders(body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.11/http/client.py", line 1278, in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
  File "/usr/lib/python3.11/http/client.py", line 1038, in _send_output
    self.send(msg)
  File "/usr/lib/python3.11/http/client.py", line 976, in send
    self.connect()
  File "/usr/lib/python3.11/http/client.py", line 1448, in connect
    super().connect()
  File "/usr/lib/python3.11/http/client.py", line 942, in connect
    self.sock = self._create_connection(
                ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/socket.py", line 851, in create_connection
    raise exceptions[0]
  File "/usr/lib/python3.11/socket.py", line 836, in create_connection
    sock.connect(sa)
OSError: [Errno 101] Network is unreachable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/waydroid_magisk", line 1005, in <module>
    main()
  File "/usr/bin/waydroid_magisk", line 895, in main
    magisk_channels = download_json(
                      ^^^^^^^^^^^^^^
  File "/usr/bin/waydroid_magisk", line 107, in download_json
    with urllib.request.urlopen(url) as response:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/urllib/request.py", line 216, in urlopen
    return opener.open(url, data, timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/urllib/request.py", line 519, in open
    response = self._open(req, data)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/urllib/request.py", line 536, in _open
    result = self._call_chain(self.handle_open, protocol, protocol +
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/urllib/request.py", line 496, in _call_chain
    result = func(*args)
             ^^^^^^^^^^^
  File "/usr/lib/python3.11/urllib/request.py", line 1391, in https_open
    return self.do_open(http.client.HTTPSConnection, req,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/urllib/request.py", line 1351, in do_open
    raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 101] Network is unreachable>

To Reproduce
Steps to reproduce the behavior:

  1. Run sudo waydroid_magisk install
  2. Enter password

Expected behavior
Above error occurs

Logs
[03:13:38] - ERROR - Magisk Delta is not installed

Desktop (please complete the following information):

  • OS: manjaro
  • Version: 1.2.4
  • Waydroid Version: 1.4.1-1

Additional context
Add any other context about the problem here.

Siu

Starting with root...

Can't open root shell, try again...

Still not :(

error upon running sudo waydroid_magisk setup bug

phablet@ubuntu-phablet:~$ sudo waydroid magisk setup [sudo] password for phablet:
Permission denied - Failed to rexec as menfd free(): invalid pointer
permission denied • Failed to rexec as memfd free(): invalid pointer
permission denied - Failed to rexec as memfd free(): invalid pointer
Permission denied • Failed to rexec as memfd free(): invalid pointer
Permission denied - Failed to rexec as menfd free(): invalid pointer
Permission denied • Failed to rexec as menfd free: invalid pointer
[10:50:07] - INFO - Restarting Waydroid in 5 (press ^
C to cancel)
[10:50:08] - INFO - Restarting Waydroid in 4 (press ^
C to cancel)
[10:50:09] - INFO - Restarting Waydroid in 3 (press ^
C to cancel)
[10:50:10] - INFO - Restarting Waydroid in 2 (press ^
C to cancel)
[10:50:11] - INFO - Restarting Waydroid in 1 (press ^
C to cancel)
[10:50:12] - INFO - Stopping Waydroid
10:50:14] - INFO - Starting Waydroid

ubuntu touch ota3
fxtex pro1x

What should I do, teach me, thank you.

error on bazzite 39 (silverblue fedora 39)

Describe the bug
if [ -f /sys/fs/selinux/enforce ]; then
echo "Kitsune Mask is not compatible with SELinux on Waydroid.";
exit 1;
fi
Kitsune Mask is not compatible with SELinux on Waydroid.
make: *** [Makefile:18: check_selinux] Error 1

To Reproduce
Steps to reproduce the behavior:

  1. follow install guide
  2. run sudo make install USE_SYSTEMD=1
  3. See error

note: selinux is set to permissive

ERROR - Incomplete magisk setup

running into this error when trying to install magi on waydroid: ERROR - Incomplete magisk setup

To Reproduce
Steps to reproduce the behavior:

  1. Follow the install instructions under "From GitHub"
  2. run: sudo waydroid_magisk install --manager
  3. Run waydroid_magisk setup after waydroid starts again
  4. run: waydroid_magisk magiskhide enable
  5. See error: ERROR - Incomplete magisk setup

Logs
From sudo waydroid_magisk log --save
magisk_log_2023-08-08_15:16:02.log

Desktop (please complete the following information):

  • OS: Fedora
  • Version: 38
  • Waydroid Version: 1.4.1

Additional context
Installation:
sudo waydroid_magisk install --manager
[15:06:42] - INFO - Downloading Magisk Delta: canary-fdac22ba-delta
[15:06:42] - INFO - Extracting Magisk Delta
[15:06:42] - INFO - Installing Magisk Delta
[15:06:42] - INFO - Backing up bootanim.rc
[15:06:42] - INFO - Patching bootanim.rc
[15:06:42] - INFO - Finishing installation
[15:06:42] - INFO - Done
[15:06:42] - INFO - Run waydroid_magisk setup after waydroid starts again or install Magisk Delta Manager
[fedora@fedora modules]$ waydroid_magisk setup
[15:08:01] - ERROR - This command needs to be ran as a priviliged user!
[fedora@fedora modules]$ sudo !!
sudo waydroid_magisk setup
No daemon is currently running!
No daemon is currently running!
No daemon is currently running!
No daemon is currently running!
No daemon is currently running!
No daemon is currently running!
[15:08:05] - INFO - Restarting Waydroid in 5 (press ^C to cancel)
[15:08:06] - INFO - Restarting Waydroid in 4 (press ^C to cancel)
[15:08:07] - INFO - Restarting Waydroid in 3 (press ^C to cancel)
[15:08:08] - INFO - Restarting Waydroid in 2 (press ^C to cancel)
[15:08:09] - INFO - Restarting Waydroid in 1 (press ^C to cancel)
[15:08:10] - INFO - Stopping Waydroid
[15:08:10] - INFO - Starting Waydroid
[fedora@fedora modules]$ waydroid_magisk magiskhide enable
[15:09:31] - ERROR - Incomplete magisk setup

getting the same error if i run sudo waydroid_magisk magiskhide enable

lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "service"

Describe the bug
A clear and concise description of what the bug is.

systemctl start waydroid-container.service

sudo waydroid_magisk.py install

[16:51:41] - INFO - Downloading Magisk Delta: canary-80855189-delta
[16:51:42] - INFO - Extracting Magisk Delta
[16:51:42] - INFO - Installing Magisk Delta
[16:51:42] - INFO - Backing up bootanim.rc
[16:51:42] - INFO - Patching bootanim.rc
[16:51:42] - INFO - Finishing installation
[16:51:42] - INFO - Done
[16:51:42] - INFO - Run waydroid_magisk setup after waydroid starts again or install Magisk Delta Manager

waydroid show-full-ui
sudo waydroid_magisk.py setup

[16:53:08] - ERROR - Magisk Delta is not installed
[16:53:08] - ERROR - Magisk Delta is not installed
[16:53:08] - ERROR - Magisk Delta is not installed
[16:53:08] - ERROR - Magisk Delta is not installed
[16:53:08] - ERROR - Magisk Delta is not installed
[16:53:08] - ERROR - Magisk Delta is not installed
[16:53:08] - INFO - Stopping Waydroid in 5 (press ^C to cancel)
[16:53:09] - INFO - Stopping Waydroid in 4 (press ^C to cancel)
[16:53:10] - INFO - Stopping Waydroid in 3 (press ^C to cancel)
[16:53:11] - INFO - Stopping Waydroid in 2 (press ^C to cancel)
[16:53:12] - INFO - Stopping Waydroid in 1 (press ^C to cancel)
[16:53:13] - INFO - Stopping waydroid
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "service"
[16:53:13] - INFO - Starting Waydroid

Now,if i install nagisk delta manually from apk in the waydroid,it will show
图片
If i ckick "ok", "dirct install into system partition",
图片
if i ctrl+c waydroid show-full-ui ,and rerun sudo waydroid_magisk.py install,

[17:04:43] - ERROR - Magisk Delta already installed!

Logs
From sudo waydroid_magisk log --save
No,it will show [17:04:14] - ERROR - Magisk Delta is not installed
Desktop (please complete the following information):

  • OS: [e.g. iOS] Arch Linux with linux-xanmod-anbox
  • Waydroid Version: [e.g. 1.4.0] 1.3.4

Additional context
Add any other context about the problem here.

Magisk daemon not launching properly?

Describe the bug
waydroid_magisk status shows as daemon running, no root access in apps and magisk delta.
In /system/etc/init/magisk, both magisk32 and magisk64 shows No daemon running.

To Reproduce
Steps to reproduce the behavior:
Install waydroid with waydroid init
waydroid boots for first time
Install magisk with sudo waydroid_magisk install
Run sudo waydroid_magisk setup as instructed.

Expected behavior
Magisk should show a running daemon in the os.

Logs

10-10 18:36:07.397   187   187 I : Magisk 0fe46c5a-delta(26301) daemon started
10-10 18:36:07.397   187   187 I : * Device API level: 30
10-10 18:36:07.398   187   187 I : * CPU ABI 64-bit: x86_64,arm64-v8a
10-10 18:36:07.398   187   187 I : * CPU ABI 32-bit: x86,armeabi-v7a,armeabi
10-10 18:36:21.187   187   192 I : ** boot-complete triggered

Desktop (please complete the following information):

  • OS: Linux 6.5.5-x64v2-xanmod1-1 #1 SMP PREEMPT_DYNAMIC Thu, 05 Oct 2023 20:25:13 +0000 x86_64 GNU/Linux
  • Version: 1.2.10
  • Waydroid Version: waydroid-1.4.1-1

Additional context
I've tried uninstalling and reinstalling waydroid
I've tried uninstalling and reinstalling magisk

waydroid_magisk setup seems to failed with lxc-attach error as below

Describe the bug
Run sudo waydroid_magisk setupfailed or at least doesn't do anything except restart waydroid session.

To Reproduce
Steps to reproduce the behavior:

  • Start waydroid, waydroid show-full-ui
  • Run sudo waydroid_magisk setup

Expected behavior
To be honest I'm not sure what the expected behaviour should be because I'm new to Magisk & Waydroid

Logs
sudo waydroid_magisk log --save failed for me, but that's a different issue I think.
Here is the console output:

lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
[03:06:47] - INFO - Restarting Waydroid in 5 (press ^C to cancel)
[03:06:48] - INFO - Restarting Waydroid in 4 (press ^C to cancel)
[03:06:49] - INFO - Restarting Waydroid in 3 (press ^C to cancel)
[03:06:50] - INFO - Restarting Waydroid in 2 (press ^C to cancel)
[03:06:51] - INFO - Restarting Waydroid in 1 (press ^C to cancel)
[03:06:52] - INFO - Stopping Waydroid
[03:06:52] - INFO - Starting Waydroid

Desktop (please complete the following information):

  • OS: Manjaro
  • kernel: Linux x1 6.7.4-zen1-1-zen #1 ZEN SMP PREEMPT_DYNAMIC Mon, 05 Feb 2024 22:07:37 +0000 x86_64 GNU/Linux
  • Version: 23.1.3
  • Waydroid Version: 1.4.2

Additional context

I understand that this repo is put on hold, however I hope that this could just be a small misstep on my part so I'm looking for some answers here.

[BUG] Magisk is not downloadable so it cannot be installed

Describe the bug
A clear and concise description of what the bug is.
I cannot execute magisk installation to waydroid since it cannot find magisk delta apk to download

To Reproduce
Steps to reproduce the behavior:

  1. Go to terminal
  2. Type sudo waydroid_magisk install --manager
  3. See error no 1

Other method

  1. Go to terminal
  2. Type sudo waydroid_magisk install
  3. See error no 2

Expected behavior
A clear and concise description of what you expected to happen.
Successful installation

Logs
From sudo waydroid_magisk log --save
[18:16:14] - INFO - Stopping Waydroid
[18:16:15] - INFO - Downloading Magisk Delta: canary-0fe46c5a-delta
Traceback (most recent call last):
File "/usr/bin/waydroid_magisk", line 144, in download_obj
with urllib.request.urlopen(url) as response:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 216, in urlopen
return opener.open(url, data, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 525, in open
response = meth(req, response)
^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 634, in http_response
response = self.parent.error(
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 563, in error
return self._call_chain(*args)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 496, in _call_chain
result = func(*args)
^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 643, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/bin/waydroid_magisk", line 1148, in
main()
File "/usr/bin/waydroid_magisk", line 1030, in main
install_fnc(arch, bits, magisk_channel, restart_after=True,
File "/usr/bin/waydroid_magisk", line 693, in install
download_obj(magisk["magisk"]["link"], tempdir, "magisk-delta.apk")
File "/usr/bin/waydroid_magisk", line 148, in download_obj
raise ValueError("Failed to download %s: %s" % (filename, exc.code))
ValueError: Failed to download magisk-delta.apk: 404

Logs 2
[18:24:20] - INFO - Downloading Magisk Delta: canary-0fe46c5a-delta
Traceback (most recent call last):
File "/usr/bin/waydroid_magisk", line 144, in download_obj
with urllib.request.urlopen(url) as response:
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 216, in urlopen
return opener.open(url, data, timeout)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 525, in open
response = meth(req, response)
^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 634, in http_response
response = self.parent.error(
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 563, in error
return self._call_chain(*args)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 496, in _call_chain
result = func(*args)
^^^^^^^^^^^
File "/usr/lib/python3.11/urllib/request.py", line 643, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/usr/bin/waydroid_magisk", line 1148, in
main()
File "/usr/bin/waydroid_magisk", line 1030, in main
install_fnc(arch, bits, magisk_channel, restart_after=True,
File "/usr/bin/waydroid_magisk", line 693, in install
download_obj(magisk["magisk"]["link"], tempdir, "magisk-delta.apk")
File "/usr/bin/waydroid_magisk", line 148, in download_obj
raise ValueError("Failed to download %s: %s" % (filename, exc.code))
ValueError: Failed to download magisk-delta.apk: 404

Desktop (please complete the following information):

  • OS: Ubuntu
  • Version: 23.10
  • Waydroid Version: 1.4.2

Additional context
Add any other context about the problem here.

I've used the version of the tool from the deb repository you're hosting

Btw an suggestion: add ability to select custom and forked repos so that we can use forked versions of Magisk Delta if something goes wrong to their official repo

[Bug] Magisk modules don't get installed.

Describe the bug
A clear and concise description of what the bug is.
Magisk modules do not work correctly and do not get installed even with the latest magisk delta canary build.

Expected behavior
Magisk modules install and run correctly.

waydroid_magisk setup fail

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:
sudo pamac build waydroid_magisk
sudo waydroid_magisk install
sudo waydroid_magisk setup

image

cant execute su

Describe the bug
magisk not installing correctly and failing setup

To Reproduce
Steps to reproduce the behavior:
sudo waydroid_magisk install -m
waydroid session start
sudo waydroid_magisk setup
restart waydroid
waydroid show-full-ui
magisk delta manager not installed if i install it it manually with the APK it dosnt detect root and wont install
waydroid_magisk remove also fails
Expected behavior
have magisk and the manager installed

Logs
sudo waydroid_magisk install --manager
[22:27:02] - INFO - Downloading Magisk Delta: canary-fdb1fbaf-delta
[22:27:07] - INFO - Extracting Magisk Delta
[22:27:07] - INFO - Installing Magisk Delta
[22:27:07] - INFO - Backing up bootanim.rc
[22:27:07] - INFO - Patching bootanim.rc
[22:27:07] - INFO - Finishing installation
[22:27:07] - INFO - Done
[22:27:07] - INFO - Run waydroid_magisk setup after waydroid starts again or install Magisk Delta Manager

sudo waydroid_magisk setup
[sudo] password for charlie:
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1
841 No such file or directory - Failed to exec "su"
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"
[22:29:57] - INFO - Restarting Waydroid in 5 (press ^C to cancel)
[22:29:58] - INFO - Restarting Waydroid in 4 (press ^C to cancel)
[22:29:59] - INFO - Restarting Waydroid in 3 (press ^C to cancel)
[22:30:00] - INFO - Restarting Waydroid in 2 (press ^C to cancel)
[22:30:01] - INFO - Restarting Waydroid in 1 (press ^C to cancel)
[22:30:02] - INFO - Stopping Waydroid
[22:30:03] - INFO - Starting Waydroid

sudo waydroid_magisk log

lxc-attach: waydroid: ../src/lxc/attach.c: lxc_attach_run_command: 1841 No such file or directory - Failed to exec "su"

  • OS: endeavour os
  • Version: rolling realise
  • Waydroid Version: 1.3.4

Project on hold

waydroid_magisk is currently on hold until Kitsune is fixed on Waydroid. I also don't look into providing an older version at this moment or any unofficial ones so you must wait until I get this problem fixed from Kitsune side

enhancement: systemd flags in readme

just a little headsup for the readme.md:

For systemd sudo systemctl enable waydroid_magisk_ota.service && sudo systemctl start waydroid_magisk_ota.service

you dont need to run start after enable, because enable has this handy --now flag:

systemctl enable --now waydroid_magisk_ota.service will both enable and start the service

fix linux zen

Is your feature request related to a problem? Please describe.
magisk cant work on linux zen kernal (N/A)

Describe the solution you'd like
magisk should work ( not sure why it doesnt work anyways )

Describe alternatives you've considered
switch to xanmod kernel but it is outdated compared to zen and you have to trust a random repo (chaotic aur)

Additional context
Add any other context or screenshots about the feature request here.

Please if isn't a problem port this tool to install magisk on gsis

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I have a phone with locked bl, and this is a problem as i'm unable to install magisk in any way, also boot doesn't even have a ramdisk.
Describe the solution you'd like
A clear and concise description of what you want to happen.
This tool you made could be the solution to my and other people problem, i have phh-su so if the tool could install magisk from a shell would be great, note that i don't have /sbin
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
I tried many alternatives, magisk delta doesn't work because gsis are on f2fs, i tried to install magisk files manually but magisk doesn't want to work, i tried to patch recovery as well but when i do the process to boot in magisk mode i always get in recovery. For all these issues a "magisk on gsi" tool on github is needed
Additional context
Add any other context or screenshots about the feature request here.

Root

adb shell sh /storage/emulated/0/Android/data/moe.shizuku.privileged.api/start.sh

Support runit

Is your feature request related to a problem? Please describe.
Only available for systemd and upstart

Describe the solution you'd like
Support runit

Describe alternatives you've considered
Hacking the code when I'm less sleepy

Additional context
I'm using Void Linux musl edition

ROOT OK they say PC I'm trying without it can be done

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Magisk N/A, can't execute su

Tried to install with this script to latest waydroid and it says Magisk N/A , I guess it has something to do with libprocessgroup: Failed to make and chown /acct/uid_0: Read-only file system but I hope you can help me to figure it out. :)

  • Distro: arch
  • Kernel: 6.1.2-zen1-1-zen
  • Waydroid version: 1.3.4

DMESG:

[ 1314.601686] init: createProcessGroup(0, 57) failed for service 'exec 8 (/system/etc/init/magisk/magisk64 --setup-sbin /system/etc/init/magisk)': Read-only file system
[ 1314.601694] init: SVC_EXEC service 'exec 8 (/system/etc/init/magisk/magisk64 --setup-sbin /system/etc/init/magisk)' pid 57 (uid 0 gid 0+0 context default) started; waiting...
[ 1314.605282] init: Service 'exec 8 (/system/etc/init/magisk/magisk64 --setup-sbin /system/etc/init/magisk)' (pid 57) exited with status 0 waiting took 0.003000 seconds
[ 1314.605289] init: Sending signal 9 to service 'exec 8 (/system/etc/init/magisk/magisk64 --setup-sbin /system/etc/init/magisk)' (pid 57) process group...
[ 1314.605307] libprocessgroup: Successfully killed process cgroup uid 0 pid 57 in 0ms
[ 1314.606032] init: starting service 'exec 9 (/system/etc/init/magisk/magiskpolicy --live --magisk allow * magisk_file lnk_file *)'...
[ 1314.606400] libprocessgroup: Failed to make and chown /acct/uid_0: Read-only file system
[ 1314.606409] init: createProcessGroup(0, 58) failed for service 'exec 9 (/system/etc/init/magisk/magiskpolicy --live --magisk allow * magisk_file lnk_file *)': Read-only file system
[ 1314.606414] init: SVC_EXEC service 'exec 9 (/system/etc/init/magisk/magiskpolicy --live --magisk allow * magisk_file lnk_file *)' pid 58 (uid 0 gid 0+0 context default) started; waiting...
[ 1314.608776] init: Service 'exec 9 (/system/etc/init/magisk/magiskpolicy --live --magisk allow * magisk_file lnk_file *)' (pid 58) exited with status 1 waiting took 0.002000 seconds
[ 1314.608782] init: Sending signal 9 to service 'exec 9 (/system/etc/init/magisk/magiskpolicy --live --magisk allow * magisk_file lnk_file *)' (pid 58) process group...
[ 1314.608801] libprocessgroup: Successfully killed process cgroup uid 0 pid 58 in 0ms
[ 1314.608978] init: Command 'copy /system/etc/init/magisk/config /sbin/.magisk/config' action=post-fs-data (/system/etc/init/bootanim.rc:17) took 0ms and failed: Could not read input file '/system/etc/init/magisk/config': open() failed: No such file or directory
[ 1314.608993] init: Command 'rm /dev/.magisk_unblock' action=post-fs-data (/system/etc/init/bootanim.rc:18) took 0ms and failed: unlink() failed: No such file or directory
[ 1314.609007] init: starting service '2GAeIByHfo9egB8DTKqa'...
[ 1314.609472] libprocessgroup: Failed to make and chown /acct/uid_0: Read-only file system
[ 1314.609482] init: createProcessGroup(0, 59) failed for service '2GAeIByHfo9egB8DTKqa': Read-only file system
[ 1314.623168] DEBUG: *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
[ 1314.623216] DEBUG: LineageOS Version: '18.1-20221231-VANILLA-waydroid_x86_64'
[ 1314.623239] DEBUG: Build fingerprint: 'waydroid/lineage_waydroid_x86_64/waydroid_x86_64:11/RQ3A.211001.001/9:userdebug/test-keys'
[ 1314.623260] DEBUG: Revision: '0'
[ 1314.623281] DEBUG: ABI: 'x86_64'
[ 1314.623324] DEBUG: Timestamp: 2023-01-04 13:10:56+0000
[ 1314.623345] DEBUG: pid: 61, tid: 61, name: magiskd  >>> magiskd <<<
[ 1314.623365] DEBUG: uid: 0
[ 1314.623385] DEBUG: signal 6 (SIGABRT), code -1 (SI_QUEUE), fault addr --------
[ 1314.623419] DEBUG: Abort message: 'stack corruption detected (-fstack-protector)'
[ 1314.623443] DEBUG:     rax 0000000000000000  rbx 000000000000003d  rcx 00007f90c4a66758  rdx 0000000000000006
[ 1314.623464] DEBUG:     r8  0000000000000002  r9  0000000000000002  r10 00007ffe9ca7f1c0  r11 0000000000000246
[ 1314.623485] DEBUG:     r12 0000000000000009  r13 0000000000000000  r14 00007ffe9ca7f1b8  r15 000000000000003d
[ 1314.623506] DEBUG:     rdi 000000000000003d  rsi 000000000000003d
[ 1314.623526] DEBUG:     rbp 000000000000000d  rsp 00007ffe9ca7f1a8  rip 00007f90c4a66758
[ 1314.623829] DEBUG: 
[ 1314.623831] DEBUG: backtrace:
[ 1314.623866] DEBUG:       #00 pc 000000000009d758  /apex/com.android.runtime/lib64/bionic/libc.so (syscall+24) (BuildId: 082396c74061b06f8ce2a645b3a60e84)
[ 1314.623890] DEBUG:       #01 pc 00000000000a06c2  /apex/com.android.runtime/lib64/bionic/libc.so (abort+194) (BuildId: 082396c74061b06f8ce2a645b3a60e84)
[ 1314.623913] DEBUG:       #02 pc 00000000000b5433  /apex/com.android.runtime/lib64/bionic/libc.so (__stack_chk_fail+19) (BuildId: 082396c74061b06f8ce2a645b3a60e84)
[ 1314.623959] DEBUG:       #03 pc 000000000001fc0f  /sbin/magisk64 (BuildId: 0b2a2086ec4ceaea0248c90554def8726a1740dc)
[ 1314.623986] DEBUG:       #04 pc 000000000001fd01  /sbin/magisk64 (BuildId: 0b2a2086ec4ceaea0248c90554def8726a1740dc)
[ 1314.624018] DEBUG:       #05 pc 000000000001f649  /sbin/magisk64 (BuildId: 0b2a2086ec4ceaea0248c90554def8726a1740dc)
[ 1314.624041] DEBUG:       #06 pc 000000000001d204  /sbin/magisk64 (BuildId: 0b2a2086ec4ceaea0248c90554def8726a1740dc)
[ 1314.624064] DEBUG:       #07 pc 0000000000093c88  /apex/com.android.runtime/lib64/bionic/libc.so (__libc_init+104) (BuildId: 082396c74061b06f8ce2a645b3a60e84)
[ 1324.366371] kauditd_printk_skb: 11 callbacks suppressed```

cp: cannot create regular file

tried to install on arch and ubuntu touch fresh waydroid install and I get
cp: cannot create regular file '/tmp/tmp.s6dOzx3sF6/system/system/etc/init//magisk/magisk64': No such file or directory

linux-xanmod-anbox and it's header got remove from chaotic aur

Is your feature request related to a problem? Please describe.
the linux-xanmod-anbox & linux-xanmod-anbox-headers got removed from chaotic aur

Describe the solution you'd like
update the readme.md to provide alternative ways to get magisk working on waydroid like providing another repo to download from

Describe alternatives you've considered
only thing i could find is installing the packages from chinese aur but i didn't do that yet

Additional context
Add any other context or screenshots about the feature request here.

Broken link, needs updating

Describe the bug
Link in https://github.com/nitanmarcel/waydroid-magisk#what-is-kitsune-mask goes to 404 page

To Reproduce
Steps to reproduce the behavior:

  1. Go to the above section
  2. Click link
  3. Voila

Expected behavior
Links to https://github.com/HuskyDG/magisk-files/blob/main/note.md#diffs-to-official-magisk

Logs
N/A

Desktop (please complete the following information):

  • OS: Ubuntu Touch
  • Version: Development 20.04 r537 (fp4)
  • Waydroid Version: N/A

Additional context
(none)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.