njx/brackets-livedev2

Experiments in refactoring Brackets live development to support multiple targets.

brackets-livedev2's Issues

Add support for embedded JS

Live editing of embedded JS is not propagating any changes to the live page. It could reload the page as when editing external JS files after saving the .html file.

[DISCUSSION] Landing livedev2 in Brackets

This is a follow up to this @redmunds and @sebaslv discussion here. We need to figure out how we want to land this extension in the mainstream Brackets. While everybody's busy with the 1.0 release, @sebaslv and I could start working on actually landing the extension in the editor. We have to agree on which of the options is the way we want to go. There are a few options as I see them:

1. Keep the extension completely separate and make it a drop-in replacement.
2. Integrate it as an extension (could be a sub-module or copied code).
3. Copy the code next to existing LiveDevelopment. In a sense, this code will cease to be an extension and will be an optional (experimental?) version of LD. The users would switch between them (via UI or prefs), depending on what they want to use it for.

I like the 3rd option the best -- it puts this implementation on par with the existing one and allows us to reorganize the existing LD code to share it more efficiently. Also, it will make our lives easier when later we would want to make this version the "mainstream" one.

There's also some code which has not been contributed yet because we don't have a decision. E.g. browser launch (we have implementation for Firefox and Chrome in JS, in Brackets it's done via shell for Chrome only), enabling live development on remote machines (there's some demand for that in Brackets as well, requires changes in core editor). Let's discuss what's the best approach to this.

@dangoor, @redmunds, @njx, @sebaslv. Anybody I'm missing?

Background color not updated correctly

Following up on issue #21, which uses the Brackets Smoke Tests files edited to access desktop.css using a <link> instead of @import then it (partially) works:

Notice in Step 39 of Smoke Tests that background color is repainted, but it's repainted over the images!

I'm using latest Firefox on Win7.

Mechanism for adding protocol handlers methods

There is a unique handler in ProtocolHandler at LiveDevProtocolRemote that parses the message to identify the method and do something there. Need a more extensible way of registering new methods and provide their implementations separately from this handler.

Doesn't work in Internet Explorer

Initial page loads, but almost nothing else works in IE. I'm using Version 11.0.9600.17239 on Win7.

IE does not update even after saving page in Brackets. Interesting that if you Reload page from IE it pickups changes -- even unsaved changes in Brackets! So, it seems like text is getting updated in browser, but browser is not refreshing.

Close/restart session not working

Lightning bolt doesn't turn off when browser preview is closed. Haven't thought through how we should indicate in the UI when multiple browser clients are active, and whether we should turn the lightning bolt off when the last one disconnects.

NodeSocketTransportRemote.setCallbacks() name is slightly misleading

setCallbacks() actually also initiates the connection, so maybe it should be renamed to something like connectWithCallbacks().

README is out-of-date

Please update!

Instrumentation fails after page reload

It is manifested when the current file in the editor is not the live HTML document (eg. a related JS file).

HTMLIntrsumentation.generateInstrumentedHTML throws an exception at line 756 because editor=null. When the page is reloaded, the server asks for the instrumented document but at that time the editor seems to be previously detached by LiveDocument._onActiveEditorChange and LiveDocument._close

A new browser page is launched after switching back to .html file

Switching files in Brackets opens a new tab (and old tab is no longer connected, but there's no visible indication to the user). This is partly FOL due to closing live dev not closing the window in the browser.

CSS doesn't update when attached with @import

Following the Brackets Smoke Tests here: https://github.com/adobe/brackets/wiki/Brackets-Smoke-Tests

CSS does not update when edited. Even worse the entire stylesheet seems to be lost! After edting this page to access desktop.css using a <link> instead of @import then it works (uh, partially -- see #22) I'm on the latest Firefox on Win7.