Propagate "close" socket events to streams

[nkzawa]

Propagate "close" socket events to streams

[nkzawa]

+1

I would add you as a collaborator if you want.

[AaronO]

That would definitely be nice.

I'm going to be actively using this for various parts components of my startup (https://friendco.de).

So I'll most likely have improvements and bugfixes to submit in the future. (I just started using and looking into socket.io-stream this evening btw).

[nkzawa]

added you as a collaborator.

[AaronO]

Thanks

[nkzawa]

Could you give me your name and email for the contributors field of package.json

[AaronO]

Name: Aaron O'Mullan
Email: [email protected]

[AaronO]

It's 3am here in California. So I'll look into this issue in the morning.

Thanks for your help.

[nkzawa]

Thanks a lot again. I will release the feature of duplex streams as v0.4.0 soon anyway.

[nkzawa]

Can you add tests for this?

I'm not sure but we should think how the allowHalfOpen option of duplex streams works.

[nkzawa]

I mean emitting end may not be enough when allowHalfOption is true, I'm not sure though.
Duplex streams have finish event too.

[AaronO]

We should probably respect and support the allowHalfOpen option.

We could call Duplex.prototype._end in IOStream.prototype._end which would handle the emitting the end event as well as the allowHalfOpen logic on our behalf.

So if we do the above, in socket.js on sio.on('disconnect', ... (e1d9ec8#L0R106), we could then simply do something like :

sio.once('disconnect', function() {
      // Emit end correctly (with modified end function as described above)
      stream.end();

      // 'close' is optional for streams
      // but it makes sense here since it's the under laying transport (the socket.io socket)
      // which is disconnected/closed
      stream.emit('close');

      // Remove internal references
      cleanup();
});

What do you think of that ?

[nkzawa]

Does Duplex have the _end method ?
Maybe we need actual code to see what is good.

Give me time to think it anyway, Stream 2 API is too complicated for me :D

[nkzawa]

In my thought, streams have to emit close and error when sockets closed, since this is for when sockets were disconnected before completing to write and read data.
It looks like that end and finish events mean succeed.

[nkzawa]

I'm working this issue on the "allowHalfOpen" branch with the issue #6.

https://github.com/nkzawa/socket.io-stream/tree/allowHalfOpen

Tell me please If you have any other ideas.