Memory leak prevention / warnings

[nkzawa]

Memory leak prevention / warnings

[nkzawa]

I think streams would be cleaned up if you properly call stream.end() (or pipe()).
Do you mean you'd like to add a feature to clean streams even if they are not consumed?
If so, one way is to add timeout to each stream.

Could it be that streams don't get removed when an error occurs? I wrote error handlers on streams that would manually end() and destroy() that stream.

Streams should be removed upon error.
https://github.com/nkzawa/socket.io-stream/blob/master/lib/iostream.js#L264

[peteruithoven]

Streams should be removed upon error.
https://github.com/nkzawa/socket.io-stream/blob/master/lib/iostream.js#L264
Very valid point. Maybe my issues where caused by other factors. Not sure what happens when the stream that it's piped to throws an error for example.

What do you think about adding the info to the debug logs and giving that warning?

[nkzawa]

Logging and warning also are great idea. And exactly we can use debug module to log them.

[peteruithoven]

The following module might be useful to use combined with socket.io-stream, to make sure streams get closed.
https://www.npmjs.com/package/pump