3.11.3: test suite fails in 4 units

[kloczek]

3.11.3: test suite fails in 4 units

[gregmarr]

Did you download this version or check it out via git?

From the Readme:

In case you have downloaded the library rather than checked out the code via Git, test cmake_fetch_content_configure will fail. Please execute ctest -LE git_required to skip these tests. See issue #2189 for more information.

[nlohmann]

See https://github.com/nlohmann/json#execute-unit-tests

[kloczek]

I'm using as input source autogenerated from git tag tar ball.
Looking on the cmake files IMO if for example git command is not available those units should be skipped.

[nlohmann]

Does ctest -LE git_required work?

[kloczek]

Skipping failing units always works.
Tangling test procedure to git repo would be justifiable if project would provide some git related tools however in this case it is not the case.

[nlohmann]

The tests fail, because they require a Git checkout and test specifics of CMake in the context of Git. Hence we introduced the label so it is easy for you to skip them.

[kloczek]

Are you aware of fact that most of the distributions build infras are INTENTIONNALLY cut off from public network access?
Ho someone can test json without public network access.
And again: if some resources' are needed by test suite why they are not integrated in source tree?

[nlohmann]

Are you aware of fact that most of the distributions build infras are INTENTIONNALLY cut off from public network access? Ho someone can test json without public network access.

This is possible and documented here: https://github.com/nlohmann/json#execute-unit-tests

---

Note that during the ctest stage, several JSON test files are downloaded from an external repository. If policies forbid downloading artifacts during testing, you can download the files yourself and pass the directory with the test files via -DJSON_TestDataDirectory=path to CMake. Then, no Internet connectivity is required. See issue #2189 for more information.

---

And again: if some resources' are needed by test suite why they are not integrated in source tree?

We test CMake's FetchContent which, in our tests, needs the directory to come from a Git checkout. If you did not check out from Git, then you need to skip the test. The tests are for the maintainers and run in the CI. If you have a different setup and tests fail, all we can do is point you to the documentation.