nluetts/noisysignalintegration.jl

noisysignalintegration.jl's Issues

Add function to interpolate Curve on uniform grid

something similar to:

c = sort(Curve(dat.wavenumber, dat.absorbance))
δx = minimum(diff(c.x))
x_even = collect(minimum(c.x):δx:maximum(c.x))
interp = LinearInterpolation(c.x, c.y)
full_spectrum = Curve(x_even, interp(x_even))

Subtracting two curves yields MethodError

MethodError: -(::Curve{Float64}, ::Curve{Float64}) is ambiguous. Candidates:
  -(c::NoisySignalIntegration.AbstractCurve, y) in ...
  -(y, c::NoisySignalIntegration.AbstractCurve) in ...
Possible fix, define
  -(::NoisySignalIntegration.AbstractCurve, ::NoisySignalIntegration.AbstractCurve)

Areas in integral draws plot should have alternating color

local baseline should be defined by points weighted by integration bounds

Currently the local baseline starts and ends at the start and end point of the integration window of the particular draw. This can make the local baseline vary more than one would expect from a look at the spectrum. It would be better to weigh the y-values of the baseline by the spectral data using the distributions of the start and end point of the integration window.

Allow for pre-processing step

Perhaps add a callback function that runs before the integration in each MC draw.
For example, this would allow to apply a correction to a spectrum for each draw of the MC process.

UncertainSpectra use a lot of memory

Perhaps one can create spectral samples lazily?

Uninformative error message when trying to integrate outside of curve boundaries

This line

NoisySignalIntegration.jl/src/plotting.jl

Line 27 in 95c6533

) && throw(error("At least one integration bound is outside the support region ($(minimum(x)), $(maximum(x)))."))

references x while it should say xs. When the error is triggered, not the intended error message is shown but an uninformative UndefVarError.