nonews/nopermission

Android library for permissions request (updated 27.11.2017)

nopermission's Issues

Bug when close and reopen

Thanks for this class. The beauty of simplicity.

There seems to be a bug when showing the permission request to the user on the splash screen. If the user cleans his dialog and opens again the app, this secod time, the permissionHelper.check() method automatically executes 'success' and assumes to be granted, without showing the dialog again and without actually having the permission granted.

In this way, clearing the screen and reopening the app in the same point (i.e. moving the app to background and back to foreground) we can navigate the app skipping the dialogs until the final security crash.

Multiple request issue

When multiple permissions are requested at the same time, the 'onSuccess' listener is called ONCE only if ALL permissions are granted. I was expecting to have a call to 'onSuccess' for each granted permission, and 'onDenied' for each denied.

bug is in "onRequestPermissionsResult"

must run onSuccess on pre Build.VERSION_CODES.M

i think you must call successListener.onSuccess(); on pre Build.VERSION_CODES.M

https://github.com/NoNews/NoPermission/blob/master/library/src/main/java/ru/alexbykov/nopermission/PermissionHelper.java#L58

public void run() {
        if (isNeedAskPermission()) {

            if (successListener != null && failureListener != null && newerAskAgainListener != null) {
                activity.requestPermissions(permissions, PERMISSION_REQUEST_CODE);
            } else
                throw new RuntimeException("OnPermissionSuccessListener or OnPermissionFailureListener not implemented. Use methods: onSuccess and onFailure");
        } else if(successListener != null) {
                successListener.onSuccess();
        }
    }

Can request only one set of permissions at a time

Hi, sorry I have not replied sooner but this month has been a hell.

I found out another annoying issue. The code in android is here:

https://android.googlesource.com/platform/frameworks/base.git/+/master/core/java/android/app/Activity.java#4393

The fact is that, by adding permissionHelper.check(permission) calls on demand may not work if an app requests 2 permissions in the same activity onCreate (I suppose). This is a case for reeturning an empty array new String[0].

I suppose, the fix in this case is refactor the code :-(