notenoughupdates / notenoughupdates-repo Goto Github PK
View Code? Open in Web Editor NEWThis repository is used in order to store the various JSON files used for the Minecraft mod NotEnoughUpdates.
License: MIT License
This repository is used in order to store the various JSON files used for the Minecraft mod NotEnoughUpdates.
License: MIT License
Hi there!
NEU looks to this repository to load various items and recipes. When launching the mod, it looks like some items contain non-integer counts for items within recipes. This causes NumberFormatExceptions
(which are ultimately swallowed to prevent crashing). See below for an example:
[io.github.moulberry.notenoughupdates.NEUManager:loadItem:361]: internalName is : UMBER_PLATE
java.lang.NumberFormatException: For input string: "4.0"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Integer.parseInt(Integer.java:580)
at java.lang.Integer.parseInt(Integer.java:615)
at io.github.moulberry.notenoughupdates.recipes.Ingredient.<init>(Ingredient.java:45)
at io.github.moulberry.notenoughupdates.recipes.ForgeRecipe.parseForgeRecipe(ForgeRecipe.java:221)
at io.github.moulberry.notenoughupdates.recipes.RecipeType.createRecipe(RecipeType.java:65)
at io.github.moulberry.notenoughupdates.recipes.NeuRecipe.parseRecipe(NeuRecipe.java:79)
at io.github.moulberry.notenoughupdates.NEUManager.loadItem(NEUManager.java:313)
...
The Ingredient constructor fails to handle a count with a decimal part (even if this part is
.0`):
// Ingredient::init(NEUManager, String)
...
if (parts.length == 2) {
count = Integer.parseInt(parts[1]); // This fails if the count is 'integer-like' but with decimal parts (eg. '4.0').
}
...
UMBER_PLATE
looks to contain such values:
"inputs": [
"REFINED_UMBER:4.0",
"GLACITE_AMALGAMATION:1.0"
],
I would suggest that the fix for this bug would be to update the item recipes to remove the decimal part.
All the KARATE_FISH_
use the KARATE_FISH_SILVER
texture. Not sure why this is, just wanted to let you know.
Should "dungeon_item_level" in the NBT data of all dungeon items be changed to "upgrade_level" to match Hypixel's new system?
It would be really cool if you could add the HotM level requirement for all forge recipes that have a requirement (like this one).
This might be kind of weird though as some forge recipes require specific collections levels instead of or in combination with HotM level... Also things like Mole pet require fossils...
Sorry to be a bother, but we are still missing the item SULPHER_SKITTER_DIAMOND
.
This doesn't exist (even though I know it did at one point, that was over a year ago)
Tf is this thing?
The 'Jasper Crystal' should be in the category with the other crystals
The 5 Opal gemstone types should be grouped together like the other gemstones
Although this is kinda neat, why did the pristine enchant come up when I searched 'gemstone'? Nowhere in the lore is the word 'gemstone'
Suggestion: Change the mod to use the official wiki pages instead of the unofficial wiki
For example, https://hypixel-skyblock.fandom.com/wiki/Anubis, does this need to be added to the repo? all the nbt data is avaliable.
Hiya
Is there a reason that some items aren't in this list?
ender gauntlet lore says epic cloak instead of epic gloves (link)
While doing a simple scan I stumbled upon few items which were missing or could be better for the dataset
ENCHANTED_CARROT_STICK
to ENCHANTED_CARROT_ON_A_STICK
to match the ID moreThese were my only discovery so far =)
There are two items for Nether Bricks which both look like the nether brick block.
They have completely empty recipes, and pressing r on a nether brick (item) that you got by smelting netherrack (the ingot looking one) leads you to a recipe for one of the two.
Following Hub NPC's are missing in the REPO:
Billy Joe
Bobby Joe
Curator
Gladiator
Hootie
Hub Selector
Jim Bob
Minikloon
Mort
Salesman
Security Sloth
The Handler
I don't know if they were just forgotten or if this is on purpose how it is, so lmk :).
The slayer_req is missing for items from the enderman slayer.
Should it be EMAN_X or ENDERMAN_X (I intend to make a PR later today)
Is there any possibility of furnace recipes being added? I don't know if there are any custom furnace recipes on Hypixel, but Cactus Green not having a crafting recipe of Cactus in furnace, which has a cost of 0.9 makes the Windows Forms app I'm designing kind of break when an Enchanted Cactus costs -25,600 to buy, but sells for 25,028.77.
When you search for the book Bane of Arthropods VII, it always appear in default blue color
But the neuec is applied when looking at the Max Enchanted Book & on items, so i suppose it's only a repo issue
New weaponsmith items
Originally posted by @Strebbypatty in #547
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.