[BUG] Begin/End Select Problem

[RitzSpecial]

[BUG] Begin/End Select Problem

[alankilborn]

Version 8.5 also happens to be the first version where Ctrl+Shift+B was a keyboard shortcut for this command

As that was a change I made, I'll look into it. :-)

@donho Assign me, please.

[molsonkiko]

I did some bisection search, and it appears that this issue originated in version 8.5, meaning that the last version where the issue was not present was version 8.4.9.

Version 8.5 also happens to be the first version where Ctrl+Shift+B was a keyboard shortcut for this command, so probably this is some weirdness associated with that change.

[alankilborn]

It appears to be a difficulty with this line, added in #13034:

notepad-plus-plus/PowerEditor/src/ScintillaComponent/ScintillaEditView.cpp

Line 2796 in 6cd6aa3

execute(SCI_SETSELECTIONMODE, static_cast<WPARAM>(isColumnMode ? SC_SEL_RECTANGLE : SC_SEL_STREAM));

I suggest to eliminate that line and replace it with:

	if (isColumnMode)
	{
		execute(SCI_SETSELECTIONMODE, static_cast<WPARAM>(SC_SEL_RECTANGLE));
	}

[alankilborn]

It still feels like the original code should work, but clearly Scintilla doesn't like it.
Maybe @nyamatongwe has some suggestion on how this should be written so that moving the caret with an arrow key after deleting/cutting selected text doesn't create a selection.

[nyamatongwe]

https://www.scintilla.org/ScintillaDoc.html#SCI_CHANGESELECTIONMODE

[alankilborn]

SCI_CHANGESELECTIONMODE is a newer API I was unfamiliar with. But OK...

It still looks/feels a bit odd, but here's the code I'm thinking of proposing:

void ScintillaEditView::beginOrEndSelect(bool isColumnMode)
{
	auto currPos = execute(SCI_GETCURRENTPOS);
	
	if (_beginSelectPosition == -1)
	{
		_beginSelectPosition = currPos;
	}
	else
	{
		execute(SCI_CHANGESELECTIONMODE, static_cast<WPARAM>(isColumnMode ? SC_SEL_RECTANGLE : SC_SEL_STREAM));
		execute(isColumnMode ? SCI_SETANCHOR : SCI_SETSEL, 
			static_cast<WPARAM>(_beginSelectPosition), 
			static_cast<LPARAM>(currPos));
		_beginSelectPosition = -1;
	}
}