Giter Site home page Giter Site logo

Comments (14)

CennoxX avatar CennoxX commented on July 22, 2024 2

For me, this solution looks less busy than the status quo and seems to be a better than completely hiding the close button.

from notepad-plus-plus.

WildByDesign avatar WildByDesign commented on July 22, 2024 2

@donho

Could you try from your side to a transparent ico and use it to replace closeTabButton_inact.ico?

Yes, transparency is working perfectly and the icons that I am working on right now for close buttons are showing up sharp and nice at scaling 100, 125 and 150 so far.

I just have to nail down the exact measurements between those scaling scenarios for perfect consistency. They should be done tonight or tomorrow morning at the latest.

from notepad-plus-plus.

WildByDesign avatar WildByDesign commented on July 22, 2024 1

@alankilborn @CennoxX Can I please get your opinion on this?

I brought back the close buttons on the inactive tabs but made them dimmed to about 10%. I also added a little animation to the close button when actually closing a tab. These are very subtle changes but I really like them so far.

Animation

You may have to click to start the animated gif.

from notepad-plus-plus.

ozone10 avatar ozone10 commented on July 22, 2024 1

Notepad++ use LoadBitmap which I think does not support transparency, I will see what I can do.

from notepad-plus-plus.

alankilborn avatar alankilborn commented on July 22, 2024

The proposal is not a good one.
It would turn a one-step close action into a two-step action -- first have to activate the tab, then press the x.

Hmm, okay...hoving. Still, I'd have some amount of hover-delay, making the operation slower.

from notepad-plus-plus.

CennoxX avatar CennoxX commented on July 22, 2024

It would be better, if the x shows direct, when hovering above the tab, not the place, where I suspect the close button to come. And I think it has to be possible to deactivate this behaviour.

from notepad-plus-plus.

WildByDesign avatar WildByDesign commented on July 22, 2024

when hovering above the tab, not the place, where I suspect the close button to come

This is a very good point, I agree.

from notepad-plus-plus.

donho avatar donho commented on July 22, 2024

@WildByDesign
I will see if it's easy to be implemented. But I promise nothing.

from notepad-plus-plus.

donho avatar donho commented on July 22, 2024

@WildByDesign
Different from file state images (saved, dirty, RO & monitoring) on the document tab, close buttons are in BMP format.

After some googling, the bitmap support the transparency:
https://stackoverflow.com/questions/14195289/can-a-bmp-image-format-handle-transparency

So if you manage to create a transparent bmp and use it to replace closeTabButton_inact.bmp, and it does want you want visually, then this FR is feasible.
Could you try it and let me know the result please?

from notepad-plus-plus.

WildByDesign avatar WildByDesign commented on July 22, 2024

@donho

Could you try it and let me know the result please?

I just tried this morning with all formats of BMP transparency (A1:R5:G5:B5 (16 bpp), A4:R4:G4:B4 (16 bpp) and A8:R8:G8:B8 (32 bpp)) and they all failed to show the transparency. The two 16 bpp formats caused all of the close button icons to fail to function. The 32 bpp with alpha didn't cause the failure in functionality but did not show the transparency.

Also of note, Notepad++ has always had that built-in functionality with BMP icons to grab 1 pixel from a corner and automatically turn all pixels of that matching color into a layer of transparency. That works for all other BMP icons in Notepad++ but has never worked for the close button BMPs for some reason.

I have an idea based on what @CennoxX said above. This should come first before the icons but is related. We need to know which inactive tab the mouse is hovering over so that it can trigger a slightly brighter color. And as a future step, it could also potentially trigger an icon change.

Example inactive tab mouse hovering (from Firefox):

Animation
EDIT: You might have to click on it for animated GIF.

Is this possible?

from notepad-plus-plus.

donho avatar donho commented on July 22, 2024

@WildByDesign

Thanks to @ozone10 's PR (merged into the master), we can have this feature with codeless or less coding effort.

Could you try from your side to a transparent ico and use it to replace closeTabButton_inact.ico?
If it does work for you, then I will see how to make it as an option.

from notepad-plus-plus.

donho avatar donho commented on July 22, 2024

@WildByDesign
Take your time :)

When you're ready, please commit under the name "closeTabButton_hidden.ico" and also add the transparent icon in standard icon folder.

from notepad-plus-plus.

WildByDesign avatar WildByDesign commented on July 22, 2024

@donho I just submitted the PR (#15321) for the close buttons.

I will attach the hidden icons here separate from the PR because I think that we should only add them if you are able to add some sort of hover indication when hovering over the inactive tabs. For example, having the inactive tab turn a slightly lighter color as you hover the mouse over the inactive tabs and/or having the normal (unhidden) close button appear when hovering over any part of the inactive tab.

closeTabButton_hidden.zip

from notepad-plus-plus.

donho avatar donho commented on July 22, 2024

8e1f641

from notepad-plus-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.