Giter Site home page Giter Site logo

notion-enhancer / icons Goto Github PK

View Code? Open in Web Editor NEW
43.0 5.0 11.0 3.93 MB

a collection of custom icons for use with the notion-enhancer's "icon sets" integration

Home Page: https://notion-enhancer.github.io/advanced/icons

License: MIT License

JavaScript 100.00%
icons images emoji community notion notion-enhancer notion-icons page-icons icon-sets svg-icons

icons's People

Contributors

cloudhill avatar dragonwocky avatar fabiosangregorio avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

icons's Issues

Performance issues with large icons sets

PR #2 adds two sets of 200+ icons each. Since every icon currently corresponds to an HTTP request, the loading of these sets results in a bit of a perf issue and long loading times.

Maybe consider downloading the icons to the user's pc in the notion-enhancer installation folder and serve them from disk rather than directly from Github? The only downside of this is that the icon pack could change on the repo and not be updated on the user's side. Maybe refreshing it every once in a while (e.g. at start of notion-enhancer) could be a solution to this.

Another solution to this issue could be using a CSS sprite to load the icons, resulting in a single (even though larger) HTTP request. The downside to this is that this is a new "feature" that should be developed.

Let me think what you think.

Icon button missing in fullpage databases

"Icons" button is missing in fullpage databases when opening them by clicking on a linked database name.

Steps to reproduce:

  1. Have one full-page database in the sidebar root
  2. Have one page in the sidebar root
  3. Include a linked database linking to the db in step 1
  4. Click the name of the db in the top of the linked database
  5. Click on the emoji to try to change it. The button "icons" is missing.

Are you able to reproduce?

(Running on the latest dev build on win10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.