notquiteawake/smart-aircon

A smart system for air conditioners, built on Arduino.

smart-aircon's Issues

API Rename

The APIs should be renamed in an object-oriented manner.
For example:

request_* / check_* / *_req -> get_*
modify_* -> set_*

BarChart can be modified by swipes with proper implementation.

Possible reference:
https://www.jianshu.com/p/8bce70785b2f

Add turning on/off in the app

hardware.py issue

when directly executed, hardware.py won't run properly because there are only four params (out of 8 required) at the line

run(init_state, nxt_time, expdt, tempRec)

Add "Relay mode"

It's obvious that the idea is more feasible that the device should be packaged and used as an independent relay between user & real air conditioner. Code should be implemented to address the identification and recording of IR signals; A physical model should also be designed.

possible issue with python Multiprocessing.Manager

Secondary changes will not be synced unless manually assigned of its value again.
Reference at stackoverflow

User requirement and prediction are not separated.

This will cause problems when predicting next turn-on time

EditExpActivity Data Sync Issue

Data is only modified offline in the activity. It should be synchronized to the server to take effect.

EditExpActivity Crash Bug

When trying to modify the figures by clicking on a bar, the activity crashes because in line 109, index is always equal to -1, which results in an unexpected ArrayIndexOutOfBoundsException.

Use a database to store information

Add energy saving strategies

The air conditioner doesn't have to be turned on an hour before. The efficiency which time calculation depends on should be calculated by this formula:
Time = Abs(TurnOnTemp - ExpectedTemp) / ConditioningTime

Add a weighed mean method to calc exp temp

All users should have a share in deciding the temperature, so a weighed mean method should be added in addition to the current purely prioritized system.

Poor Interface

Interface is not designed to be used in an intuitive and interactive manner. Require rearrangement of items.

Encrypt the connection

Use encryption for communication to enhance data security.

connection leakage

Encountered the error:
W/OkHttpClient: A connection to (address) was leaked. Did you forget to close a response body?

"Description Label" on the chart

Consider removal.

Port settings should be a constant variable in the global scope.

This helps readability and reduced user's workload.

Expected temperature and next time should be treated separately

In server.py, line 64:

		elif task['cmd'] == 'modify_exp':
			if mutex.acquire():
				nxt_time.value = task['exp_time']
				exp[nxt_time.value] = task['exp_temp']
			mutex.release()
			return jsonify({'status': 1})

Code means it isn't able to receive data separately.

Window leakage leads to app crash

Logcat detail

com.ota.jimmychen.ota E/WindowManager: android.view.WindowLeaked: Activity com.ota.jimmychen.ota.MainActivity has leaked window DecorView@b7c1857[] that was originally added here
        at android.view.ViewRootImpl.<init>(ViewRootImpl.java:485)
        at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:346)
        at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:92)
        at android.app.Dialog.show(Dialog.java:330)
        at android.app.AlertDialog$Builder.show(AlertDialog.java:1114)
        at com.ota.jimmychen.ota.MainActivity$3.onClick(MainActivity.java:118)
        at android.view.View.performClick(View.java:6256)
        at android.view.View$PerformClick.run(View.java:24701)
        at android.os.Handler.handleCallback(Handler.java:789)
        at android.os.Handler.dispatchMessage(Handler.java:98)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6541)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)