novaway/elasticsearch-client

A lightweight PHP 7.0+ client for Elasticsearch, providing features over Elasticsearch-PHP

elasticsearch-client's Issues

Object Oriented queries on master branch

Port to the master branch changes made in #19 on branch 2.3 about Object Oriented queries.

Multiple filters don't work on 1.7 | Missing BoolFilter and BoolQuery support

As soon as the filterCollection has more than one filter set, the filtering doesn't seem to work on 1.7.

I was able to obtain the desired result by replacing

            $this->queryBody['query']['filtered']['filter'] = $this->filterCollection;

by

            if (count($this->filterCollection) > 1) {
                $this->queryBody['query']['filtered']['filter']['bool']['must'] = $this->filterCollection;
            } else {
                $this->queryBody['query']['filtered']['filter'] = $this->filterCollection;
            }

Which seem to indicate that a BoolFilter is a good solution to that problem.

I'm not convinced that this is a good solution to the problem at hand, it seems a bit too magical and rigid.

But we could use support for BoolFilter in this branch and BoolQuery in all branches.

Optional type parameter

elasticsearch-client/src/QueryExecutor.php

Lines 28 to 34 in c7bda2c

	public function execute(array $queryBody, string $type, ResultTransformer $resultTransformer = null): Result
	{
	return $this->index->search([
	'type' => $type,
	'body' => $queryBody
	], $resultTransformer);
	}

Do you think the parameter $type could be optional in order to make search over multiple types of document ? Or do you have another way to do such kind of search ?

Add dedicated documentation for GeoDistance filtering

Regarding this PR comment : https://github.com/novaway/elasticsearch-client/pull/24/files/f7a501162914c4827b9ccb812ae09b394177cd97#r154044634

Update the release tags

The release tags are not up to date, it could be interesting to follow the ES versions, the way elasticsearch-php does.

It would make it easier to know which version of the lib to use with the version of ES used.

Make distance unit a parameter in GeoDistanceFilter.php

GeoDistanceFilter.php currently has "km" as an hardcoded value for distance unit.

It would be useful to have a parameter.

Update master branch with GeoFilters

PR #24 add Geofilters on ES2.3, this need to be ported to ES5