novemberborn/eslint-plugin-as-i-preach

ESLint to @novemberborn’s taste

eslint-plugin-as-i-preach's Issues

Let consuming packages configure which language features they're targetting

babel/object-shorthand can't be used since it breaks code that directly targets Node 0.10. Such rules should be configurable, not directly but by letting packages disable language features they can't rely on.

E.g.:

"as-i-preach": {
  "features": {
    "object-shorthand": false
  }
}

Enable max-len

http://eslint.org/docs/rules/max-len

Set tabWidth to 2, maximum length to 120. Need to play with the other options.

Warn for TODO, FIXME etc

Warn for TODO and related comments, like xo.

An in-range update of nyc is breaking the build 🚨

Version 10.1.0 of nyc just got published.

Branch	Build failing 🚨
Dependency	nyc
Current Version	10.0.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As nyc is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

---

Status Details

• ❌ continuous-integration/travis-ci/push The Travis CI build failed Details

• ✅ coverage/coveralls First build on greenkeeper/nyc-10.1.0 at 100.0% Details

Commits

The new version differs by 14 commits .

• 8f7af3a chore(release): 10.1.0
• 8c58d68 fix: address edge-cases related to --all when instrumentation is disabled (#482)
• 8b58c05 feat: allow eager instantiation of instrumenter (#490)
• d8d2de0 feat: upgrade to istanbul-lib-instrument with support for 'const foo = function () {}' name preservation. upgrade to istanbul-lib-hook with fix for ts-node. (#494)
• 7708235 chore: add test and docs for high and low watermarks (#493)
• 0a1d72a feat: reporting watermarks can now be set in nyc config stanza (#469)
• 1022b16 fix: pass configuration options to --check-coverage (#483)
• 7b4c090 chore(package): update tap to version 9.0.3 (#488)
• 093963b chore(release): 10.0.2
• e01ec8c fix: upgrade to newer istanbul-lib-instrument, with fixes for inferred function names (#479)
• 2e39e00 chore(release): 10.0.1
• e0ef1d5 fix: upgrade spawn-wrap and istanbul-lib-instrument (#477)
• 8603aa9 chore(package): update is-windows to version 1.0.0 (#466)
• 64ae4f3 chore(package): update standard-version to version 4.0.0 (#461)

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

---

Your Greenkeeper Bot 🌴

Enable eslint-plugin-node/no-unsupported-features

Implement https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-unsupported-features.md.

Need to figure out the best way of configuring the rule, especially for projects that transpile their source prior to publishing.

Remove unicorn/no-array-instanceof

sindresorhus/eslint-plugin-unicorn#136.

Enable no-useless-return

http://eslint.org/docs/rules/no-useless-return