Comments (5)
This has been improved slightly by #75 - now, all 2xx response codes mean that Merlin has an internet connection.
from merlin.
You've just bundled two questions into one.
First point - yes.
Second point - overkill but yes.
from merlin.
I've renamed the issue and retagged as a bug.
Should it be all responses except from the 300 range that indicate a connection?
from merlin.
that might create false positives?
The perfect solution would be to switch to using the underlying unix "ping" command and ping one of the standard dns servers such as 4.2.2.2 although it is very hacky
from merlin.
fixed in #77
worth creating a new issue for the fallback @ataulm ?
from merlin.
Related Issues (20)
- Manifest Unresolved Class error on Service HOT 4
- Expand the Merlin demo
- Technical Data Questionnaire Wiki Page HOT 1
- Fatal Exception: java.util.ConcurrentModificationException HOT 5
- The onConnected event fires when first run it HOT 3
- IllegalStateException - You must call canNotify() before calling notify(ConnectivityChangeEvent)
- Android 9.0 Testing HOT 4
- Remove releases folder from repo HOT 1
- Integration tests
- not getting Wifi connected callback HOT 1
- java.lang.NoClassDefFoundError: on API 28 App crashes HOT 5
- Not working in One plus 5t HOT 6
- Mobile connection type enhancements
- Only disconnect is fired when switching from say wifi to mobile connection HOT 6
- Crash HOT 14
- registerConnectable is not able to work after flight mode for a while
- Custom RequestMaker HOT 2
- NPE on ConnectivityCallbacks.notifyMerlinService HOT 1
- How to get internet speed ?
- Migrate from JCenter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from merlin.