novus/rugu

A scala dsl for ssh.

rugu's Issues

provide a way to specify timeouts for both connect and execution

OverShell, :> and :>>

This is a real concurrency issue. If you specify ovr("ls" :> "out") (or :>>), where ovr is an OverShell instance for N connections, then write attempts will conflict from the different worker threads.

Error output should not be swallowed

Related to #2, if an explicit handling function is provided through exec, it should be run with access to the error stream of the command.

public key auth

indefinite read attempt on result stream can hang

There seems to be a threading issue in Jsch, where Jsch instances themselves are not thread-safe (we aren't mutexing connections, but a Jsch instance provides fresh sessions which are kept in a single thread). It's been tough to reproduce this; specs2 tests sbt w/ sbt test parallelization disabled results in sporadic hangs unless specs parallelization is disabled in the spec itself. I've failed to reproduce this yet in a straight up j.u.c scenario (https://gist.github.com/1176662), but it the issue seems to be JSch.

sshj is worth evaluating. It seems cleaner, thread-safe, and much more active.

as noted in the code, connection errors bubble up instead being trapped as Lefts

It should be possible to trap non-zero exit statuses through SshSession#exec

OverShell liveness seems to degrade linearly

It seems that an overshell gets slower with more underlying instances. A thread dump revealed the following; it's quite possible that threads contend for blocking reads on the system's random generator (more threads, more contentions):

"pool-6-thread-11" prio=10 tid=0x000000004190d000 nid=0x6e88 waiting for monitor entry [0x00007f56810af000]
java.lang.Thread.State: BLOCKED (on object monitor)
at sun.security.provider.NativePRNG$RandomIO.implGenerateSeed(NativePRNG.java:201)
- waiting to lock <0x00000000f7a02de8> (a java.lang.Object)
at sun.security.provider.NativePRNG$RandomIO.access$300(NativePRNG.java:108)
at sun.security.provider.NativePRNG.engineGenerateSeed(NativePRNG.java:102)
at java.security.SecureRandom.generateSeed(SecureRandom.java:495)
at net.schmizz.sshj.transport.random.BouncyCastleRandom.(BouncyCastleRandom.java:65)

Exceptions in handler functions explode and orphan resources

in a REPL session the console became unresponsive; possibly a deadlock in jsch. Trap any exceptions in handlers and propagate as Lefts

Include test.properties in git

Hey there Chris,

@splittingfield here.

I just pulled the rugu git repository and tried to run the tests and noticed that the test.properties file required
for RemoteCommandSpec.scala is not included in the repository.

Feel free to reach me via email [email protected].

Take care,
m

OverShell#download

OverShell downloads from multiple hosts will conflict. This can be handled by a transformation of the file name per host.

scp