nrctkno/sgphpengineeringchallenge

This is a small engineering challenge that will test the skill and experience of an engineer's ability to write quality features and unit tests for a common engineering task of taking data from one place and storing it another place.

sgphpengineeringchallenge's Issues

Slow database

Replace SQLite by a concurrent DB server

Move data folder to ./var

Reason: data files are volatile and environment-dependant.

Make "products to import" partitions size customizable

In file src\MessageHandler\SplitProductsFileHandler.php the file size is a constant. It must be an ENV setting.

Create ProductImportTask entity

Create the domain entity.
Add the required logic to track the progress.
Add html view to query the progress.

I.E:

Created at, filename, records found, records processed
A datetime, a hashed filename, 1000, 900

Move the fake creator outside the domain

https://github.com/nrctkno/MinutentagChallenge/blob/master/domain/Product/Mock/FakeJSONFileCreator.php

Nothing to do with the domain.

Create integration tests

To verify domain jobs behavior. It'll require to implement mock repositories/readers/services.

Improve non-synced exporting process

Considering that in edge cases the exported file can have thousands of products to sync, it´s imperative to apply a divide-and-conquer strategy like the one implemented for importing products. It´s assumed that the export order is not important, so the process can be easily parallelized too.

Research about money-bundle

I've omitted the usage of kucharovic/money-bundle to maximize the delivery of results. However it must have something positive.

Uploaded products file, hash filename

To avoid collisions