nrohmen/clean-android-code

MVP + Dagger 2 + RxJava + Retrofit2

clean-android-code's Issues

getListSuccess() in Homeresenter.java need update to getCityListSuccess

Hi, I just find a bug that the getListSuccess() in Homeresenter.java should be GetCityListSyccess()

No Unit tests ?

A great reason for using Dagger and an architecture is to facilitate unit-testing.
How come you've skipped unit tests ?

Excellent demo code otherwise

Question

hi guys,i am Chinese student. My english is poor
Can you explain to me why you write like this
I have never met this kind of writing

Please help me, thank you very much.

Please explain, or add link to references

Here I'd like to point out that your Medium tutorial is not a tutorial by itself, at the moment it's just a bunch of code mirrored from GitHub. Mind you, I'm not telling this for the sake of blaming your (hard) job, but as you have pointed out at the end of the post, you didn't explain a lot of niches.

"I am so sorry, because I can’t explain this tutorial clearly."

So I'm opening this issue to invite the community to contribute with guided comments or links. Have a nice day!

How to set Multiple BaseURL ?

I have currently 4 different baseurl for different things in API call so how do I set all of them depends on requirement?

Resolve DaggerDeps

import com.plaps.androidcleancode.deps.DaggerDeps;

import com.plaps.androidcleancode.deps.Deps;
import com.plaps.androidcleancode.networking.NetworkModule;

import java.io.File;

/**

• Created by ennur on 6/28/16.
  */
  public class BaseApp extends AppCompatActivity{
  Deps deps;

  @OverRide
  public void onCreate(Bundle savedInstanceState) {
  super.onCreate(savedInstanceState);
  File cacheFile = new File(getCacheDir(), "responses");

deps = DaggerDeps.builder().networkModule(new NetworkModule(cacheFile)).build();

}

public Deps getDeps() {
    return deps;
}

}

How to resolve DaggerDeps ?

Nothing is shown

Hello.
I made everything like in https://medium.com/@nurrohman/a-simple-android-apps-with-mvp-dagger-rxjava-and-retrofit-4edb214a66d7. Launched an application and received a white screen with blue toolbar. No cities are shown.

Dagger Related question

In HomeActivity, can't we initialize HomePresenter via Dagger instead of directly using "new" operator,
as Definition of Dependancy Injection, there will you not be an explicit initialization of the object, please clear my doubt, I am confused here.