Giter Site home page Giter Site logo

Comments (32)

bradmartin avatar bradmartin commented on May 22, 2024 4

Hardly the case :) I'm a code thief drifting thru this life

from nativescript-cardview.

bradmartin avatar bradmartin commented on May 22, 2024 3

NativeScript/NativeScript#4728 (comment)

from nativescript-cardview.

SP1966 avatar SP1966 commented on May 22, 2024 3

@bradmartin What does it feel like being a rockstar? Us plebes would like to know!

from nativescript-cardview.

ivanwitzke avatar ivanwitzke commented on May 22, 2024 2

Slightly different from the example, but yes...

import { registerElement } from 'nativescript-angular/element-registry';
registerElement("CardView", () => require("nativescript-cardview").CardView);

from nativescript-cardview.

bradmartin avatar bradmartin commented on May 22, 2024 2

from nativescript-cardview.

davorpeic avatar davorpeic commented on May 22, 2024 1

Hey @bradmartin I will post here as the topic is more active, but I have issues with fab. But in my case it is funny as I experience this issue only when I run the app from one machine of my colleague, if I run it on mine then I see the button both in simulator (android 7) and on test device (android 6), if he runs the app on the same device then we get this error related with background-color.

The app is the same and node_modules have same versions, so my assumption is that it could be related with maybe some difference in android sdk packages used to build, I will do further comparison later to try to find out what is different and if issue get fixed

from nativescript-cardview.

bradmartin avatar bradmartin commented on May 22, 2024 1

Did you remove and add the platform after changing the core modules?

from nativescript-cardview.

bradmartin avatar bradmartin commented on May 22, 2024

Did you registerElement as outlined here https://github.com/bradmartin/nativescript-cardview/blob/master/README.md#angular-nativescript ? That might be your issue

from nativescript-cardview.

noordw avatar noordw commented on May 22, 2024

Yes I am getting the same on Android only

from nativescript-cardview.

jibon57 avatar jibon57 commented on May 22, 2024

Yes, I am facing same problem with webpack. But without webpack it just fine. @bradmartin Will you please check it with webpack?

JS: ERROR TypeError: Cannot read property 'newDrawable' of null
Running webpack for android...

from nativescript-cardview.

noordw avatar noordw commented on May 22, 2024

I'm Thinking it might be related to

NativeScript/NativeScript#4633
which is also similar to the issue with background-colour on IOS
#58 using css class parameter breaks iOS when navigating

from nativescript-cardview.

SP1966 avatar SP1966 commented on May 22, 2024

I believe that the same issue is affecting nativescript-floatingactionbutton:
nstudio/nativescript-floatingactionbutton#57

In both cases, cardview and floatingactionbutton if the background-color is set in CSS the app crashes. Remove the CSS and all is well, except the background-color is wrong! :)

from nativescript-cardview.

jibon57 avatar jibon57 commented on May 22, 2024

@SP1966 @noordw but if you try with webpack, you will see it won't work.

from nativescript-cardview.

noordw avatar noordw commented on May 22, 2024

Just tested you are right, get rid of backgroundColour and it works. At least that lets me keep working until someone figures it out.

Thanks

from nativescript-cardview.

smarza avatar smarza commented on May 22, 2024

Removing the backgroundColour worked for me too.

In my tests:

  • IOS worked with backgroundColour.
  • Android only worked without backgroundColour.

So, I created separated html files for both platforms. For now everything is fine.

Thanks guys.

from nativescript-cardview.

bradmartin avatar bradmartin commented on May 22, 2024

Anyone care to share their package.json? Also this seems like a recent issue since cardview hasn't been updated in awhile.

from nativescript-cardview.

noordw avatar noordw commented on May 22, 2024

It is new, Mine broke updating to 3.x

{
"description": "Xxxxxx",
"license": "SEE LICENSE IN ",
"readme": "Trinoor Application",
"repository": "",
"nativescript": {
"id": "com.trinoor.TASeA",
"tns-android": {
"version": "3.1.1"
},
"tns-ios": {
"version": "3.2.0-2017-7-28-1"
}
},
"dependencies": {
"@angular/animations": "~4.2.5",
"@angular/common": "~4.2.5",
"@angular/compiler": "~4.2.5",
"@angular/core": "~4.2.5",
"@angular/forms": "~4.2.5",
"@angular/http": "~4.2.5",
"@angular/platform-browser": "~4.2.5",
"@angular/platform-browser-dynamic": "~4.2.5",
"@angular/router": "~4.2.5",
"@angular/upgrade": "~4.2.5",
"@ngrx/core": "^1.2.0",
"@ngrx/effects": "^4.0.2",
"@ngrx/store": "^4.0.2",
"lodash": "^4.17.4",
"nativescript-angular": "^4.3.0-2017-8-10-8",
"nativescript-barcodescanner": "^2.6.1",
"nativescript-cardview": "^2.0.2",
"nativescript-checkbox": "^2.1.11",
"nativescript-exit": "^1.0.1",
"nativescript-feedback": "^1.0.6",
"nativescript-i18n": "^0.2.2",
"nativescript-intl": "^3.0.0",
"nativescript-localstorage": "^1.1.5",
"nativescript-ngx-fonticon": "^2.2.3-master-12",
"nativescript-sqlite": "^1.1.7",
"nativescript-theme-core": "~1.0.2",
"nativescript-themes": "^1.1.0",
"reflect-metadata": "~0.1.8",
"rxjs": "^5.4.2",
"tns-core-modules": "^3.1.1",
"zone.js": "~0.8.2"
},
"devDependencies": {
"babel-traverse": "6.25.0",
"babel-types": "6.25.0",
"babylon": "6.17.4",
"lazy": "1.0.11",
"nativescript-dev-typescript": "^0.5.0",
"typescript": "^2.4.2"
},
"nativescript-i18n": {
"customLangPath": "app/resources/i18n"
}
}

from nativescript-cardview.

smarza avatar smarza commented on May 22, 2024

@bradmartin

...
    "tns-ios": {
      "version": "3.2.0-2017-7-5-5"
    },
    "tns-android": {
      "version": "3.2.0-2017-8-10-1"
    }
  },
  "dependencies": {
    "@angular/animations": "~4.3.2",
    "@angular/common": "~4.3.2",
    "@angular/compiler": "~4.3.2",
    "@angular/core": "~4.3.2",
    "@angular/forms": "~4.3.2",
    "@angular/http": "~4.3.2",
    "@angular/platform-browser": "~4.3.2",
    "@angular/router": "~4.3.2",
    "angular2-uuid": "^1.1.1",
    "nativescript-angular": "next",
    "nativescript-appversion": "^1.4.1",
    "nativescript-audio": "^3.5.0",
    "nativescript-cardview": "^2.0.2",
    "nativescript-geolocation": "^3.0.0",
    "nativescript-loading-indicator": "^2.3.2",
    "nativescript-local-notifications": "^1.2.1",
    "nativescript-localstorage": "^1.1.5",
    "nativescript-plugin-firebase": "4.0.3",
    "nativescript-pulltorefresh": "^2.0.2",
    "nativescript-ripple": "^2.0.0",
    "nativescript-social-share": "^1.3.2",
    "nativescript-telerik-ui": "^3.0.4",
    "nativescript-theme-core": "^1.0.4",
    "nativescript-toast": "^1.4.6",
    "nativescript-zip": "^1.3.2",
    "ngx-pipes": "^1.6.1",
    "reflect-metadata": "~0.1.8",
    "rxjs": "~5.3.0",
    "tns-core-modules": "^3.0.1",
    "zone.js": "~0.8.16"
  },
  "devDependencies": {
    "@angular/compiler-cli": "~4.3.2",
    "@ngtools/webpack": "^1.4.1",
    "babel-traverse": "6.25.0",
    "babel-types": "6.25.0",
    "babylon": "6.4.5",
    "copy-webpack-plugin": "^4.0.1",
    "extract-text-webpack-plugin": "^2.1.2",
    "lazy": "1.0.11",
    "nativescript-css-loader": "^0.26.1",
    "nativescript-dev-typescript": "~0.4.0",
    "nativescript-dev-webpack": "^0.6.3",
    "raw-loader": "^0.5.1",
    "resolve-url-loader": "^2.0.3",
    "typescript": "~2.3.4",
    "webpack": "^3.0.0",
    "webpack-sources": "^1.0.1"
  },
...

from nativescript-cardview.

noordw avatar noordw commented on May 22, 2024

Fixed by
import { NativeScriptI18nModule } from "nativescript-i18n/angular"
to
require("nativescript-i18n");
and removing from imports

from nativescript-cardview.

SP1966 avatar SP1966 commented on May 22, 2024

Here is my package.json:

"nativescript": {
"id": "org.nativescript.PPM",
"tns-android": {
"version": "3.1.1"
},
"tns-ios": {
"version": "3.1.0"
}
},
"dependencies": {
"@angular/animations": "~4.2.3",
"@angular/common": "~4.2.3",
"@angular/compiler": "~4.2.3",
"@angular/core": "~4.2.3",
"@angular/forms": "~4.2.3",
"@angular/http": "~4.2.3",
"@angular/platform-browser": "~4.2.3",
"@angular/router": "~4.2.3",
"@ngrx/core": "^1.2.0",
"@ngrx/effects": "^4.0.2",
"@ngrx/store": "^4.0.2",
"nativescript-angular": "^4.2.0",
"nativescript-camera": "^3.0.1",
"nativescript-cardview": "^2.0.2",
"nativescript-drop-down": "^3.1.1",
"nativescript-floatingactionbutton": "^3.0.1",
"nativescript-gradient": "^2.0.0",
"nativescript-material-icons": "^1.0.3",
"nativescript-ngx-fonticon": "^2.2.3",
"nativescript-telerik-ui": "3.0.4",
"reflect-metadata": "~0.1.10",
"rxjs": "^5.4.0",
"tns-core-modules": "^3.1.1",
"zone.js": "~0.8.2"
},
"devDependencies": {
"babel-traverse": "6.24.1",
"babel-types": "6.24.1",
"babylon": "6.17.0",
"husky": "^0.14.3",
"lazy": "1.0.11",
"lint-staged": "^4.0.1",
"nativescript-dev-sass": "^1.1.1",
"nativescript-dev-typescript": "~0.4.5",
"prettier": "^1.5.2",
"typescript": "~2.2.1"
},
"scripts": {
"precommit": "lint-staged"
},
"lint-staged": {
"*.ts": ["prettier --write", "git add"]
},

from nativescript-cardview.

bradmartin avatar bradmartin commented on May 22, 2024

from nativescript-cardview.

jibon57 avatar jibon57 commented on May 22, 2024

@bradmartin by removing background-color CSS property also solved webpack issue :)

from nativescript-cardview.

bradmartin avatar bradmartin commented on May 22, 2024

Sounds good, thanks @davorpeic I have both UI components inside apps using the latest versions of NS and the plugins. So it does seem build related. Keep us posted 👍

from nativescript-cardview.

manijak avatar manijak commented on May 22, 2024

I am running vanilla TNS 3.1.3 with JS, and also get this issue. I don't get a stacktrace like others, just a white screen with the text: cannot read property newDrawable of null, undefined

Highest android sdk version I have is 25 (7.1.1).

from nativescript-cardview.

davorpeic avatar davorpeic commented on May 22, 2024

Ok, so I think I found the source of getting my error for FAB. The only difference my app had compared to other pc was in tns-core-modules, after doing npm update I got the same error as Manijak.

Reverting to "tns-core-modules": "3.1.0", fixed the issue with backgroundColor="red" on my FAB button. I see that they did some update in relation to background color,not sure if this could be issue.

from nativescript-cardview.

SP1966 avatar SP1966 commented on May 22, 2024

@davorpeic

I switched tns-core-modules to 3.1.0 from 3.1.1 and I'm still getting the error. This stuff is way over my head!

from nativescript-cardview.

SP1966 avatar SP1966 commented on May 22, 2024

Yes. In fact I also dropped back from nativescript-angular 4.2.0 to 3.1.3 alternately and that wasn't it either.

from nativescript-cardview.

shiv19 avatar shiv19 commented on May 22, 2024

Facing the same problem on vanilla nativescript

from nativescript-cardview.

deepak4u2006 avatar deepak4u2006 commented on May 22, 2024

Still removing background-Color from css is working in Android

from nativescript-cardview.

mrkorsar avatar mrkorsar commented on May 22, 2024

What I must do to get 3.2 ? I tried the command "tns update" and this didn't help

from nativescript-cardview.

bradmartin avatar bradmartin commented on May 22, 2024

from nativescript-cardview.

bradmartin avatar bradmartin commented on May 22, 2024

I've updated the demo to 3.2.0 and all works fine in the demo. Is there a use case that still throws an error for anyone?

from nativescript-cardview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.