ntaklive/backupmod

A 7 days to die modlet which makes it possible to automatically backup and restore your game saves

backupmod's Issues

JSON format incorrect

Backup is not listening to the settings.json file for location and frequency of backups or archive, and when I start my server I get the attached error. I have disabled EAC in the server settings before opening this issue, but it still persists.

error starting server

error thrown
https://pastebin.com/RiwQ2uRB

settings config
https://pastebin.com/N8yrahFk

not sure what gives, is it broken since the latest update a couple days ago?

i have my mods in this folder since they will be removing it from the 7 days to die install folder soon.
C:\Users\jessi\AppData\Roaming\7DaysToDie\Mods

Help Text Missing

Request

Command Panel Help Text would benefit BackupMod for purposes of quick reference and command discovery.

NOTE: I am submitting a Merge Request with a proposed solution for this; link to be attached in comment/issue.

Context

The standard for most 7DTD Console Commands it to include help text when running help <command>; this can be very helpful for reference or even real-time discovery of new mod features.

I noticed this is not included in BackupMod even though a description of commands is provided in README.md's Commands section.

Example of Help Output

help teleport
*** Command: teleport ***
Usage:
  1. teleport <x> <y> <z> [view direction]
  2. teleport <x> <z> [view direction]
  3. teleport <target steam id / player name / entity id>
  4. teleport offset <inc x> <inc y> <inc z>
For 1. and 2.: view direction is an optional specifier to select the direction you want to look into
after teleporting. This can be either of n, ne, e, se, s, sw, w, nw or north, northeast, etc.
1. Teleports the local player to the specified location. Use y = -1 to spawn on ground.
2. Same as 1 but always spawn on ground.
3. Teleports to the location of the given player
4. Teleport the local player to the position calculated by his current position and the given offsets

Instructions on Help Syntax Standards

Running help (without any params) in the console will produce the list of all available console commands... but at the very beginning of that output, it will also explain expectations around the symbols you'll see in the Help command:

help
*** Generic Console Help ***
To get further help on a specific topic or command type (without the brackets)
    help <topic / command>

Generic notation of command parameters:
   <param name>              Required parameter
   <entityId / player name>  Possible types of parameter values
   [param name]              Optional parameter

*** List of Commands ***
 [lists all commands on the following lines]

[v2.1.2] bp restore is not working in single game and main menu

I met this message
[This command cannot executed on an active world save. Try to another parameters]

The mod is only saving on Game load

The mod is only saving backups on game load.
Even with EAC disabled i dont get the chat notifications of the backups every 10min (as default by the json file) not do i get the files themselves.

AutoBackup.Delay option doesn't account for how long the actual backup takes

For example, I have AutoBackup.Delay set to 300 (5 minutes). Assume that an auto-backup happens at 17:00:00 and takes 20 seconds to complete.

What should happen is that the next auto-backup occurs at 17:05:00.
What actually happens is that it occurs at 17:05:20, because the previous backup took 20 seconds to complete.

If that second backup takes 30 seconds to complete, then the next backup will occur at 17:10:50, instead of 17:10:00.

With a minimal reading of the code, my suggestion is that AutoBackupProcess.BackupAsync should return a TimeSpan of how long the actual backup process took, and the Task.Delay call in AutoBackupProcess.StartAsync should change to wait for _delay - (duration of previous BackupAsync call) instead of just _delay.

"Collection was modified; enumeration operation may not execute" InvalidOperationException during auto-backup

Version: Alpha 20.5 (b2) with Undead Legacy 2.5.82; BackupMod 2.1.3

Wasn't doing anything special, just tooling around a random world.

System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
at System.Collections.Generic.Dictionary`2+KeyCollection+Enumeration[TKey,TValue].MoveNext()
at EntityBuffs.Write(System.IO.BinaryWriter, bool)
at PlayerDataFile.FromPlayer(EntityPlayer)
at BackupMod.Services.WorldSaveAlgorithm.SavePrimaryPlayerData()

Unfortunately I cannot provide the complete stack trace as (AFAIK) 7DtD does not provide a mechanism to dump the console contents to a file; the above is manually typed out by myself, I think that is the most pertinent info.