nuarig/competitions

Competitions is a platform to support robust peer review within and across CTSA hubs. This is a cloud-based, single-sign on application for investigators, reviewers and administrators. With Competitions, you can post opportunities, submit applications and review and score those submissions

competitions's Issues

add select2 gem

To prevent dropdown menus from becoming too annoying, we should add the select2 gem.

Add PaperTrail versions tables for FormBuilder models

Related to #68

move methods into decorators

Move methods from controllers and models into decorators that are better suited there.

Known methods are:
app/models/user.rb
name
app/controllers/grants/grant_users_controller.rb
unassigned_users_by_grant

Also look for any other methods that would better fit in a decorator.

7. add papertrail to submissions

Add papertrail tracking to submissions.

Revisit grant_user_policy

Is this necessary. GrantUser authorizations are using grant_policy.

Pundit- Submission::Form policy for Admin Role

• Building Submission Forms
  • Pundit Policy Config
    • Admin
      • Unpublished
        • Can create
        • Can Edit
        • Can view (once assigned to grant)
      • Published
        • No existing submissions
          • Can not Edit (until unpublished)
          • Can unpublish (available?)
          • Can view (once assigned to grant)
          • Cannot delete
        • With Existing Submissions
          • Can not Edit
          • Cannot unpublish
          • Can view (once assigned to grant)
          • Cannot delete

Submission

Grant index

Implement Grant short_name in URLs

Change _std_ to _standard_ in form_builder tables and models

Related to #68

Update table and model names:

• form_builder_std_answer_set
• form_builder_std_answer

link Apply button to Matt's submission code

Ensure grants always have an associated admin or editor

A user should not be able to delete the last admin

2. Responses: Single table inheritance models

Responses

Submission is link between user and grant they're submitting to
Questions are associated with the grant
Submission is a collection of responses
Place to store all responses

Single table inheritance models
Response model (integer, float, string)
Associated controllers
Views
Validation

Determine whether to migrate FormBuilder::StandardAnswers and StandardAnswerSets

Related to #68

Pundit- Submission::Form policy for Viewer Role

• Building Submission Forms
  • Pundit Policy Config
    • Viewer
      • Unpublished
        • Can view (once assigned to grant)
      • Published
        • No existing submissions
          • Can view (once assigned to grant)
          • Cannot delete
        • With Existing Submissions
          • Can view (once assigned to grant)
          • Cannot delete

Refactor: Pull partials out of original FormBuilder views

Clean up nested logic

5. Responses: Views

Review whether display_order is required in form_builder grant_survey table

Related to #68

Unless something changes, Grant will only have one survey, display_order is not needed.

6. Active Storage/doc upload

Separate fields and constraint migrations

Move create_table :constraints to its own migration. See: 20190121175254_create_fields_and_constraints.rb

Update load_grants task to include review_[open/close]_date

2c. Response: Single table inheritance: float model

4. Responses: Associated controllers

rules for grant state changes (draft, publish, etc)

E.g.,
Shouldn't see delete button if can't delete
Shouldn't see draft button if you can't make it a draft

Process:

1. Begin creating grant
2. Choose Save as Draft or Save and Publish
3. If draft, stays draft. If it's published also check Publish Date

Can you edit a published grant?
Yes
Can you edit a published grant with submissions?
Yes

5 STATES:

1. Demo--yes, make it like Study Tracker's STUXXXXXXX with limited access
2. Draft--yes
3. Published--yes
   Open and Closed are descriptors of the grant, not states
4. Completed--Grant has been awarded, grant creator fills in the amount was awarded and to whom
5. Archived--Old grants that people don't need to see all the time, automatically happens 180 days after panel review date or input award amount

Grant duplicate

1. Responses: Response model

2a. Response: Single table inheritance: string model

Update decimal precision in form_builder tables

Related to #68

Review decimal precision in the following form_builder tables:

• form_builder_std_answer_sets
  • version
• form_builder_responses
  • decimal_val

Front end - edits

• Convert to HAML (timebox to 30 min) @nutodd will be using a stopwatch
• Convert from Bootstrap to Foundation

homepage

2b. Response: Single table inheritance: integer model

8. Prevent users from updating/deleting submitted submissions

A user should not be able to update or delete a submission once its state has been changed to submitted.

3. Responses: Validation

Start using keyword parameters

Change Response model to only have one text_value

write tests off of the question.

Question
def check_whether_required?
Should this only be if response_value: empty?
Figure out where this goes
don't need its own method. response.question.required

def validate_response(response_value:)
set error messages(open structs)
This is where the def upper and lower bound validations get called.
It takes the name of the constraint and then knows which of the methods to call in the Constraint model, where there will be 2 methods one for the upper and one for the lower value, using send.

TypeQuestions
def is_correct_type?(response_value:)
define error messages

def translate(response_value:)
check if value exists
check type matches
cast the response_value

TypeConstraints
def upper and lower bounds validations(constraint_question_value:, response_value:)
ex. IntegerConstraint - def validate_maximum_value(cq_value:, translated_response_value)

Response
def validate_against_constraint
error handling
calls self.quetion.validate_response(value: self.value)

Random questions
If not required accept empty or set a default of not answered (set constant?)
Maybe this can be handled within response. (question.required?)

Question combines all error messages from constraints(service?)

Confirm unique combination of question and constraint in constraint_questions.

Create Grant validation on 'Publish' for Submission::Form

• Submission::Form must be attached to Grant before Grant can be published.
• Ensure form relates back to Grant

Change policies to incorporate the role concern

The policies for grant access will need to be revisited to match the new WithGrantRoles concern.

This is related to issue #21.

Update ResponseSet controller

Properly route the user -- e.g. create and update actions currently route to ResponseSet index.

Pundit- Submission::Form policy for Editor Role

• Building Submission Forms
  • Pundit Policy Config
    • Editor
      • Unpublished
        • Can create
        • Can Edit
        • Can view (once assigned to grant)
      • Published
        • No existing submissions
          • Can not Edit (until unpublished)
          • Can unpublish (available?)
          • Can view (once assigned to grant)
          • Cannot delete
        • With Existing Submissions
          • Can not Edit
          • Cannot unpublish
          • Can view (once assigned to grant)
          • Cannot delete

FSM host

Firas, can you please comment?

Hello Laura and all,

Here is the estimate of the AWS hosting cost (about $125/month or $1500/year (two VMs + secure transit connection back to campus). Usually this will be charged directly to a chartstring.

Let me know if that changes the hosting preference or decision or not.

Thanks.
Dong

Grant new

Update routes

Does FormBuilder need its own namespace within the application? Should it be nested under the grant?

Add global_admin role

Per request.

Review devise suggested implementations

Rename FormBuilder module to 'GrantSubmission'

Related to #68

Allow non-admin users to submit responses to grant submission form

• Must be within submission period

• Requirements for functionality:

  • Create View logic for displaying links
  • Create Validations in Model to check for submissions
  • Pundit policy for user (submitter)

Notify submitter when question changes

If a user has already submitted to a grant, notify them if a question or constraint has changed.

9. Submission policy

Integrate form_builder

10. Response policy

Review Formbuilder string varchar limits once running

There are varchar limits that should be decreased once it is running. These can be found in

surveys
questions
std_answer_sets
std_answers
answers

Relates to #68

Define policies for form_builder models

Related to #68

e.g. available? method in FormBuilder::ResponseSet (~line 109)