nuclear-verification-and-disarmament/miso_enrichment

A multi isotope enrichment module for the nuclear fuel cycle simulator Cyclus

miso_enrichment's Issues

Segmentation fault on Ubuntu and Fedora

When running the example simulation provided in miso_enrichment/input/, I receive the following error on Fedora33 (compiled using GNU 10.2.1):

malloc(): unaligned tcache chunk detected
Aborted (core dumped)

and on Ubuntu 18.04.5 LTS (compiled using GNU 7.5.0):

Segmentation fault (core dumped)

Both cyclus and misoenrichment unit tests run successfully.

I have narrowed down the problem to line 318 in enrichment_calculator.cc:
https://github.com/maxschalz/miso_enrichment/blob/9786245990680de269f6df81bc0ab4590066d363/src/enrichment_calculator.cc#L308-L320
The calculations work but assigning the result to s[i] fails for unknown reasons. All variables (alpha_star, isotopes, n_enriching and n_stripping) are initialised and have value(s) assigned to them.

Change #include of FlexibleInput header and source file

Change flexible_input.cc to flexible_input.tpp to clearly mark it as a template implementation. Then place #include "flexible_input.tpp" at the end of the header file and import said header file in, e.g., miso_enrich.h etc.

See https://stackoverflow.com/a/495056/15268739

nlohmann::json not working

I do not manage to correctly include the json package in the build process and always end up with a fatal error that #include <nlohmann/json.hpp> was not found...

Initialise all values in MIsoEnrich constructor

Currently missing are:

• current_swu_capacity
• FlexibleInput and related stuff (e.g., swu_capacity_times and so on)

and maybe others