numde/compass-numapp-web

NUM COMPASS web app

compass-numapp-web's Issues

items with type = "date" are always required

Describe the bug
When confronted with a date field, the user has to enter a value, even though it is specified as not required (required is not set in the questionnaire).

To Reproduce
Steps to reproduce the behavior:

1. Load GECCO questionnaire from implementation guide into IBM Backend
2. Open Questionnaire in WebApp
3. Click through the questionnaire without answering any questions, at "History of travel" (1.21.1) you're stopped

Expected behavior
I can skip through date questions and leave them unanswered

Smartphone (please complete the following information):
Windows 10, Firefox

Cannot run the app

Describe the bug
The app does not run when executing npm run dev, instead it crashes with the following output:

[ ERROR ] Node Polyfills Required
For the import "crypto" to be bundled from ./node_modules/node-forge/lib/pbkdf2.js, ensure the
"rollup-plugin-node-polyfills" plugin is installed and added to the stencil config plugins (client). Please
see the bundling docs for more information. Further information: https://stenciljs.com/docs/module-bundling

[ ERROR ] Node Polyfills Required
For the import "crypto" to be bundled from ./node_modules/node-forge/lib/prng.js, ensure the
"rollup-plugin-node-polyfills" plugin is installed and added to the stencil config plugins (client). Please
see the bundling docs for more information. Further information: https://stenciljs.com/docs/module-bundling

[ ERROR ] Node Polyfills Required
For the import "crypto" to be bundled from ./node_modules/node-forge/lib/rsa.js, ensure the
"rollup-plugin-node-polyfills" plugin is installed and added to the stencil config plugins (client). Please
see the bundling docs for more information. Further information: https://stenciljs.com/docs/module-bundling

[ ERROR ] Node Polyfills Required
"rollup-plugin-node-polyfills" plugin is installed and added to the stencil config plugins (client). Please
see the bundling docs for more information. Further information: https://stenciljs.com/docs/module-bundling

[ WARN ] Bundling Warning UNRESOLVED_IMPORT
'crypto' is imported by ./node_modules/node-forge/lib/pbkdf2.js, but could not be resolved – treating it as
an external dependency

[ WARN ] Bundling Warning UNRESOLVED_IMPORT
'crypto' is imported by ./node_modules/node-forge/lib/prng.js, but could not be resolved – treating it as an
external dependency

[ WARN ] Bundling Warning UNRESOLVED_IMPORT
'crypto' is imported by ./node_modules/node-forge/lib/rsa.js, but could not be resolved – treating it as an
external dependency

[ WARN ] Bundling Warning UNRESOLVED_IMPORT
'crypto' is imported by crypto?commonjs-external, but could not be resolved – treating it as an external
dependency

[35:27.1] build failed, watching for changes... in 6.72 s

To Reproduce
Steps to reproduce the behavior:

1. Clone the project
2. run npm ci
3. run npm run dev

Expected behavior
The app should run

Screenshots
-

Additional context

• os: Windows 10
• npm v7.22.0
• node v14.15.4

Discussion: Format of encrypted payload

Currently, the IBM native app uses the following object structure for the encrypted data:

{
 type: "questionnaire_response",
 data: {
  subjectId: "7bfc3b07-a97d-4e11-8ac6-b970c1745476",
  body: "{\"resourceType\": \"QuestionnaireResponse\"}"
 }
}

while the Data4Life web app uses:

{
 type: "questionnaire_response",
 data: {
  subjectId: "7bfc3b07-a97d-4e11-8ac6-b970c1745476",
  body: {"resourceType": "QuestionnaireResponse"}
 }
}

`

As you can see, data.body is a string in case of the IBM app, while the Data4Life app directly inserts the FHIR as JSON object.

I want to point out that it would be good to define a common behaviour here. Any opinions on this?

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update dependency @types/fhir to v0.0.36
• chore(deps): update dependency prettier to v2.8.7
• fix(deps): update dependency @rollup/plugin-node-resolve to v15
• fix(deps): update dependency @stencil/core to v3
• fix(deps): update dependency @stencil/sass to v3
• fix(deps): update dependency i18next to v22
• fix(deps): update dependency i18next-browser-languagedetector to v7
• 🔐 Create all rate-limited PRs at once 🔐

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• fix(deps): update dependency @stencil/store to v2.0.5
• fix(deps): update dependency dotenv to v16.0.3
• fix(deps): update dependency i18next-browser-languagedetector to v6.1.8
• chore(deps): update dependency @types/node to v18.15.11
• chore(deps): update dependency rollup-plugin-visualizer to v5.9.0
• chore(deps): update jest monorepo to v29.5.0 (@types/jest, jest, jest-cli)
• fix(deps): update dependency @stencil/core to v2.22.3
• fix(deps): update dependency i18next to v21.10.0
• chore(deps): update dependency eslint to v8
• fix(deps): update dependency @d4l/web-components-library to v3
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

npm

package.json

• @d4l/web-components-library 2.29.0
• @rollup/plugin-node-resolve 13.3.0
• @stencil/core 2.17.0
• @stencil/eslint-plugin 0.4.0
• @stencil/router 1.0.1
• @stencil/sass 1.5.2
• @stencil/store 2.0.0
• dotenv 16.0.1
• i18next 21.8.14
• i18next-browser-languagedetector 6.1.4
• jsqr 1.4.0
• node-forge 1.3.1
• @types/fhir 0.0.35
• @types/jest 29.2.3
• @types/node 18.0.3
• eslint 7.32.0
• jest 29.3.1
• jest-cli 29.3.1
• prettier 2.7.1
• rollup-plugin-visualizer 5.6.0
• npm >7.0.0
• node >14.0.0

---

• Check this box to trigger a request for Renovate to run again on this repository

required = true and type = choice issue when only Coding.display is available

Describe the bug

Even though I selected something, I cannot continue. I guess, this is because the answerOptions only element is Coding.display. But e.g. the LHC-Formbuilder emits list of options just like that if no terminology is used to code answerOptions, so I guess this is the official way by the FHIR standard.

To Reproduce
Try the following file (i had to change this extension to .txt to be able to upload it with this commit):
S0000_Well-being and COVID-19.txt

Expected behavior
After I have choosen an element, I could hit the "Fortfahren" button.