Giter Site home page Giter Site logo

Comments (3)

fdncred avatar fdncred commented on July 3, 2024

I've looked at this many times and it really doesn't have anything to do with width. That was my first guess too. It has to do with how characters like emojis are rendered by a given terminal. So, we could probably fix it for one terminal and that would break it in another terminal because they're not rendered the same.

You can also see this by opening our test file in nu_scripts/assets/gh-emoji.json
image

from nushell.

SolitudeSF avatar SolitudeSF commented on July 3, 2024

i just tested kitty, wezterm, alacritty, xterm and gnome terminal and they all display it same way. you dont need to handle all possible emoji combinations, especially bullshit combining, but you can handle most of the cases, especially eastern hieroglyphs, if you just account for correct wcswidth. elvish, for example, handles this case correctly.

from nushell.

fdncred avatar fdncred commented on July 3, 2024

Unfortunately, we don't live in an entirely Linux world, so other platforms need to work too, namely MacOS and Windows. Mitchell @ Ghostty has a good handle on this and wrote about it here https://mitchellh.com/writing/grapheme-clusters-in-terminals. Seems like the best way to go would be to support mode 2027.

from nushell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.