nyu-cds/ark520_assignment3

ark520_assignment3's Issues

Issue 2

Take out any functions that your program does not use (compute_energy)

Issue 1

Take out commented code -- not sure if you heard in class but it's our Prof's pet peeve! :)

Issue-3

In the function definition as well as the function call to report_energy in lines 130 and 183, the assignment of BODIES=BODIES is redundant. By doing this, you are making two copies of the reference to the BODIES dictionary object.
Instead, you can just do one of the below changes

1. Using just BODIES in both these functions will
   (i) pass a reference to the global BODIES object in the function call
   (ii) receive a reference to the global BODIES object in the function definition

2. Do the BODIES assignment in the function definition argument list only and NOT pass anything corresponding to BODIES in the function call. In fact, this is what you have done for the function
   nbody in line 198.

All these make shallow copy of the BODIES dictionary. If you want to do the deep copy, you can use copy.deepcopy(BODIES)

Issue-4

In to_do function, the naming of the variables thing_for_v1 and thing_for_v2 doesn't follow the naming convention. You could use something like body1_velocity_arg and body2_velocity_arg.
OR if you have a better name that convey more information about that variable, you can use that instead.