nyu-cds/cn1036_assignment3

cn1036_assignment3

Assignment 4 Reviewers: github: overwaterland (NetId: hc1924) github: zl1732 (NetId: zl1732)

cn1036_assignment3's Issues

reducing function call overhead

I am suggesting, add the iterations as a parameter for the advance() function. So in line 138, the advance function won't be called for "iterations" time. Instead, pass the iteration to advance, advance(bodies, pairs, 0.01, iterations) to reduce function call overhead.

move import itertools out of the nbody functions

Move the import statement out of the nbody function to avoid repeated import when call nbody function each time.

add testing code

Please add the timeit module to the code so that the readers can test the time when they want to learn from the code.

Add input parameter in functions

hello, I noticed that you call the key in the dictionary three times the first three functions(line 54, line 88, line 110), you could create a local var in nbody function as pass it to the three functions above.