nyu-cds/dk2755_assignment3

Assignment 3 by Dagshayani Kamalaharan(dk2755)

dk2755_assignment3

Assignment 3 by Dagshayani Kamalaharan(dk2755)

Code reviewers for my assignment: neb330 (Barry, Nora E) and ark520 (Kunas, Andrew Richard)

dk2755_assignment3's Issues

Issue 1

In the function updates_vs, you call compute_b multiple times. To cut down on function call overhead, take out the function call and just insert the calculation that's returned by the function.

Use idiomatic access of (key, value) pairs in dictionary

In line 70, you write
for body in BODIES.keys():
(r, [vx, vy, vz], m) = BODIES[body]

Instead, you can simply write:
for (body, (r, [vx, vy, vz], m)) in BODIES.items():

Issue 2

Once you take out the compute_b function call within function update_vs, you can get a speedup by calculation by computing

dt * ((dx * dx + dy * dy + dz * dz) ** (-1.5))

only once, and reusing it for the rest of the operations.

Remove duplicate report_energy()

In line 33-34, you have

    for _ in range(loops):
        report_energy(BODIES, bodies_pair)
        for _ in range(iterations):

And then in line 47 you have

print(report_energy(BODIES, bodies_pair))

The first report_energy() has no side effects, and doesn't print anything, so just remove it!