Reviewer:
- Xing Cui(xc918)
- Yuting Gui(yg1281)
hl2514_assignment3's Introduction
hl2514_assignment3's People
Contributors
Watchers
hl2514_assignment3's Issues
Add comments on combinations()
Add some comments on what will be generated by combinations().
Issue from xc918
The first thing I suggest is to put author name at the beginning.
Issue from xc918
Second, line 39 and 40 show there is a unused function, which has been commented. In order to get a clean code, these two lines should be removed. Everything else is perfect.
Replace dict.keys() to dict
k in dict.keys() will create a temporary list to contains the keys. That will be more and more expensive when dict gets large. Just replace "k in dict.keys()" with "k in dict", which will save both space and time.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.