oakch / scheduler Goto Github PK
View Code? Open in Web Editor NEWVacation Scheduler for the Oakland Children's Hospital
Vacation Scheduler for the Oakland Children's Hospital
== Oakland Children's Hospital == Vacation Scheduler This team's first Rails app, built for the nurses at the Children's Hospital of Oakland. Rake Task to reset the database and preload some nurses, admins, and vacations: rake db:reset_and_seed The previous command should put 7 nurses, 1 unit, 1 admin, and 3 vacations into the development database (all as defined in FactoryGirl). Please view lib/tasks/db.rake for more information. Git quickstart/command reminders 1. Fork this repo on Github 2. Clone your fork of the repo 3. Add the OakCH/scheduler as a remote git remote add upstream [email protected]:OakCH/scheduler.git Before starting to work on a new feature/fix: 4. Update master branch for your fork git checkout master git pull upstream master 4. Create a branch for your work, the branch should be named after the feature being implemented git checkout -b descriptive_branch_name 5. Work on this branch, committing and pushing to your repo git add ____ git commit -m "Nice commit message" git push origin descriptive_branch_name When you are done with your feature, submit a pull request through Github that includes the relevant commits! If you want to later delete the branch you created since it's been merged in: git checkout master git branch -d descriptive_branch_name git push origin :descriptive_branch_name
Once we have a notion of time, we need to ensure that events are not scheduled in the past (say 1990) or on a date years down the road (say 2022). Right now, it is possible to do both those things.
The page crashes when params[:admin][:unit]
is either nil or contains an id that does not correspond to an actual unit. Similarly, a check for the shift validity is also probably necessary to make sure that params[:admin][:shift]
is one of Unit.shifts
.
I think it's because at the beginning of upload, you initialize flash[:error] to an empty array. Basically, you are:
so the flash[:error] is always an empty array.
a fix I did was getting rid of flash[:error] = [] and instead checking to see if flash[:error] existed every time you added an error message. I think this method isn't very DRY so you're probably better off thinking of another solution.
After deleting a vacation segment, the calendar controller will default back to the current month/year instead of the month/year that was being viewed. There are other examples of the same behavior such as when clicking edit vacation segment and then clicking back to calendar.
If a nurse is logged in, only that nurse's name should up in the strips.
Admin upload page needs instructions that include:
Nurse.required_columns
)Nurse.optional_columns
)Perhaps this could be a popup with a link for instructions as to not clutter the page? Or a link to another page? Or maybe just on the same page?
Or specify that admins should resubmit finalize for each new year
@christinelu to fix after finals
Convert to SASS would be great too.
User email has already been taken
Email has already been taken
can we consolidate?
Upload instructions should include the fact that "years worked" is an optional column.
Cases such as when user input is invalid. These cases should probably go along with some RSpec tests.
= form_tag "/nurse/#{@nurse_id}/calendar/#{@id}", :method => :put do
should use a form helper.
line 50 event = Event.new(params[:event]) because of mass assignment w/out attr accessible.
potentially malicious - not sure:
line 10 @event_strips = Event.event_strips_for_month(@shown_month, :include => :nurse, :conditions => "nurses.unit_id = #{@unit_id} and nurses.shift = '#{@shift}'")
UPDATE: rx says potentially malicious; change it to the '?' notation
Steps: add in a new vacation. Try to edit either by using the list on the bottom or by clicking the event in the calendar. It would not let me edit, but I am still able to edit my first vacation segment
I think it's because %option{:value => u.id} #{u.name} needs a ":selected => s == @Unit" like we do in shift.
Currently, an admin who clicks on a particular nurse or vacation has no link to get back to the admin calendar index that they start on. Links should be added on all the calendar pages an admin can reach to get back to start.
Rules logic prevents adding a day to the segment for nurse 1 (the nurse 1 after one runs: rake db:reset_and_seed). The error I get is: "Max day You have selected a day that has no more availability"
either all unit, then shift or shift, then unit
Need to remove hard coded year value and dates based around Time.now
application.html.haml
needs flash[:notice]
and flash[:error]
for use by the rest of the application.
nurse_view_calendar.feature
The page (/admin/calendar) should still load even if there are no units, so that controller code should be able to handle the case.
from may -> april, for example
For ordering purposes. rx recommended it?? idk if it's actually necessary at this stage.
sheel: It's a pretty easy fix with the code we have, just throw in a .sort before the .each and the ordering will always be the same.
The roo gem currently only works on local machines, needs to be able to function on Heroku.
probably better if we did MM/DD/YYYY?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.