oam-dev/admission-controller

Admission controller is used for mutating and validating OAM component, trait and application configuration spec.

admission-controller's Issues

validate properties of {Trait\AppScope\Workload Type} as their definition

check trait can apply to component workload type

Use the same spec lib with oam-go-sdk

https://github.com/oam-dev/oam-go-sdk/tree/master/api/v1alpha1

mutate FromVariable in admission controller

https://github.com/oam-dev/admission-controller/blob/master/pkg/admit/appconfig.go#L100

invalidate if a worker tries to bind to a port

https://github.com/oam-dev/admission-controller/blob/master/pkg/admit/component.go#L29

after this implemented in admission controller, validate could be remove in rudr oam-dev/rudr#348

check component/trait really have parameters or properties mentioned in AppConfig

https://github.com/oam-dev/admission-controller/blob/master/pkg/admit/appconfig.go#L51

check workload type contains with GVK

https://github.com/oam-dev/spec/blob/master/3.component_model.md#workload-types

name of component consume and expose should be unique

Optional field should be use pointer

Expect

Compare to kubenetes core/api, optional struct field should be use pointer, such as LivenessProbe *Probe.
We can check this filed is null if not set the field in yaml file.

https://github.com/kubernetes/kubernetes/blob/81af5baff8e958dc8817913ec3c4172028f30122/pkg/apis/core/types.go#L2063-L2069

Current

LivenessProbe and other field should be optional.

type Container struct {
	Name            string       `json:"name"`
	Image           string       `json:"image"`
	Resources       Resources    `json:"resources"`
	Cmd             []string     `json:"cmd"`
	Args            []string     `json:"args"`
	Env             []Env        `json:"env"`
	Config          []ConfigFile `json:"config"`
	Ports           []Port       `json:"ports"`
	LivenessProbe   HealthProbe  `json:"livenessProbe"`
	ReadinessProbe  HealthProbe  `json:"readinessProbe"`
	ImagePullSecret string       `json:"imagePullSecret"`
}

make value of workloadSetting and properties in AppConfig Trait binding consistent with OAM spec

follow oam-dev/rudr#336