Breaks `icomplete-vertical' resize and obscures candidates

[oantolin]

Breaks `icomplete-vertical' resize and obscures candidates

[protesilaos]

UPDATE: the note about SPC completing the first match is due to this not actually removing the command:

(define-key minibuffer-local-map (kbd "SPC") nil)

Had to use:

(define-key icomplete-minibuffer-map (kbd "SPC") nil)

With that in place, the behaviour of completing the first candidate is no longer present, though all the rest do persist.

[oantolin]

Try it now, I think I fixed the bug with no matches.

I'm a little surprised about SPC being bound in icomplete-minibuffer-map, I don't seem to have it bound there. Maybe it's because we're on different Emacs versions?

[protesilaos]

Okay, I will check.

With regard to the keymap I am on Emacs 27.0.90. I think something has to do with icomplete-mode. I even tried it in emacs -Q:

;; Works on its own
(define-key minibuffer-local-map (kbd "SPC") nil)

;; Defaults to `minibuffer-complete-word'
(icomplete-mode 1)

Even if I disable the mode and evaluate the key again, it still gives me minibuffer-complete-word.

At any rate, your latest commit seems to have fixed this issue.

[oantolin]

Oh! I made a typo, sorry! It should say:

(define-key minibuffer-local-completion-map (kbc "SPC") nil)

I missed the word "completion". I'll go update the README.

At any rate, your latest commit seems to have fixed this issue.

You mean the errors and disappearing candidates? The fixed worked in your testing too?

[protesilaos]

Yes, the errors can no longer be reproduced.

[oantolin]

Excellent, I'm closing this issue then. Thanks for reporting! [Now I'll go take a look at the other issues you filed. :)]

[protesilaos]

Great!

[protesilaos]

By the way, this patch concerns the key map you fixed earlier. I can do the pull request thing if you want, but am okay either way.

 orderless.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/orderless.el b/orderless.el
index c515056..6290e26 100644
--- a/orderless.el
+++ b/orderless.el
@@ -35,13 +35,13 @@
 ;; documentation.
 ;;
 ;; By default the space key is bound to `minibuffer-complete-word' in
-;; `minibuffer-local-map', which isn't useful with this completion
-;; method. So, if you use it, you should also unbind SPC.
+;; `minibuffer-local-completion-map', which isn't useful with this
+;; completion method. So, if you use it, you should also unbind SPC.
 ;;
 ;; So to test this completion you can use the following configuration:
 ;;
 ;; (setq completion-styles '(orderless))
-;; (define-key minibuffer-local-map (kbd "SPC") #'self-insert-command)
+;; (define-key minibuffer-local-completion-map (kbd "SPC") #'self-insert-command)
 
 ;;; Code: