oatmealine/boteline

a friendly swiss knife discord bot from celeste mountain built on cumsystem mostly focusing on fun or utility commands

boteline's Issues

Refactor util.ts

I've selected util.ts for refactoring, which is a module of 513 lines of code and 83 incoming calls. Addressing this will make our codebase more maintainable and improve Better Code Hub's Separate Concerns in Modules guideline rating! 👍

Here's the gist of this guideline:

• Definition 📖
  Avoid large modules with high fan-in (nr. of incoming calls).
• Why❓
  This keeps the codebase loosely coupled which makes it easier to minimize the consequences of changes.
• How 🔧
  Identify and extract responsibilities of large modules into smaller ones and hide implementation details behind interfaces. Target having modules that have no more than 10 incoming calls.

penis!!!!!!!!!!!!!!!!

apply paginator to help

change addCommands format

instead of doing

function addCommands(cs) {
  cs.addCommand
  cs.addCommand
  // ...
}

just

commands = []
function addCommands(cs) {
  for (let c of commands) {
    cs.addCommand
  }
}

i think thatd be smart

Refactor main.ts

i should probably split events into seperate files, thatd be smart

Bad practice when several texts translating

yt.translate(params.join(' '), { to: lang, format: 'plain' }).then(translated => {
    let translateEmbed = new Discord.RichEmbed().setDescription(translated);
})

Привет,
это не совсем корректный подход к переводу так как при склеивании нескольких фраз в одну строку params.join(' ') может измениться общий смысл получившейся фразы.

Правильнее будет передавать params как массив и в колбеке сделать translated.join(' ')

Refactor util.ts 2: electric boogaloo

i think its still not enough lets do more refactoring
lets fuckin dismantle util.ts

Refactor video.ts.addCommands

please do. fucking PLESASE

Refactor fun.ts.addCommands

do it. now