oberonamsterdam/create-react-stack

A opinionated generator for react projects

create-react-stack's Issues

Road to 1.0

Bottomline: automate as much as possible to make this project feasible.

• tests for each of the types of applications (every generator). (#11)
  • File system snapshot creation
  • Load fs snapshot with memfs from tests
  • Write tests for all questions
• Add travis, 2 scripts:
  • build (backpack build)
  • test
• Add greenkeeper to automatically test new versions of generators and other dependencies
  • add generators (expo, react-native-cli, razzle, etc) as devDependencies so greenkeeper will monitor them
  • CRS needs to read the generator version from it's package.json and use it during install (#18)

Dummy redux file

A standard redux reducer should be added once redux is enabled, in the same format as the redux file template included in ide-react-redux

composeEnhancers is unused

in createStore.js (if using redux),
const composeEnhancers is unused and not in the store as enhancer

Error in react native setup

After the react native setup it gives me the following error:

To run your app on iOS:
   cd /Users/karendegraaf/projects/createReactStack
   react-native run-ios
   - or -
   Open ios/createReactStack.xcodeproj in Xcode
   Hit the Run button
To run your app on Android:
   cd /Users/karendegraaf/projects/createReactStack
   Have an Android emulator running (quickest way to get started), or a device connected
   react-native run-android
create-react-stack ERR! Error: No files match the pattern: /Users/karendegraaf/projects/createReactStack/index.*.js
    at glob (/Users/karendegraaf/.npm/_npx/53772/lib/node_modules/create-react-stack/node_modules/replace-in-file/lib/replace-in-file.js:173:23)
    at f (/Users/karendegraaf/.npm/_npx/53772/lib/node_modules/create-react-stack/node_modules/once/once.js:25:25)
    at Glob.<anonymous> (/Users/karendegraaf/.npm/_npx/53772/lib/node_modules/create-react-stack/node_modules/glob/glob.js:151:7)
    at emitOne (events.js:115:13)
    at Glob.emit (events.js:210:7)
    at Glob._finish (/Users/karendegraaf/.npm/_npx/53772/lib/node_modules/create-react-stack/node_modules/glob/glob.js:197:8)
    at done (/Users/karendegraaf/.npm/_npx/53772/lib/node_modules/create-react-stack/node_modules/glob/glob.js:182:14)
    at Glob._processReaddir2 (/Users/karendegraaf/.npm/_npx/53772/lib/node_modules/create-react-stack/node_modules/glob/glob.js:408:12)
    at /Users/karendegraaf/.npm/_npx/53772/lib/node_modules/create-react-stack/node_modules/glob/glob.js:371:17
    at RES (/Users/karendegraaf/.npm/_npx/53772/lib/node_modules/create-react-stack/node_modules/inflight/inflight.js:31:16)

Opt-in on HTML meta tags, such as author

Meta tags on website projects often get overlooked during development. If asked on creation, it won't be forgotten.

remove babel-polyfill, replace with recommendation to use core-js instead

babel-polyfill includes a bunch of stuff you might not need.
with core-js you selectively choose your polyfills, and it is therefore a more suitable choice

react-router option

We now ship react-router by default once SSR is enabled, preferably the razzle basic example would be used, and the default template would be used (which includes react-router) if react-router is needed.
On top of that, with projects bootstrapped with CRA, we'd have to provide our own template which includes a basic react-router setup

Global state

questions right now need to defer things like 'are we ejected from CRA' etc from certain answers to certain questions. this is kind of ugly and error prone.

Preferably we'd have a shared state between all questions to store changes that go beyond 'what answer was given'

Navigation library for react native

The options are

• React Router
• react-navigation
• react-native-navigation

Error in flow and SSR setup

Eslint default config spewing out stacktrace

When not giving a eslint config (so it defaults to 'react-app'), eslint auto fix fails.
Could confuse the user.

Add babel-plugin-styled-components in case SC is enabled

Pretty much an essential for working with styled-components:
https://github.com/styled-components/babel-plugin-styled-components

Optional dependencies are installed under dev deps

All optional dependencies are installed under dev dependencies

stack

Error in no SSR with flow setup

remove eslint loader from oberon-razzle-modifications

Razzle now has build in eslint support

Error: No files match the pattern: /config/webpack.config.dev.js

Ejection check fails

stack:

? Are you building a mobile project? (https://facebook.github.io/react-native/) No
? Use SSR? (server side rendering) No
? Use flow? (http://flow.org) Yes
? Use redux? (http://redux.js.org/) Yes
? Use redux-persist? (https://github.com/rt2zz/redux-persist) Yes
? What ESLint config should to be used? Enter the eslint-config-name react-app
? Use babel-polyfill? (adds IE support) (https://babeljs.io/docs/usage/polyfill/) Yes
? Use styled-components? (http://styled-components.com) Yes

Use create-react-native-app instead of react-native CLI for RN projects

It is now the recommended way to start a project (quickly) in the RN docs.
As CRS doesn't include any native modules, it's probably best to replace the RN CLI with CRNA

Lock generators to major

Lock

• react-native cli
• razzle
• create-react-app

down to a specific (major) version.

File structure changes by these tools are fatal to CRS and will break it.
We'll be responsible for manually updating the used version of the generators.

Tests

Because of the way this project works, there are lot of different situations that can possibly break.
That's why this project absolutely needs tests to continue development.

Random = file when creating project

Web app without SSR, with redux