objcio/issue-1-lighter-view-controllers

Example project for the 1st issue of objc.io

issue-1-lighter-view-controllers's Issues

你好 问个问题

你这个demo cell高度都是固定的，现实项目中 cell动态的多，咋算高度啊？咋封装

请教一个问题关于数据持有

如果传递给DataSource里边的array在外部需要动态改变呢，这个时候怎么再次传递给tablview呢

'Photo' objects are leaking

Hi,

'Photo' objects never get released which results in memory leaks.

'ArrayDataSource' copies block of type 'TableViewCellConfigureBlock'.
I think during this copy of block, 'Photo' instances are copied and retained too.

I put following NSLog statement in Photo which never get printed.

// Photo.m
-(void) dealloc
{
NSLog(@"%s",PRETTY_FUNCTION);
}

---

In fact, I profiled memory footprint in instruments. It goes like this:

1. I have added 'HomeViewController' as rootviewcontroller of navigation controller. HomeVC has a button 'Launch'. Memory usage till point is 14.4MB.

2. Action on 'Lunch' button will push 'PhotosViewController'. Memory usage after successful loading of 'PhotosViewController' is 17.3MB.

3. 'Back' button in navigation bar, pops 'PhotosViewController' & 'HomeViewController' appears. Memory usage till point is 16.2MB. I was expecting it to be close to 14.3MB

//AppDelegate.M
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
HomeViewController * hmv = [HomeViewController new];
UINavigationController *navigationController = [[UINavigationController alloc] initWithRootViewController:hmv];
....
}

//HomeViewController.m
-(IBAction) launch:(id)sender
{
PhotosViewController *photosViewController = [[PhotosViewController alloc] initWithNibName:@"PhotosViewController"
bundle:nil];
[self.navigationController pushViewController:photosViewController animated:YES];
}

写的是牛逼

但是代码那么绕 ，看着不辛苦吗

How to handle multiple custom cells?

This approach works great for having one custom cell per table view. But how would one handle multiple customs cells with this approach? Saying you would like to use different cell layouts based on your model attributes.

Why not just place data source methods into a superclass?

I'm at a loss to the advantage here. Seems to me you'd have the same amount of code, and the same number of files if you just moved the code to a superclass rather than another object.

Ex:
superclass with photoDataSource methods
subclass
2 files

object with photoDataSource methods
uiviewcontroller with object set as datasource
2 files

Is there an advantage I am missing to not just placing all the photoDataSource methods into a superclass rather than a separate object?

PhotosViewControllerTests failed

Just clone the source code, update submodule, and run the test
Note: the app is built and run normally